mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-10-01 11:31:15 +00:00
Merge #7778
7778: Fix lowering trailing self paths in UseTrees r=Veykril a=Veykril Noticed that hovering over `self` in a use tree like `use foo::bar::{self}` showing documentation and such for the current module instead of `bar`. Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
This commit is contained in:
commit
f3139d46b0
@ -101,8 +101,12 @@ pub(super) fn lower_path(mut path: ast::Path, hygiene: &Hygiene) -> Option<Path>
|
|||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
ast::PathSegmentKind::SelfKw => {
|
ast::PathSegmentKind::SelfKw => {
|
||||||
kind = PathKind::Super(0);
|
// don't break out if `self` is the last segment of a path, this mean we got an
|
||||||
break;
|
// use tree like `foo::{self}` which we want to resolve as `foo`
|
||||||
|
if !segments.is_empty() {
|
||||||
|
kind = PathKind::Super(0);
|
||||||
|
break;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
ast::PathSegmentKind::SuperKw => {
|
ast::PathSegmentKind::SuperKw => {
|
||||||
let nested_super_count = if let PathKind::Super(n) = kind { n } else { 0 };
|
let nested_super_count = if let PathKind::Super(n) = kind { n } else { 0 };
|
||||||
@ -117,6 +121,11 @@ pub(super) fn lower_path(mut path: ast::Path, hygiene: &Hygiene) -> Option<Path>
|
|||||||
segments.reverse();
|
segments.reverse();
|
||||||
generic_args.reverse();
|
generic_args.reverse();
|
||||||
|
|
||||||
|
if segments.is_empty() && kind == PathKind::Plain && type_anchor.is_none() {
|
||||||
|
// plain empty paths don't exist, this means we got a single `self` segment as our path
|
||||||
|
kind = PathKind::Super(0);
|
||||||
|
}
|
||||||
|
|
||||||
// handle local_inner_macros :
|
// handle local_inner_macros :
|
||||||
// Basically, even in rustc it is quite hacky:
|
// Basically, even in rustc it is quite hacky:
|
||||||
// https://github.com/rust-lang/rust/blob/614f273e9388ddd7804d5cbc80b8865068a3744e/src/librustc_resolve/macros.rs#L456
|
// https://github.com/rust-lang/rust/blob/614f273e9388ddd7804d5cbc80b8865068a3744e/src/librustc_resolve/macros.rs#L456
|
||||||
|
@ -3496,4 +3496,33 @@ mod foo$0;
|
|||||||
"#]],
|
"#]],
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn hover_self_in_use() {
|
||||||
|
check(
|
||||||
|
r#"
|
||||||
|
//! This should not appear
|
||||||
|
mod foo {
|
||||||
|
/// But this should appear
|
||||||
|
pub mod bar {}
|
||||||
|
}
|
||||||
|
use foo::bar::{self$0};
|
||||||
|
"#,
|
||||||
|
expect![[r#"
|
||||||
|
*self*
|
||||||
|
|
||||||
|
```rust
|
||||||
|
test::foo
|
||||||
|
```
|
||||||
|
|
||||||
|
```rust
|
||||||
|
pub mod bar
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
But this should appear
|
||||||
|
"#]],
|
||||||
|
);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user