Chayim Refael Friedman
ba6f6e2e34
Add the quickfix for increasing visibility of a private field to the private-field diagnostic (previously it was only on no-such-field)
...
The difference between the diagnostics is that no-such-field is for record struct construction, while private-field is for dot syntax.
I tried to unify them, but there is a bit of uniqueness in each. This is possible but maybe not worth it.
Also, fix the quickfix when there is already a visibility to the field (replace it instead of appending to it).
2025-06-08 15:17:34 +03:00
Chayim Refael Friedman
7b64b407e8
Correctly handle attr macros placed in cfg_attr in speculative expansion
2025-06-08 01:44:14 +03:00
Chayim Refael Friedman
cc50868148
Remove the optimization of builtin attrs in is_inside_macro_call()
...
`#[cfg_attr]` is a builtin attr, but it may still contain a macro.
2025-06-08 01:07:55 +03:00
Chayim Refael Friedman
25a7b2480e
In "Fill match arms", allow users to prefer Self to the enum name when possible
...
But default to not to.
I chose to have a more generic config name because maybe other assists could also use the same approach.
2025-06-06 16:34:53 +03:00
Vincent Esche
1a3feeebc4
Make Semantics<'db, dyn HirDatabase> actually usable
2025-06-06 09:45:34 +02:00
Lukas Wirth
6acff6c1f8
Merge pull request #19908 from rmehri01/rmehri01/diagnostic_attribute_completions
...
feat: implement attribute completions for diagnostics module
2025-06-06 07:19:13 +00:00
Lukas Wirth
4fd1cdb3e3
Merge pull request #19937 from Veykril/push-rvnylnlnxxyr
...
fix: Record macro calls for fields in `ChildBySource` impls
2025-06-06 05:45:48 +00:00
Lukas Wirth
cad9cc97e2
Merge pull request #19935 from ChayimFriedman2/exp-diag-show-quickfix
...
fix: Always include quickfixes for diagnostics, even when diagnostics are disabled
2025-06-06 05:35:52 +00:00
Lukas Wirth
8e217cc68a
fix: Record macro calls for fields in ChildBySource impls
2025-06-06 07:34:42 +02:00
Chayim Refael Friedman
41f5de12bd
Stabilize unlinked file diagnostic
2025-06-06 03:55:57 +03:00
Chayim Refael Friedman
869714aae0
Always include quickfixes for diagnostics, even when diagnostics are disabled
2025-06-06 03:52:32 +03:00
Lukas Wirth
d5665e5ca7
Merge pull request #19933 from Veykril/push-uyxorpyvnzsl
...
Better parser recovery for macro calls in type bound position
2025-06-05 14:23:04 +00:00
Lukas Wirth
5d3001795a
Better parser recovery for macro calls in type bound position
2025-06-05 16:11:30 +02:00
Lukas Wirth
bb5e6deff5
fix: Record macro calls in signatures in ChildBySource impls
2025-06-05 15:04:50 +02:00
Paolo Barbolini
69f077653a
Stabilize const_eq_ignore_ascii_case
2025-06-05 07:09:16 +00:00
Lukas Wirth
634596e2d7
Merge pull request #19928 from Veykril/push-kznpuqllrvvq
...
Deduplicate code in proc-macro-srv
2025-06-05 05:36:01 +00:00
Lukas Wirth
02a788bfaa
Deduplicate code in proc-macro-srv
2025-06-05 07:25:15 +02:00
Ryan Mehri
b95101ce46
add qualifiers to attribute completions
2025-06-04 11:02:48 -04:00
Ryan Mehri
f1cc7c5c92
match on segments of path and some small cleanup
2025-06-04 08:30:27 -04:00
Lukas Wirth
b94e766791
refactor: Cleanup descension stuff
2025-06-04 12:32:02 +02:00
Lukas Wirth
2dc5aa885a
Merge pull request #19922 from Veykril/push-oxyomxrsplpx
...
feat: Add `dyn` keyword inlay hints
2025-06-04 09:51:22 +00:00
Lukas Wirth
b9733810bb
feat: Add dyn keyword inlay hints
2025-06-04 11:40:05 +02:00
Lukas Wirth
7c3de05e3a
Give path segment type anchors their own grammar rule
2025-06-04 11:40:05 +02:00
Lukas Wirth
d2164fe08b
Remove unnecessary parameters in inlay-hint computation
2025-06-04 11:31:45 +02:00
David Barsky
98f32c1de1
hir-ty: add incremental tests checking for infer invalidation
2025-06-03 13:48:45 -04:00
Lukas Wirth
cf969d21c3
Merge pull request #19869 from MatrixFrog/publicize_field
...
Add a quickfix for accessing a private field of a struct
2025-06-03 06:11:28 +00:00
Lukas Wirth
ed2ae943bb
Merge pull request #19894 from ShoyuVanilla/some-query-cycles
...
fix: Cycle handlers for `HirDatabase::infer, const_param_ty_with_diagnostics`
2025-06-03 06:08:46 +00:00
Lukas Wirth
9edac77f48
Merge pull request #19901 from BazookaMusic/master
...
Enable Assist edit for tuple<->named struct for the struct and visiblity keywords
2025-06-03 06:07:39 +00:00
Tyler Breisacher
4055436776
Add a quickfix for accessing a private field of a struct
2025-06-02 22:45:34 -07:00
Shoyu Vanilla
fefe86732d
fix: Cycle handlers for `HirDatabase::infer, const_param_ty_with_diagnostics
2025-06-03 10:39:38 +09:00
Ryan Mehri
7e8079fbad
feat: implement completion for diagnostic module
2025-06-02 20:56:20 -04:00
BazookaMusic
34b31f174d
simplify expression that checks the offset
2025-06-02 23:28:26 +02:00
Ryan Mehri
fb921c3039
fix: don't duplicate must_use for functions and traits
2025-06-02 15:35:13 -04:00
Lukas Wirth
9a786d0008
Support derive-macros for rename prefix magic
2025-06-02 15:27:13 +02:00
Lukas Wirth
96c4455114
fix: Fix edition handling for names in rename logic
2025-06-02 15:27:13 +02:00
Lukas Wirth
42e8e4ac4e
Enhance renaming to include identifiers that are generated from the original symbol
...
Co-authored-by: Jake Goulding <jake.goulding@integer32.com>
2025-06-02 15:26:21 +02:00
Wilfred Hughes
005d8c59ab
internal: Use 'ProjectJson' consistently
...
The Rust source code previously mised ProjectJson and JsonProject,
and the TypeScript definition didn't match either.
Use 'ProjectJson' everywhere. This is purely an internal change.
2025-06-02 11:21:46 +01:00
Lukas Wirth
b9e6671353
Merge pull request #19897 from aibaars/patch-2
...
Produce ClosureBinder node in atom.rs
2025-06-02 09:13:04 +00:00
BazookaMusic
5caf570d40
clippy and more formatting
2025-06-01 01:20:45 +02:00
BazookaMusic
03276f8a24
rename function so it makes more sense
2025-06-01 01:16:37 +02:00
BazookaMusic
41cd1732b7
Formatting issues resolved
2025-06-01 01:09:23 +02:00
BazookaMusic
7b200890c4
add missing public keyword
2025-06-01 00:47:43 +02:00
BazookaMusic
43072c3a0b
Allow assist edit for converting structs to appear also on struct keyword and on visibility
2025-06-01 00:44:33 +02:00
Kirill Bulatov
4870b6b7c1
Account for Generate actions when filtering the allowed ones
2025-05-31 12:29:50 +03:00
Lukas Wirth
cdd0ac27e3
Merge pull request #19898 from Veykril/push-ykumpuwmuvmu
...
refactor: Remove unncessary duplication in highlight_related
2025-05-31 05:35:49 +00:00
Lukas Wirth
9ee761904e
refactor: Remove unncessary duplication in highlight_related
2025-05-31 07:25:03 +02:00
Arthur Baars
55328ba9b4
Update expected test output
2025-05-30 21:16:38 +00:00
Arthur Baars
a91b67e682
Run 'cargo codegen' to update tests
2025-05-30 21:05:12 +00:00
Arthur Baars
7f7079f2bf
Add test for closure_binder
...
Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
2025-05-30 22:58:13 +02:00
Arthur Baars
fb16d3b7f8
Produce ClosureBinder node in atom.rs
2025-05-30 22:38:31 +02:00
