Nicholas Nethercote
64ea8eb1a9
Disentangle Debug and Display for Ty.
...
The `Debug` impl for `Ty` just calls the `Display` impl for `Ty`. This
is surprising and annoying. In particular, it means `Debug` doesn't show
as much information as `Debug` for `TyKind` does. And `Debug` is used in
some user-facing error messages, which seems bad.
This commit changes the `Debug` impl for `Ty` to call the `Debug` impl
for `TyKind`. It also does a number of follow-up changes to preserve
existing output, many of which involve inserting
`with_no_trimmed_paths!` calls. It also adds `Display` impls for
`UserType` and `Canonical`.
Some tests have changes to expected output:
- Those that use the `rustc_abi(debug)` attribute.
- Those that use the `EMIT_MIR` annotation.
In each case the output is slightly uglier than before. This isn't
ideal, but it's pretty weird (particularly for the attribute) that the
output is using `Debug` in the first place. They're fairly obscure
attributes (I hadn't heard of them) so I'm not worried by this.
For `async-is-unwindsafe.stderr`, there is one line that now lacks a
full path. This is a consistency improvement, because all the other
mentions of `Context` in this test lack a path.
2023-09-11 12:51:07 +10:00
Ralf Jung
254e13d9f9
fix homogeneous_aggregate not ignoring some 1-ZST
2023-09-10 07:38:03 +02:00
Ralf Jung
3bd8bcb8bb
better spans for WF errors
2023-09-09 18:00:13 +02:00
Ralf Jung
c2a7e684cd
use hir_crate_items(()).definitions() instead of hir().items()
2023-09-09 17:39:53 +02:00
Ralf Jung
a5b0311367
rustc_layout, rustc_abi: make sure the types are well-formed
2023-09-09 17:32:12 +02:00
Ralf Jung
e66913f8fe
rustc_layout/abi: error when attribute is applied to the wrong thing
2023-09-06 11:11:06 +02:00
Matthias Krüger
56d7d93a4b
Rollup merge of #111580 - atsuzaki:layout-ice, r=oli-obk
...
Don't ICE on layout computation failure
Fixes #111176 regression.
r? `@oli-obk`
2023-08-29 20:49:02 +02:00
Ralf Jung
bf91321e0f
there seems to be no reason to treat ZST specially in these cases
2023-08-29 08:58:58 +02:00
Ralf Jung
0da9409e08
rustc_abi: audit uses of is_zst; fix a case of giving an enum insufficient alignment
2023-08-29 08:58:58 +02:00
Katherine Philip
56b767322b
Don't ICE on layout computation failure
2023-08-28 12:40:39 -07:00
Ralf Jung
abe2148aee
add rustc_abi debugging attribute
2023-08-27 11:55:49 +02:00
Mara Bos
0e729404da
Change default panic handler message format.
2023-07-29 11:42:50 +02:00
Michael Goulet
37076c9b4e
Don't attempt to compute layout of type referencing error
2023-07-27 18:24:08 +00:00
Matthias Krüger
b7183bd167
Rollup merge of #113957 - Urgau:regression-test-issue-113941, r=dtolnay
...
Add regression test for issue #113941 - naive layout isn't refined
This PR adds a regression test for issue #113941 - `the naive layout isn't refined by the actual layout` based on the minimized repro https://github.com/rust-lang/rust/issues/113941#issuecomment-1646446769 .
2023-07-22 19:57:37 +02:00
Urgau
ffa4b6f422
Add regression test for issue #113941 - naive layout isn't refined
2023-07-22 13:02:59 +02:00
David Tolnay
5bbf0a8306
Revert "Auto merge of #113166 - moulins:ref-niches-initial, r=oli-obk"
...
This reverts commit 557359f92512ca88b62a602ebda291f17a953002, reversing
changes made to 1e6c09a803fd543a98bfbe1624d697a55300a786.
2023-07-21 22:35:57 -07:00
Moulins
7f109086ee
Track (partial) niche information in NaiveLayout
...
Still more complexity, but this allows computing exact `NaiveLayout`s
for null-optimized enums, and thus allows calls like
`transmute::<Option<&T>, &U>()` to work in generic contexts.
2023-07-21 14:23:23 +02:00
Moulins
30ae640a3c
properly handle arrays and wide pointers in naive_layout_of
2023-07-21 03:31:45 +02:00
Moulins
cb8b1d1bc9
add naive_layout_of query
2023-07-21 03:31:45 +02:00
Erik Desjardins
2daacf5af9
i686-windows: make requested alignment > 4 special case apply transitively
2023-07-14 17:48:13 -04:00
Erik Desjardins
d1e764cb3b
aarch64-linux: properly handle 128bit aligned aggregates
2023-07-10 19:19:40 -04:00
Erik Desjardins
7e933b4e26
repr(align) <= 4 should still be byval
2023-07-10 19:19:40 -04:00
Erik Desjardins
4c1dbc3aec
bless layout tests for has_repr_align in debug output
2023-07-10 19:19:39 -04:00
Michael Goulet
32f83e18ab
Better error message
2023-06-19 20:00:41 +00:00
Michael Goulet
dd620aa73a
Don't ICE on unnormalized struct tail in layout computation
2023-06-19 20:00:41 +00:00
Wesley Wiser
b982f3a988
Add test case for unsizing with niche
2023-06-13 15:32:42 -04:00
Lukas Markeffsky
381b778d27
Make struct layout not depend on unsizeable tail
2023-05-29 14:54:48 +02:00
Luqman Aden
f2d81defa1
Add additional test case for repr(packed) allowing union abi opt to kick in.
2023-05-05 16:05:04 -07:00
Luqman Aden
d5ab3a06d2
Add test cases for #104802 .
2023-05-05 16:05:03 -07:00
Oli Scherer
23d09aebc8
Do not use scalar layout if there are ZSTs with alignment > 1
2023-05-05 16:00:12 -07:00
The 8472
1a51ec6864
bless tests
2023-04-27 22:29:04 +02:00
Esteban Küber
9fadcc143a
Special-case item attributes in the suggestion output
2023-04-12 22:50:10 +00:00
Esteban Küber
5b40aa5eb4
Tweak output for 'add line' suggestion
2023-04-12 22:50:10 +00:00
Michael Goulet
0bb876ebe7
Layout of &dyn Trait<[type error]> is still wide
2023-03-13 21:35:20 +00:00
Esteban Küber
a7597a1526
Tweak ICE message
...
Modify main message to be more conversational and emit one fewer note.
2023-02-07 19:17:24 +00:00
Albert Larsan
cf2dff2b1e
Move /src/test to /tests
2023-01-11 09:32:08 +00:00
