mirror of
https://github.com/rust-lang/rust.git
synced 2025-12-01 21:59:08 +00:00
This works for most of its call sites. This is nice, because `emit` very
much makes sense as a consuming operation -- indeed,
`DiagnosticBuilderState` exists to ensure no diagnostic is emitted
twice, but it uses runtime checks.
For the small number of call sites where a consuming emit doesn't work,
the commit adds `DiagnosticBuilder::emit_without_consuming`. (This will
be removed in subsequent commits.)
Likewise, `emit_unless` becomes consuming. And `delay_as_bug` becomes
consuming, while `delay_as_bug_without_consuming` is added (which will
also be removed in subsequent commits.)
All this requires significant changes to `DiagnosticBuilder`'s chaining
methods. Currently `DiagnosticBuilder` method chaining uses a
non-consuming `&mut self -> &mut Self` style, which allows chaining to
be used when the chain ends in `emit()`, like so:
```
struct_err(msg).span(span).emit();
```
But it doesn't work when producing a `DiagnosticBuilder` value,
requiring this:
```
let mut err = self.struct_err(msg);
err.span(span);
err
```
This style of chaining won't work with consuming `emit` though. For
that, we need to use to a `self -> Self` style. That also would allow
`DiagnosticBuilder` production to be chained, e.g.:
```
self.struct_err(msg).span(span)
```
However, removing the `&mut self -> &mut Self` style would require that
individual modifications of a `DiagnosticBuilder` go from this:
```
err.span(span);
```
to this:
```
err = err.span(span);
```
There are *many* such places. I have a high tolerance for tedious
refactorings, but even I gave up after a long time trying to convert
them all.
Instead, this commit has it both ways: the existing `&mut self -> Self`
chaining methods are kept, and new `self -> Self` chaining methods are
added, all of which have a `_mv` suffix (short for "move"). Changes to
the existing `forward!` macro lets this happen with very little
additional boilerplate code. I chose to add the suffix to the new
chaining methods rather than the existing ones, because the number of
changes required is much smaller that way.
This doubled chainging is a bit clumsy, but I think it is worthwhile
because it allows a *lot* of good things to subsequently happen. In this
commit, there are many `mut` qualifiers removed in places where
diagnostics are emitted without being modified. In subsequent commits:
- chaining can be used more, making the code more concise;
- more use of chaining also permits the removal of redundant diagnostic
APIs like `struct_err_with_code`, which can be replaced easily with
`struct_err` + `code_mv`;
- `emit_without_diagnostic` can be removed, which simplifies a lot of
machinery, removing the need for `DiagnosticBuilderState`.
234 lines
7.7 KiB
Rust
234 lines
7.7 KiB
Rust
use rustc_ast as ast;
|
|
use rustc_ast::ptr::P;
|
|
use rustc_ast::token;
|
|
use rustc_ast::tokenstream::TokenStream;
|
|
use rustc_ast_pretty::pprust;
|
|
use rustc_expand::base::{self, *};
|
|
use rustc_expand::module::DirOwnership;
|
|
use rustc_parse::new_parser_from_file;
|
|
use rustc_parse::parser::{ForceCollect, Parser};
|
|
use rustc_session::lint::builtin::INCOMPLETE_INCLUDE;
|
|
use rustc_span::symbol::Symbol;
|
|
use rustc_span::{Pos, Span};
|
|
|
|
use smallvec::SmallVec;
|
|
use std::rc::Rc;
|
|
|
|
// These macros all relate to the file system; they either return
|
|
// the column/row/filename of the expression, or they include
|
|
// a given file into the current one.
|
|
|
|
/// line!(): expands to the current line number
|
|
pub fn expand_line(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
base::check_zero_tts(cx, sp, tts, "line!");
|
|
|
|
let topmost = cx.expansion_cause().unwrap_or(sp);
|
|
let loc = cx.source_map().lookup_char_pos(topmost.lo());
|
|
|
|
base::MacEager::expr(cx.expr_u32(topmost, loc.line as u32))
|
|
}
|
|
|
|
/* column!(): expands to the current column number */
|
|
pub fn expand_column(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
base::check_zero_tts(cx, sp, tts, "column!");
|
|
|
|
let topmost = cx.expansion_cause().unwrap_or(sp);
|
|
let loc = cx.source_map().lookup_char_pos(topmost.lo());
|
|
|
|
base::MacEager::expr(cx.expr_u32(topmost, loc.col.to_usize() as u32 + 1))
|
|
}
|
|
|
|
/// file!(): expands to the current filename */
|
|
/// The source_file (`loc.file`) contains a bunch more information we could spit
|
|
/// out if we wanted.
|
|
pub fn expand_file(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
base::check_zero_tts(cx, sp, tts, "file!");
|
|
|
|
let topmost = cx.expansion_cause().unwrap_or(sp);
|
|
let loc = cx.source_map().lookup_char_pos(topmost.lo());
|
|
|
|
use rustc_session::{config::RemapPathScopeComponents, RemapFileNameExt};
|
|
base::MacEager::expr(cx.expr_str(
|
|
topmost,
|
|
Symbol::intern(
|
|
&loc.file.name.for_scope(cx.sess, RemapPathScopeComponents::MACRO).to_string_lossy(),
|
|
),
|
|
))
|
|
}
|
|
|
|
pub fn expand_stringify(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
let s = pprust::tts_to_string(&tts);
|
|
base::MacEager::expr(cx.expr_str(sp, Symbol::intern(&s)))
|
|
}
|
|
|
|
pub fn expand_mod(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
base::check_zero_tts(cx, sp, tts, "module_path!");
|
|
let mod_path = &cx.current_expansion.module.mod_path;
|
|
let string = mod_path.iter().map(|x| x.to_string()).collect::<Vec<String>>().join("::");
|
|
|
|
base::MacEager::expr(cx.expr_str(sp, Symbol::intern(&string)))
|
|
}
|
|
|
|
/// include! : parse the given file as an expr
|
|
/// This is generally a bad idea because it's going to behave
|
|
/// unhygienically.
|
|
pub fn expand_include<'cx>(
|
|
cx: &'cx mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'cx> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
let Some(file) = get_single_str_from_tts(cx, sp, tts, "include!") else {
|
|
return DummyResult::any(sp);
|
|
};
|
|
// The file will be added to the code map by the parser
|
|
let file = match resolve_path(&cx.sess.parse_sess, file.as_str(), sp) {
|
|
Ok(f) => f,
|
|
Err(err) => {
|
|
err.emit();
|
|
return DummyResult::any(sp);
|
|
}
|
|
};
|
|
let p = new_parser_from_file(cx.parse_sess(), &file, Some(sp));
|
|
|
|
// If in the included file we have e.g., `mod bar;`,
|
|
// then the path of `bar.rs` should be relative to the directory of `file`.
|
|
// See https://github.com/rust-lang/rust/pull/69838/files#r395217057 for a discussion.
|
|
// `MacroExpander::fully_expand_fragment` later restores, so "stack discipline" is maintained.
|
|
let dir_path = file.parent().unwrap_or(&file).to_owned();
|
|
cx.current_expansion.module = Rc::new(cx.current_expansion.module.with_dir_path(dir_path));
|
|
cx.current_expansion.dir_ownership = DirOwnership::Owned { relative: None };
|
|
|
|
struct ExpandResult<'a> {
|
|
p: Parser<'a>,
|
|
node_id: ast::NodeId,
|
|
}
|
|
impl<'a> base::MacResult for ExpandResult<'a> {
|
|
fn make_expr(mut self: Box<ExpandResult<'a>>) -> Option<P<ast::Expr>> {
|
|
let r = base::parse_expr(&mut self.p)?;
|
|
if self.p.token != token::Eof {
|
|
self.p.sess.buffer_lint(
|
|
INCOMPLETE_INCLUDE,
|
|
self.p.token.span,
|
|
self.node_id,
|
|
"include macro expected single expression in source",
|
|
);
|
|
}
|
|
Some(r)
|
|
}
|
|
|
|
fn make_items(mut self: Box<ExpandResult<'a>>) -> Option<SmallVec<[P<ast::Item>; 1]>> {
|
|
let mut ret = SmallVec::new();
|
|
loop {
|
|
match self.p.parse_item(ForceCollect::No) {
|
|
Err(err) => {
|
|
err.emit();
|
|
break;
|
|
}
|
|
Ok(Some(item)) => ret.push(item),
|
|
Ok(None) => {
|
|
if self.p.token != token::Eof {
|
|
let token = pprust::token_to_string(&self.p.token);
|
|
let msg = format!("expected item, found `{token}`");
|
|
self.p.dcx().struct_span_err(self.p.token.span, msg).emit();
|
|
}
|
|
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
Some(ret)
|
|
}
|
|
}
|
|
|
|
Box::new(ExpandResult { p, node_id: cx.current_expansion.lint_node_id })
|
|
}
|
|
|
|
/// `include_str!`: read the given file, insert it as a literal string expr
|
|
pub fn expand_include_str(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
let Some(file) = get_single_str_from_tts(cx, sp, tts, "include_str!") else {
|
|
return DummyResult::any(sp);
|
|
};
|
|
let file = match resolve_path(&cx.sess.parse_sess, file.as_str(), sp) {
|
|
Ok(f) => f,
|
|
Err(err) => {
|
|
err.emit();
|
|
return DummyResult::any(sp);
|
|
}
|
|
};
|
|
match cx.source_map().load_binary_file(&file) {
|
|
Ok(bytes) => match std::str::from_utf8(&bytes) {
|
|
Ok(src) => {
|
|
let interned_src = Symbol::intern(src);
|
|
base::MacEager::expr(cx.expr_str(sp, interned_src))
|
|
}
|
|
Err(_) => {
|
|
cx.dcx().span_err(sp, format!("{} wasn't a utf-8 file", file.display()));
|
|
DummyResult::any(sp)
|
|
}
|
|
},
|
|
Err(e) => {
|
|
cx.dcx().span_err(sp, format!("couldn't read {}: {}", file.display(), e));
|
|
DummyResult::any(sp)
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn expand_include_bytes(
|
|
cx: &mut ExtCtxt<'_>,
|
|
sp: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn base::MacResult + 'static> {
|
|
let sp = cx.with_def_site_ctxt(sp);
|
|
let Some(file) = get_single_str_from_tts(cx, sp, tts, "include_bytes!") else {
|
|
return DummyResult::any(sp);
|
|
};
|
|
let file = match resolve_path(&cx.sess.parse_sess, file.as_str(), sp) {
|
|
Ok(f) => f,
|
|
Err(err) => {
|
|
err.emit();
|
|
return DummyResult::any(sp);
|
|
}
|
|
};
|
|
match cx.source_map().load_binary_file(&file) {
|
|
Ok(bytes) => {
|
|
let expr = cx.expr(sp, ast::ExprKind::IncludedBytes(bytes));
|
|
base::MacEager::expr(expr)
|
|
}
|
|
Err(e) => {
|
|
cx.dcx().span_err(sp, format!("couldn't read {}: {}", file.display(), e));
|
|
DummyResult::any(sp)
|
|
}
|
|
}
|
|
}
|