Matthias Krüger f5387a1c38

Rollup merge of #119841 - nnethercote:rm-DiagnosticBuilder-buffer, r=oli-obk ...

Remove `DiagnosticBuilder::buffer`

`DiagnosticBuilder::buffer` doesn't do much, and part of what it does (for `-Ztreat-err-as-bug`) it shouldn't.

This PR strips it back, replaces its uses, and finally removes it, making a few cleanups in the vicinity along the way.

r? ``@oli-obk``

2024-01-11 19:42:51 +01:00

..

auxiliary

…

check-cfg

…

coverage

…

doctest

…

error-in-impl-trait

…

generate-link-to-definition

…

intra-doc

…

issues

…

lints

…

scrape-examples

…

suggestions

…

ambiguous-inherent-assoc-ty.rs

…

apit-46976.rs

…

bounded-hr-lifetime.rs

…

bounded-hr-lifetime.stderr

…

check-doc-alias-attr-location.rs

…

check-doc-alias-attr-location.stderr

…

check-doc-alias-attr.rs

…

check-doc-alias-attr.stderr

…

circular-intra-doc-link-48414.rs

…

commandline-argfile-badutf8.args

…

commandline-argfile-badutf8.rs

…

commandline-argfile-badutf8.stderr

…

commandline-argfile-missing.rs

…

commandline-argfile-missing.stderr

…

commandline-argfile.args

…

commandline-argfile.rs

…

const_arg_in_type_position.rs

…

const_arg_in_type_position.stderr

…

const-evalutation-ice.rs

…

const-evalutation-ice.stderr

…

crate-reference-in-block-module.rs

…

crate-reference-in-block-module.stderr

…

custom_code_classes_in_docs-warning3.rs

…

custom_code_classes_in_docs-warning3.stderr

…

custom_code_classes_in_docs-warning.rs

…

custom_code_classes_in_docs-warning.stderr

…

deprecated-attrs.rs

…

deprecated-attrs.stderr

…

deref-generic.rs

…

diagnostic-width.rs

…

diagnostic-width.stderr

…

doc-alias-assoc-const.rs

…

doc-alias-assoc-const.stderr

…

doc-alias-crate-level.rs

…

doc-alias-crate-level.stderr

…

doc-alias-same-name.rs

…

doc-alias-same-name.stderr

…

doc-cfg.rs

…

doc-cfg.stderr

…

doc-include-suggestion.rs

…

doc-include-suggestion.stderr

…

feature-gate-custom_code_classes_in_docs.rs

…

feature-gate-custom_code_classes_in_docs.stderr

…

feature-gate-doc_cfg_hide.rs

…

feature-gate-doc_cfg_hide.stderr

…

hidden-trait-method-34423.rs

…

ice-assoc-const-for-primitive-31808.rs

…

ice-bug-report-url.rs

…

ice-bug-report-url.stderr

…

ignore-block-help.rs

…

ignore-block-help.stderr

…

impl-fn-nesting.rs

…

impl-fn-nesting.stderr

…

infinite-recursive-type.rs

…

infinite-recursive-type.stderr

…

inherent-assoc-consts-36031.rs

…

invalid_associated_const.rs

…

invalid_associated_const.stderr

…

invalid_const_in_lifetime_position.rs

…

invalid_const_in_lifetime_position.stderr

…

invalid_infered_static_and_const.rs

…

invalid_infered_static_and_const.stderr

…

invalid-cfg.rs

…

invalid-cfg.stderr

…

invalid-keyword.rs

…

invalid-keyword.stderr

…

invalid-syntax.rs

…

invalid-syntax.stderr

…

invalid-theme-name.rs

…

invalid-theme-name.stderr

…

issue-102467.rs

…

issue-102467.stderr

…

issue-110629-private-type-cycle-dyn.rs

…

issue-110629-private-type-cycle-dyn.stderr

…

issue-110629-private-type-cycle.rs

…

macro-docs.rs

…

macro-docs.stderr

…

macro-docs.stdout

…

mismatched_arg_count.rs

…

mismatched_arg_count.stderr

…

nested-extern-crate-46271.rs

…

nested-macro-rules-47639.rs

…

normalize-cycle.rs

…

normalize-overflow.rs

…

not-wf-ambiguous-normalization.rs

…

not-wf-ambiguous-normalization.stderr

…

output-format-html-stable.rs

…

proc_macro_bug.rs

…

proc_macro_bug.stderr

…

range-pattern.rs

…

recursive-deref-ice.rs

…

rustc-check-passes.rs

…

rustc-check-passes.stderr

…

search-index-generics-recursion-bug-issue-59502.rs

…

super-glob-40936.rs

…

track-diagnostics.rs

…

track-diagnostics.stderr

…

tuple-variadic-check.rs

…

tuple-variadic-check.stderr

…

unable-fulfill-trait.rs

…

unable-fulfill-trait.stderr

…

unescaped_backticks.rs

…

unescaped_backticks.stderr

…

unused-extern-crate.rs

…

use_both_out_dir_and_output_options.rs

…

use_both_out_dir_and_output_options.stderr

…

wasm-safe.rs

…