Esteban Küber 37d2ea2fa0 Properly handle async blocks and fns in if exprs without else ...

When encountering a tail expression in the then arm of an `if` expression
without an `else` arm, account for `async fn` and `async` blocks to
suggest `return`ing the value and pointing at the return type of the
`async fn`.

We now also account for AFIT when looking for the return type to point at.

Fix #115405.

2024-02-12 20:26:34 +00:00

..

alias-liveness

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

auxiliary

…

diagnostics

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

explicit-generic-args-with-impl-trait

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

in-ctfe

Always use RevealAll for const eval queries

2024-01-19 11:32:34 +00:00

in-trait

Properly handle async blocks and fns in if exprs without else

2024-02-12 20:26:34 +00:00

issues

Rollup merge of #119818 - oli-obk:even_more_follow_up_errors3, r=compiler-errors

2024-01-15 08:44:46 +01:00

multiple-lifetimes

Manual find replace updates

2023-11-24 21:04:51 +01:00

rpit

Add some tests

2024-01-22 14:35:47 +00:00

transmute

Always use RevealAll for const eval queries

2024-01-19 11:32:34 +00:00

arg-position-impl-trait-too-long.rs

…

arg-position-impl-trait-too-long.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

associated-impl-trait-type-generic-trait.rs

…

associated-impl-trait-type-issue-114325.rs

add non-regression test for issue 114325

2023-12-29 10:01:53 +00:00

associated-impl-trait-type-trivial.rs

…

associated-impl-trait-type.rs

…

async_scope_creep.rs

Remove DefiningAnchor::Bubble from opaque wf check

2023-10-16 15:50:31 +00:00

auto-trait-coherence.next.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

auto-trait-coherence.old.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

auto-trait-coherence.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

auto-trait-leak2.rs

…

auto-trait-leak2.stderr

Provide more context on derived obligation error primary label

2024-01-30 21:28:18 +00:00

auto-trait-leak-rpass.rs

…

auto-trait-leak.rs

Stash and cancel cycle errors for auto trait leakage in opaques

2023-10-26 17:58:02 +00:00

auto-trait-leak.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

autoderef.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

bivariant-lifetime-liveness.rs

Flesh out tests more

2023-10-17 01:26:46 +00:00

bound-normalization-fail.rs

Stabilize impl_trait_projections

2023-09-08 03:45:36 +00:00

bound-normalization-fail.stderr

Stabilize impl_trait_projections

2023-09-08 03:45:36 +00:00

bound-normalization-pass.rs

…

bounds_regression.rs

Adjust compiler tests for unused_tuple_struct_fields -> dead_code

2024-01-02 15:34:37 -05:00

can-return-unconstrained-closure.rs

…

capture-lifetime-not-in-hir.rs

Stabilize impl_trait_projections

2023-09-08 03:45:36 +00:00

capture-lifetime-not-in-hir.stderr

Stabilize impl_trait_projections

2023-09-08 03:45:36 +00:00

closure-calling-parent-fn.rs

…

closure-in-impl-trait-arg.rs

…

closure-in-impl-trait.rs

…

coherence-treats-tait-ambig.current.stderr

Manual find replace updates

2023-11-24 21:04:51 +01:00

coherence-treats-tait-ambig.rs

update tests

2023-09-21 08:17:58 +02:00

coherence-treats-tait-ambig.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

cross-return-site-inference.rs

Reorder fullfillment errors to keep more interesting ones first

2023-10-04 02:04:14 +00:00

cross-return-site-inference.stderr

Deduplicate more sized errors on call exprs

2024-01-24 02:53:15 +00:00

deduce-signature-from-supertrait.rs

…

defined-by-trait-resolution.rs

…

deprecated_annotation.rs

…

divergence.rs

…

does-not-live-long-enough.rs

…

does-not-live-long-enough.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

dont-suggest-box-on-empty-else-arm.rs

…

dont-suggest-box-on-empty-else-arm.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

dyn-impl-type-mismatch.rs

Account for expected dyn Trait found impl Trait

2024-01-24 16:57:15 +00:00

dyn-impl-type-mismatch.stderr

Account for expected dyn Trait found impl Trait

2024-01-24 16:57:15 +00:00

dyn-trait-elided-two-inputs-assoc.rs

…

dyn-trait-elided-two-inputs-param.rs

…

dyn-trait-elided-two-inputs-ref-assoc.rs

…

dyn-trait-elided-two-inputs-ref-param.rs

…

dyn-trait-return-should-be-impl-trait.rs

…

dyn-trait-return-should-be-impl-trait.stderr

Provide more context on derived obligation error primary label

2024-01-30 21:28:18 +00:00

eagerly-reveal-in-local-body.rs

Remove special-casing around aliaskind in new solver

2024-01-11 16:54:11 +00:00

equal-hidden-lifetimes.rs

…

equality2.rs

…

equality2.stderr

…

equality-in-canonical-query.clone.stderr

Split Level::DelayedBug in two.

2024-02-05 10:03:01 +11:00

equality-in-canonical-query.rs

Don't consider delayed bugs for -Ztreat-err-as-bug.

2024-01-13 09:59:56 +11:00

equality-rpass.rs

…

equality-rpass.stderr

…

equality.rs

…

equality.stderr

…

erased-regions-in-hidden-ty.current.stderr

finish RegionKind rename

2023-11-14 13:13:27 +00:00

erased-regions-in-hidden-ty.next.stderr

finish RegionKind rename

2023-11-14 13:13:27 +00:00

erased-regions-in-hidden-ty.rs

rename to verbose-internals

2023-12-19 13:35:37 -05:00

example-calendar.rs

…

example-st.rs

Update tests

2024-02-07 10:42:01 +08:00

example-st.stderr

Update tests

2024-02-07 10:42:01 +08:00

extra-impl-in-trait-impl.fixed

…

extra-impl-in-trait-impl.rs

…

extra-impl-in-trait-impl.stderr

…

extra-item.rs

…

extra-item.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

fallback_inference.rs

…

fallback_inference.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

fallback.rs

…

feature-self-return-type.rs

Stabilize impl_trait_projections

2023-09-08 03:45:36 +00:00

feature-self-return-type.stderr

Stabilize impl_trait_projections

2023-09-08 03:45:36 +00:00

fresh-lifetime-from-bare-trait-obj-114664.rs

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

fresh-lifetime-from-bare-trait-obj-114664.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

generic-with-implicit-hrtb-without-dyn.edition2015.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

generic-with-implicit-hrtb-without-dyn.edition2021.stderr

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

generic-with-implicit-hrtb-without-dyn.rs

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

hidden-lifetimes.rs

…

hidden-lifetimes.stderr

…

hidden-type-is-opaque-2.rs

…

hidden-type-is-opaque-2.stderr

…

hidden-type-is-opaque.rs

…

impl_fn_associativity.rs

…

impl_trait_projections.rs

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

impl_trait_projections.stderr

Provide more context on derived obligation error primary label

2024-01-30 21:28:18 +00:00

impl-fn-hrtb-bounds-2.rs

…

impl-fn-hrtb-bounds-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

impl-fn-hrtb-bounds.rs

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

impl-fn-hrtb-bounds.stderr

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

impl-fn-parsing-ambiguities.rs

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

impl-fn-parsing-ambiguities.stderr

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

impl-fn-predefined-lifetimes.rs

…

impl-fn-predefined-lifetimes.stderr

…

impl-generic-mismatch-ab.rs

…

impl-generic-mismatch-ab.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

impl-generic-mismatch.rs

…

impl-generic-mismatch.stderr

…

impl-subtyper2.rs

move subtyper change reveal_all

2023-10-05 18:56:30 +03:00

impl-subtyper.rs

move subtyper change reveal_all

2023-10-05 18:56:30 +03:00

impl-trait-in-macro.rs

…

impl-trait-in-macro.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

impl-trait-plus-priority.rs

…

impl-trait-plus-priority.stderr

…

implicit-capture-late.rs

Add test for implicitly capturing late-bound var with new capture rules

2023-12-05 19:53:59 +00:00

implicit-capture-late.stderr

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

in-assoc-type-unconstrained.rs

…

in-assoc-type-unconstrained.stderr

…

in-assoc-type.rs

…

in-assoc-type.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-35668.rs

…

issue-35668.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-36792.rs

…

issue-46959.rs

…

issue-49556.rs

…

issue-49579.rs

…

issue-49685.rs

…

issue-51185.rs

…

issue-54966.rs

…

issue-54966.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-55872-1.rs

…

issue-55872-1.stderr

Provide more context on derived obligation error primary label

2024-01-30 21:28:18 +00:00

issue-55872-2.rs

Bless tests.

2023-09-23 13:47:30 +00:00

issue-55872-2.stderr

Add a note to duplicate diagnostics

2023-10-05 01:04:41 +00:00

issue-55872-3.rs

…

issue-55872-3.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-55872.rs

…

issue-55872.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-56445.rs

…

issue-68532.rs

…

issue-72911.rs

Keep error types around, even in obligations.

2024-01-11 09:52:25 +00:00

issue-72911.stderr

Keep error types around, even in obligations.

2024-01-11 09:52:25 +00:00

issue-86465.rs

Revert "Auto merge of #102417 - oli-obk:opaque_lifetimes2, r=jackh726"

2023-08-30 11:06:46 +00:00

issue-86465.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-87450.rs

…

issue-87450.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-99073-2.rs

…

issue-99073-2.stderr

…

issue-99073.rs

…

issue-99073.stderr

adjust how closure/generator types and rvalues are printed

2023-09-21 22:20:58 +02:00

issue-99642-2.rs

…

issue-99642.rs

…

issue-99914.rs

…

issue-99914.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-100075-2.rs

…

issue-100075-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-100075.rs

…

issue-100075.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-100187.rs

…

issue-102605.rs

…

issue-102605.stderr

…

issue-103181-1.current.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-103181-1.next.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-103181-1.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

issue-103181-2.rs

…

issue-103181-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-103599.rs

…

issue-103599.stderr

…

issue-108591.rs

Revert "Auto merge of #102417 - oli-obk:opaque_lifetimes2, r=jackh726"

2023-08-30 11:06:46 +00:00

issue-108592.rs

Revert "Auto merge of #102417 - oli-obk:opaque_lifetimes2, r=jackh726"

2023-08-30 11:06:46 +00:00

lifetime-ambiguity-regression.rs

Paper over an accidental regression

2023-09-14 15:16:48 +00:00

lifetimes2.rs

…

lifetimes.rs

s/generator/coroutine/

2023-10-20 21:14:01 +00:00

mapping-duplicated-lifetimes-issue-114597.rs

…

method-suggestion-no-duplication.rs

…

method-suggestion-no-duplication.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

multiple-defining-usages-in-body.rs

…

multiple-defining-usages-in-body.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

must_outlive_least_region_or_bound.rs

Continue to borrowck even if there were previous errors

2024-02-08 08:10:43 +00:00

must_outlive_least_region_or_bound.stderr

Continue to borrowck even if there were previous errors

2024-02-08 08:10:43 +00:00

needs_least_region_or_bound.rs

…

negative-reasoning.rs

…

negative-reasoning.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

nested_impl_trait.rs

Split note, fix const/static impl trait error

2024-01-07 18:00:03 +00:00

nested_impl_trait.stderr

Provide more context on derived obligation error primary label

2024-01-30 21:28:18 +00:00

nested-return-type2-tait2.rs

Remove DefiningAnchor::Bubble from opaque wf check

2023-10-16 15:50:31 +00:00

nested-return-type2-tait2.stderr

Remove DefiningAnchor::Bubble from opaque wf check

2023-10-16 15:50:31 +00:00

nested-return-type2-tait3.rs

Remove DefiningAnchor::Bubble from opaque wf check

2023-10-16 15:50:31 +00:00

nested-return-type2-tait3.stderr

Remove DefiningAnchor::Bubble from opaque wf check

2023-10-16 15:50:31 +00:00

nested-return-type2-tait.rs

…

nested-return-type2-tait.stderr

…

nested-return-type2.rs

…

nested-return-type3-tait2.rs

…

nested-return-type3-tait2.stderr

…

nested-return-type3-tait3.rs

…

nested-return-type3-tait3.stderr

…

nested-return-type3-tait.rs

…

nested-return-type3-tait.stderr

…

nested-return-type3.rs

…

nested-return-type4.rs

…

nested-return-type4.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

nested-return-type.rs

…

nested-rpit-hrtb-2.rs

…

nested-rpit-hrtb-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

nested-rpit-hrtb.rs

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

nested-rpit-hrtb.stderr

Avoid silencing relevant follow-up errors

2024-01-09 21:08:16 +00:00

nested-rpit-with-anonymous-lifetimes.rs

…

nesting.rs

…

no-method-suggested-traits.rs

…

no-method-suggested-traits.stderr

…

no-trait.rs

…

no-trait.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

normalize-opaque-with-bound-vars.rs

…

normalize-tait-in-const.rs

…

normalize-tait-in-const.stderr

Continue to borrowck even if there were previous errors

2024-02-08 08:10:43 +00:00

not_general_enough_regression_106630.rs

Add regression test for #106630

2023-12-28 14:53:23 +01:00

object-unsafe-trait-in-return-position-dyn-trait.rs

…

object-unsafe-trait-in-return-position-dyn-trait.stderr

On object safety error, mention new enum as alternative

2023-10-29 23:55:46 +00:00

object-unsafe-trait-in-return-position-impl-trait.rs

…

object-unsafe-trait-in-return-position-impl-trait.stderr

…

opaque-cast-field-access-in-future.rs

Only prevent field projections into opaque types, not types containing opaque types

2023-09-25 17:41:08 +00:00

opaque-cast-field-access-in-future.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

opaque-used-in-extraneous-argument.rs

Use FnOnceOutput instead of FnOnce where expected

2024-01-17 14:23:41 +00:00

opaque-used-in-extraneous-argument.stderr

Use FnOnceOutput instead of FnOnce where expected

2024-01-17 14:23:41 +00:00

point-to-type-err-cause-on-impl-trait-return.rs

…

point-to-type-err-cause-on-impl-trait-return.stderr

…

printing-binder.rs

…

printing-binder.stderr

…

private_unused.rs

…

projection-mismatch-in-impl-where-clause.rs

…

projection-mismatch-in-impl-where-clause.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

projection.rs

…

question_mark.rs

…

recursive-auto-trait.rs

…

recursive-coroutine-boxed.rs

Make cycle error more resilient to where it starts

2024-01-08 20:30:24 +00:00

recursive-coroutine-indirect.current.stderr

Remove special-casing around aliaskind in new solver

2024-01-11 16:54:11 +00:00

recursive-coroutine-indirect.next.stderr

Remove special-casing around aliaskind in new solver

2024-01-11 16:54:11 +00:00

recursive-coroutine-indirect.rs

Remove special-casing around aliaskind in new solver

2024-01-11 16:54:11 +00:00

recursive-impl-trait-type-direct.rs

…

recursive-impl-trait-type-indirect.rs

Make cycle error more resilient to where it starts

2024-01-08 20:30:24 +00:00

recursive-impl-trait-type-indirect.stderr

Make cycle error more resilient to where it starts

2024-01-08 20:30:24 +00:00

recursive-impl-trait-type-through-non-recursive.rs

…

recursive-impl-trait-type-through-non-recursive.stderr

…

recursive-type-alias-impl-trait-declaration-too-subtle-2.rs

…

recursive-type-alias-impl-trait-declaration-too-subtle.rs

…

recursive-type-alias-impl-trait-declaration-too-subtle.stderr

recurse into refs when comparing tys for diagnostics

2023-12-07 23:00:46 -05:00

recursive-type-alias-impl-trait-declaration.rs

…

recursive-type-alias-impl-trait-declaration.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

region-escape-via-bound-contravariant-closure.rs

…

region-escape-via-bound-contravariant.rs

…

region-escape-via-bound.rs

…

region-escape-via-bound.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

return-position-impl-trait-minimal.rs

…

reveal-during-codegen.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

rpit-assoc-pair-with-lifetime.rs

…

rpit-not-sized.rs

…

rpit-not-sized.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

static-lifetime-return-position-impl-trait.rs

Stabilize AFIT and RPITIT

2023-10-13 21:01:36 +00:00

static-return-lifetime-infered.rs

…

static-return-lifetime-infered.stderr

adjust how closure/generator types and rvalues are printed

2023-09-21 22:20:58 +02:00

suggest-calling-rpit-closure.rs

…

suggest-calling-rpit-closure.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

trait_resolution.rs

…

trait_type.rs

…

trait_type.stderr

…

two_tait_defining_each_other2.current.stderr

update tests

2023-11-09 11:32:51 +01:00

two_tait_defining_each_other2.next.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

two_tait_defining_each_other2.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

two_tait_defining_each_other3.current.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

two_tait_defining_each_other3.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

two_tait_defining_each_other.current.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

two_tait_defining_each_other.rs

update use of feature flags

2023-12-14 15:22:37 +01:00

type_parameters_captured.rs

…

type_parameters_captured.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

type-alias-generic-param.rs

Update tests

2024-02-07 10:42:01 +08:00

type-alias-generic-param.stderr

Update tests

2024-02-07 10:42:01 +08:00

type-alias-impl-trait-in-fn-body.rs

…

type-arg-mismatch-due-to-impl-trait.rs

…

type-arg-mismatch-due-to-impl-trait.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

unactionable_diagnostic.fixed

remove trailing dots

2023-10-08 10:06:17 +00:00

unactionable_diagnostic.rs

remove trailing dots

2023-10-08 10:06:17 +00:00

unactionable_diagnostic.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

universal_hrtb_anon.rs

…

universal_hrtb_named.rs

…

universal_in_adt_in_parameters.rs

…

universal_in_impl_trait_in_parameters.rs

…

universal_in_trait_defn_parameters.rs

…

universal_multiple_bounds.rs

…

universal_wrong_bounds.rs

…

universal_wrong_bounds.stderr

…

universal_wrong_hrtb.rs

…

universal_wrong_hrtb.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

universal-mismatched-type.rs

…

universal-mismatched-type.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

universal-two-impl-traits.rs

…

universal-two-impl-traits.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

unsafety-checking-cycle.rs

…

variance.e2024.stderr

Enable new capture rules by default on edition 2024

2023-12-05 19:53:59 +00:00

variance.new.stderr

Enable new capture rules by default on edition 2024

2023-12-05 19:53:59 +00:00

variance.old.stderr

Enable new capture rules by default on edition 2024

2023-12-05 19:53:59 +00:00

variance.rs

Enable new capture rules by default on edition 2024

2023-12-05 19:53:59 +00:00

wf-eval-order.rs

…

where-allowed-2.rs

…

where-allowed-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

where-allowed.rs

Split note, fix const/static impl trait error

2024-01-07 18:00:03 +00:00

where-allowed.stderr

Bless tests

2024-01-13 12:46:58 -05:00

xcrate_simple.rs

…

xcrate.rs

…