bors 591ecb88df Auto merge of #128742 - RalfJung:miri-vtable-uniqueness, r=saethlin ...

miri: make vtable addresses not globally unique

Miri currently gives vtables a unique global address. That's not actually matching reality though. So this PR enables Miri to generate different addresses for the same type-trait pair.

To avoid generating an unbounded number of `AllocId` (and consuming unbounded amounts of memory), we use the "salt" technique that we also already use for giving constants non-unique addresses: the cache is keyed on a "salt" value n top of the actually relevant key, and Miri picks a random salt (currently in the range `0..16`) each time it needs to choose an `AllocId` for one of these globals -- that means we'll get up to 16 different addresses for each vtable. The salt scheme is integrated into the global allocation deduplication logic in `tcx`, and also used for functions and string literals. (So this also fixes the problem that casting the same function to a fn ptr over and over will consume unbounded memory.)

r? `@saethlin`
Fixes https://github.com/rust-lang/miri/issues/3737

2024-08-13 04:32:34 +00:00

..

auxiliary

…

heap

Always use a colon in //@ normalize-*: headers

2024-07-11 12:23:44 +10:00

simd

fix use of platform_intrinsics in tests

2024-02-25 08:15:44 +01:00

stable-metric

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

assign-to-static-within-other-static.rs

…

assign-to-static-within-other-static.stderr

…

conditional_array_execution.rs

…

conditional_array_execution.stderr

…

const_fn_ptr_fail2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_fn_ptr_fail2.stderr

…

const_fn_ptr_fail.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_fn_ptr_fail.stderr

…

const_fn_ptr.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_fn_ptr.stderr

Always evaluate free constants and statics, even if previous errors occurred

2024-02-19 22:11:13 +00:00

const_fn_target_feature_wasm.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_fn_target_feature.rs

Add inline comments why we're forcing the target cpu

2024-05-01 16:54:20 -07:00

const_fn_target_feature.stderr

Add inline comments why we're forcing the target cpu

2024-05-01 16:54:20 -07:00

const_let.rs

…

const_let.stderr

…

const_panic_2021.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_panic_2021.stderr

…

const_panic_libcore_bin.rs

…

const_panic_libcore_bin.stderr

…

const_panic_stability.e2018.stderr

…

const_panic_stability.e2021.stderr

…

const_panic_stability.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_panic_track_caller.rs

…

const_panic_track_caller.stderr

…

const_panic-normalize-tabs-115498.rs

…

const_panic-normalize-tabs-115498.stderr

…

const_panic.rs

…

const_panic.stderr

…

const_prop_errors.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const_raw_ptr_ops2.rs

…

const_raw_ptr_ops2.stderr

improve dangling/oob errors and make them more uniform

2024-07-27 21:12:54 +02:00

const_raw_ptr_ops.rs

…

const_raw_ptr_ops.stderr

…

const_signed_pat.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const-eval-intrinsic-promotion.rs

…

const-eval-intrinsic-promotion.stderr

…

const-eval-overflow2.rs

…

const-eval-overflow2.stderr

…

const-eval-overflow2b.rs

…

const-eval-overflow2b.stderr

…

const-eval-overflow2c.rs

…

const-eval-overflow2c.stderr

…

const-eval-overflow-2.rs

…

const-eval-overflow-2.stderr

…

const-eval-overflow-3.rs

…

const-eval-overflow-3.stderr

…

const-eval-overflow-3b.rs

…

const-eval-overflow-3b.stderr

Spell out other trait diagnostic

2024-06-12 12:34:47 +00:00

const-eval-overflow-4.rs

…

const-eval-overflow-4.stderr

…

const-eval-overflow-4b.rs

…

const-eval-overflow-4b.stderr

Spell out other trait diagnostic

2024-06-12 12:34:47 +00:00

const-eval-query-stack.rs

Always use a colon in //@ normalize-*: headers

2024-07-11 12:23:44 +10:00

const-eval-query-stack.stderr

tests: bless ui and rustdoc-ui tests for ICE messages

2024-04-09 13:58:52 +00:00

const-eval-span.rs

…

const-eval-span.stderr

…

const-pointer-values-in-various-types.64bit.stderr

…

const-pointer-values-in-various-types.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

dont_promote_unstable_const_fn_cross_crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

dont_promote_unstable_const_fn_cross_crate.stderr

…

dont_promote_unstable_const_fn.rs

…

dont_promote_unstable_const_fn.stderr

…

double_check2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

double_check.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

duration_conversion.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

enum_discr.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

extern_fat_pointer.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

field-access-after-const-eval-fail-in-ty.rs

Check for presence of field in typeck results before visiting it

2024-02-03 19:41:18 +01:00

field-access-after-const-eval-fail-in-ty.stderr

Check for presence of field in typeck results before visiting it

2024-02-03 19:41:18 +01:00

format.rs

Move the checks for Arguments constructors to inline const

2024-05-24 21:09:15 -04:00

format.stderr

Move the checks for Arguments constructors to inline const

2024-05-24 21:09:15 -04:00

generic-slice.rs

…

generic-slice.stderr

Always evaluate free constants and statics, even if previous errors occurred

2024-02-19 22:11:13 +00:00

ice-generic-assoc-const.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

ice-packed.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

ice-unhandled-type-122191.rs

Add missing tests for an ICE

2024-04-27 11:02:15 +05:30

ice-unhandled-type-122191.stderr

Add missing tests for an ICE

2024-04-27 11:02:15 +05:30

ice-unsized-struct-const-eval-123154.rs

Fail candidate assembly for erroneous types

2024-04-16 12:42:48 +05:30

ice-unsized-struct-const-eval-123154.stderr

Fail candidate assembly for erroneous types

2024-04-16 12:42:48 +05:30

index_out_of_bounds_propagated.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

index_out_of_bounds_propagated.stderr

…

index_out_of_bounds.rs

…

index_out_of_bounds.stderr

…

index-out-of-bounds-never-type.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

index-out-of-bounds-never-type.stderr

preserve span when evaluating mir::ConstOperand

2024-03-14 21:55:07 +01:00

infinite_loop.eval_limit.stderr

Fix crash in late internal checking

2024-03-08 19:00:53 +08:00

infinite_loop.no_ice.stderr

Fix crash in late internal checking

2024-03-08 19:00:53 +08:00

infinite_loop.rs

Fix crash in late internal checking

2024-03-08 19:00:53 +08:00

issue-43197.rs

…

issue-43197.stderr

…

issue-44578.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-44578.stderr

Enable ConstPropLint for promoteds

2024-02-17 10:44:46 +05:30

issue-47971.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-49296.rs

…

issue-49296.stderr

…

issue-50706.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-50814-2.mir-opt.stderr

preserve span when evaluating mir::ConstOperand

2024-03-14 21:55:07 +01:00

issue-50814-2.normal.stderr

preserve span when evaluating mir::ConstOperand

2024-03-14 21:55:07 +01:00

issue-50814-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-50814.rs

Enable ConstPropLint for promoteds

2024-02-17 10:44:46 +05:30

issue-50814.stderr

preserve span when evaluating mir::ConstOperand

2024-03-14 21:55:07 +01:00

issue-51300.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-52475.rs

…

issue-52475.stderr

…

issue-53157.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-53401.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-55541.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-64908.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-64970.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-65394.rs

…

issue-65394.stderr

Bless tests

2024-01-13 12:46:58 -05:00

issue-70723.rs

…

issue-70723.stderr

…

issue-70804-fn-subtyping.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-84957-const-str-as-bytes.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-85155.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-85155.stderr

preserve span when evaluating mir::ConstOperand

2024-03-14 21:55:07 +01:00

issue-85907.rs

…

issue-85907.stderr

…

issue-91827-extern-types-field-offset.rs

…

issue-91827-extern-types-field-offset.stderr

don't ICE when encountering an extern type field during validation

2024-06-22 17:39:01 +02:00

issue-100878.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-104390.rs

…

issue-104390.stderr

Make parse error suggestions verbose and fix spans

2024-07-12 03:02:57 +00:00

issue-114994-fail.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-114994-fail.stderr

Bless tests

2024-01-13 12:46:58 -05:00

issue-114994.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

livedrop.rs

…

livedrop.stderr

…

match-test-ptr-null.rs

…

match-test-ptr-null.stderr

…

mod-static-with-const-fn.rs

…

mod-static-with-const-fn.stderr

…

no_lint_for_statically_known_error.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

nonnull_as_ref_ub.rs

…

nonnull_as_ref_ub.stderr

improve dangling/oob errors and make them more uniform

2024-07-27 21:12:54 +02:00

nonnull_as_ref.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

nrvo.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

panic-assoc-never-type.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

panic-assoc-never-type.stderr

…

panic-never-type.rs

…

panic-never-type.stderr

…

parse_ints.rs

stabilize const_int_from_str

2024-07-04 21:27:51 +02:00

parse_ints.stderr

stabilize const_int_from_str

2024-07-04 21:27:51 +02:00

partial_ptr_overwrite.rs

…

partial_ptr_overwrite.stderr

…

promote_mutable_zst_mir_borrowck.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

promote-static.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

promoted_const_fn_fail_deny_const_err.rs

…

promoted_const_fn_fail_deny_const_err.stderr

…

promoted_const_fn_fail.rs

…

promoted_const_fn_fail.stderr

…

promoted_raw_ptr_ops.rs

…

promoted_raw_ptr_ops.stderr

…

raw-bytes.32bit.stderr

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

raw-bytes.64bit.stderr

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

raw-bytes.rs

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

raw-pointer-ub.rs

improve dangling/oob errors and make them more uniform

2024-07-27 21:12:54 +02:00

raw-pointer-ub.stderr

on a signed deref check, mention the right pointer in the error

2024-08-01 14:25:19 +02:00

ref_to_int_match.32bit.stderr

…

ref_to_int_match.64bit.stderr

…

ref_to_int_match.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

shift_overflow.rs

…

shift_overflow.stderr

…

simple_with_undef.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

size-of-t.rs

…

size-of-t.stderr

…

strlen.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

transmute-const-promotion.rs

…

transmute-const-promotion.stderr

…

transmute-const.32bit.stderr

…

transmute-const.64bit.stderr

…

transmute-const.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

transmute-size-mismatch.rs

…

transmute-size-mismatch.stderr

…

ub-enum-overwrite.rs

…

ub-enum-overwrite.stderr

…

ub-enum.rs

Always use a colon in //@ normalize-*: headers

2024-07-11 12:23:44 +10:00

ub-enum.stderr

…

ub-incorrect-vtable.32bit.stderr

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

ub-incorrect-vtable.64bit.stderr

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

ub-incorrect-vtable.rs

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

ub-int-array.rs

…

ub-int-array.stderr

…

ub-invalid-values.rs

add const eval bool-to-int cast test

2024-06-11 13:28:36 +02:00

ub-invalid-values.stderr

add const eval bool-to-int cast test

2024-06-11 13:28:36 +02:00

ub-nonnull.chalk.64bit.stderr

…

ub-nonnull.rs

Always use a colon in //@ normalize-*: headers

2024-07-11 12:23:44 +10:00

ub-nonnull.stderr

on a signed deref check, mention the right pointer in the error

2024-08-01 14:25:19 +02:00

ub-ref-ptr.rs

Always use a colon in //@ normalize-*: headers

2024-07-11 12:23:44 +10:00

ub-ref-ptr.stderr

…

ub-slice-get-unchecked.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

ub-slice-get-unchecked.stderr

…

ub-uninhabit.rs

Always use a colon in //@ normalize-*: headers

2024-07-11 12:23:44 +10:00

ub-uninhabit.stderr

…

ub-upvars.32bit.stderr

…

ub-upvars.64bit.stderr

…

ub-upvars.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

ub-wide-ptr.chalk.64bit.stderr

…

ub-wide-ptr.rs

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

ub-wide-ptr.stderr

interpret: make identity upcasts a NOP again to avoid them generating a new random vtable

2024-08-09 18:48:45 +02:00

ub-write-through-immutable.rs

…

ub-write-through-immutable.stderr

…

union_promotion.rs

…

union_promotion.stderr

…

union-const-eval-field.rs

…

union-const-eval-field.stderr

…

union-ice.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

union-ice.stderr

…

union-ub.32bit.stderr

…

union-ub.64bit.stderr

…

union-ub.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unused-broken-const.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unused-broken-const.stderr

…

unwind-abort.rs

Remove c_unwind from tests and fix tests

2024-06-19 13:54:55 +01:00

unwind-abort.stderr

…

valid-const.rs

Stabilize generic NonZero.

2024-04-22 18:48:47 +02:00

validate_uninhabited_zsts.rs

Always evaluate free constants and statics, even if previous errors occurred

2024-02-19 22:11:13 +00:00

validate_uninhabited_zsts.stderr

Always evaluate free constants and statics, even if previous errors occurred

2024-02-19 22:11:13 +00:00

validation-ice-extern-type-field.rs

don't ICE when encountering an extern type field during validation

2024-06-22 17:39:01 +02:00

validation-ice-extern-type-field.stderr

don't ICE when encountering an extern type field during validation

2024-06-22 17:39:01 +02:00

write-to-uninhabited-enum-variant.rs

Update tests

2024-08-10 12:07:17 +02:00

zst_operand_eval.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00