mirror of
https://github.com/rust-lang/rust.git
synced 2025-12-30 12:16:45 +00:00
The `explicit_into_iter_loop`, `explicit_iter_loop` and `iter_next_loop` will now: - trigger only when the triggering expression is not located into macro code; - properly expose code rewrite proposal with code coming from the root context.
89 lines
1.8 KiB
Rust
89 lines
1.8 KiB
Rust
#![allow(non_local_definitions)]
|
|
#![warn(clippy::explicit_into_iter_loop)]
|
|
|
|
fn main() {
|
|
// Issue #4958
|
|
fn _takes_iterator<T>(iterator: &T)
|
|
where
|
|
for<'a> &'a T: IntoIterator<Item = &'a String>,
|
|
{
|
|
for _ in iterator {}
|
|
//~^ explicit_into_iter_loop
|
|
}
|
|
|
|
struct T;
|
|
impl IntoIterator for &T {
|
|
type Item = ();
|
|
type IntoIter = std::vec::IntoIter<Self::Item>;
|
|
fn into_iter(self) -> Self::IntoIter {
|
|
unimplemented!()
|
|
}
|
|
}
|
|
|
|
let mut t = T;
|
|
for _ in &t {}
|
|
//~^ explicit_into_iter_loop
|
|
|
|
let r = &t;
|
|
for _ in r {}
|
|
//~^ explicit_into_iter_loop
|
|
|
|
// No suggestion for this.
|
|
// We'd have to suggest `for _ in *rr {}` which is less clear.
|
|
let rr = &&t;
|
|
for _ in rr.into_iter() {}
|
|
|
|
let mr = &mut t;
|
|
for _ in &*mr {}
|
|
//~^ explicit_into_iter_loop
|
|
|
|
struct U;
|
|
impl IntoIterator for &mut U {
|
|
type Item = ();
|
|
type IntoIter = std::vec::IntoIter<Self::Item>;
|
|
fn into_iter(self) -> Self::IntoIter {
|
|
unimplemented!()
|
|
}
|
|
}
|
|
|
|
let mut u = U;
|
|
for _ in &mut u {}
|
|
//~^ explicit_into_iter_loop
|
|
|
|
let mr = &mut u;
|
|
for _ in &mut *mr {}
|
|
//~^ explicit_into_iter_loop
|
|
|
|
// Issue #6900
|
|
struct S;
|
|
impl S {
|
|
#[allow(clippy::should_implement_trait)]
|
|
pub fn into_iter<T>(self) -> I<T> {
|
|
unimplemented!()
|
|
}
|
|
}
|
|
|
|
struct I<T>(T);
|
|
impl<T> Iterator for I<T> {
|
|
type Item = T;
|
|
fn next(&mut self) -> Option<Self::Item> {
|
|
unimplemented!()
|
|
}
|
|
}
|
|
|
|
for _ in S.into_iter::<u32>() {}
|
|
}
|
|
|
|
fn issue14630() {
|
|
macro_rules! mac {
|
|
(into_iter $e:expr) => {
|
|
$e.into_iter()
|
|
};
|
|
}
|
|
|
|
for _ in dbg!([1, 2]) {}
|
|
//~^ explicit_into_iter_loop
|
|
|
|
for _ in mac!(into_iter [1, 2]) {}
|
|
}
|