bors 3fee0f12e4 Auto merge of #131326 - dingxiangfei2009:issue-130836-attempt-2, r=nikomatsakis ...

Reduce false positives of tail-expr-drop-order from consumed values (attempt #2)

r? `@nikomatsakis`

Tracked by #123739.

Related to #129864 but not replacing, yet.

Related to #130836.

This is an implementation of the approach suggested in the [Zulip stream](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/temporary.20drop.20order.20changes). A new MIR statement `BackwardsIncompatibleDrop` is added to the MIR syntax. The lint now works by inspecting possibly live move paths before at the `BackwardsIncompatibleDrop` location and the actual drop under the current edition, which should be one before Edition 2024 in practice.

2024-11-20 18:51:54 +00:00

..

coroutine

compiler: Directly use rustc_abi in mir_transform

2024-11-03 13:38:47 -08:00

coverage

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

inline

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

shim

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

abort_unwinding_calls.rs

compiler: Directly use rustc_abi in mir_transform

2024-11-03 13:38:47 -08:00

add_call_guards.rs

Inline and remove some functions.

2024-09-10 08:54:17 +10:00

add_moves_for_packed_drops.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

add_retag.rs

Reformat using the new identifier sorting from rustfmt

2024-09-22 19:11:29 -04:00

add_subtyping_projections.rs

Inline and remove some functions.

2024-09-10 08:54:17 +10:00

check_alignment.rs

move fn is_item_raw to TypingEnv

2024-11-19 18:06:20 +01:00

check_const_item_mutation.rs

Reformat using the new identifier sorting from rustfmt

2024-09-22 19:11:29 -04:00

check_packed_ref.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

check_undefined_transmutes.rs

Add a Lint for Pointer to Integer Transmutes in Consts

2024-10-05 12:48:02 +00:00

cleanup_post_borrowck.rs

be even more precise about "cast" vs "coercion"

2024-09-24 23:12:02 +02:00

copy_prop.rs

move fn is_item_raw to TypingEnv

2024-11-19 18:06:20 +01:00

coroutine.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

cost_checker.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

cross_crate_inline.rs

Always inline functions signatures containing f16 or f128

2024-11-14 16:18:41 -06:00

ctfe_limit.rs

Reduce visibilities, and add warn(unreachable_pub).

2024-09-09 08:48:09 +10:00

dataflow_const_prop.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

dead_store_elimination.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

deduce_param_attrs.rs

move fn is_item_raw to TypingEnv

2024-11-19 18:06:20 +01:00

deduplicate_blocks.rs

Rename and reorder lots of lifetimes.

2024-09-13 15:46:20 +10:00

deref_separator.rs

Use LocalDecls in a couple of places.

2024-09-09 15:15:44 +10:00

dest_prop.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

dump_mir.rs

Dogfood feature(file_buffered)

2024-09-24 14:25:16 -07:00

early_otherwise_branch.rs

Revert "Auto merge of #129047 - DianQK:early_otherwise_branch_scalar, r=cjgillot"

2024-09-24 08:44:26 +00:00

elaborate_box_derefs.rs

compiler: Directly use rustc_abi in mir_transform

2024-11-03 13:38:47 -08:00

elaborate_drops.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

errors.rs

Validate and test -Zmir-enable-passes

2024-11-12 13:28:05 +00:00

ffi_unwind_calls.rs

compiler: Directly use rustc_abi in mir_transform

2024-11-03 13:38:47 -08:00

function_item_references.rs

compiler: Directly use rustc_abi in mir_transform

2024-11-03 13:38:47 -08:00

gvn.rs

interpret: make typing_env field private

2024-11-20 11:05:53 +01:00

inline.rs

move fn is_item_raw to TypingEnv

2024-11-19 18:06:20 +01:00

instsimplify.rs

additional TypingEnv cleanups

2024-11-19 21:36:23 +01:00

jump_threading.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

known_panics_lint.rs

InterpCx store TypingEnv instead of a ParamEnv

2024-11-19 21:36:23 +01:00

large_enums.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

lib.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

lint_tail_expr_drop_order.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

lint.rs

Remove Analysis::into_engine.

2024-10-30 09:41:46 +11:00

lower_intrinsics.rs

Improve consistency in LowerIntrinsics.

2024-09-09 15:15:44 +10:00

lower_slice_len.rs

Inline and remove some functions.

2024-09-10 08:54:17 +10:00

match_branches.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

mentioned_items.rs

be even more precise about "cast" vs "coercion"

2024-09-24 23:12:02 +02:00

multiple_return_terminators.rs

Reduce visibilities, and add warn(unreachable_pub).

2024-09-09 08:48:09 +10:00

nrvo.rs

Reduce visibilities, and add warn(unreachable_pub).

2024-09-09 08:48:09 +10:00

pass_manager.rs

Rename PASS_NAMES to disambiguate

2024-11-12 13:28:05 +00:00

post_drop_elaboration.rs

Make check_live_drops into a MirLint.

2024-09-10 09:11:17 +10:00

prettify.rs

Improve comment formatting.

2024-09-10 08:42:30 +10:00

promote_consts.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

ref_prop.rs

move fn is_item_raw to TypingEnv

2024-11-19 18:06:20 +01:00

remove_noop_landing_pads.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

remove_place_mention.rs

Reduce visibilities, and add warn(unreachable_pub).

2024-09-09 08:48:09 +10:00

remove_storage_markers.rs

Reduce visibilities, and add warn(unreachable_pub).

2024-09-09 08:48:09 +10:00

remove_uninit_drops.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

remove_unneeded_drops.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

remove_zsts.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

required_consts.rs

Reformat using the new identifier sorting from rustfmt

2024-09-22 19:11:29 -04:00

reveal_all.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

sanity_check.rs

…

shim.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

simplify_branches.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

simplify_comparison_integral.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

simplify.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00

single_use_consts.rs

cleanup: don't clone types that are Copy

2024-09-29 13:31:30 +02:00

sroa.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

ssa.rs

move fn is_item_raw to TypingEnv

2024-11-19 18:06:20 +01:00

unreachable_enum_branching.rs

use TypingEnv when no infcx is available

2024-11-18 10:38:56 +01:00

unreachable_prop.rs

compiler: Directly use rustc_abi in mir_transform

2024-11-03 13:38:47 -08:00

validate.rs

reduce false positives of tail-expr-drop-order from consumed values

2024-11-20 20:53:11 +08:00