Shea Newton 7af0c67855 Extend indexing_slicing lint ...

Hey there clippy team! I've made some assumptions in this PR and I'm not at all certain they'll look like the right approach to you. I'm looking forward to any feedback or revision requests you have, thanks!

    Prior to this commit the `indexing_slicing` lint was limited to indexing/slicing operations on arrays. This meant that the scope of a really useful lint didn't include vectors. In order to include vectors in the `indexing_slicing` lint a few steps were taken.

    The `array_indexing.rs` source file in `clippy_lints` was renamed to `indexing_slicing.rs` to more accurately reflect the lint's new scope. The `OUT_OF_BOUNDS_INDEXING` lint persists through these changes so if we can know that a constant index or slice on an array is in bounds no lint is triggered.

    The `array_indexing` tests in the `tests/ui` directory were also extended and moved to `indexing_slicing.rs` and `indexing_slicing.stderr`.

    The `indexing_slicing` lint was moved to the `clippy_pedantic` lint group.

    A specific "Consider using" string was added to each of the `indexing_slicing` lint reports.

    At least one of the test scenarios might look peculiar and I'll leave it up to y'all to decide if it's palatable. It's the result of indexing the array `x` after `let x = [1, 2, 3, 4];`

    ```
    error: slicing may panic. Consider using `.get(..n)`or `.get_mut(..n)`instead
      --> $DIR/indexing_slicing.rs:23:6
       |
    23 |     &x[0..][..3];
       |      ^^^^^^^^^^^
    ```

    The error string reports only on the second half's range-to, because the range-from is in bounds!

    Again, thanks for taking a look.

    Closes #2536

2018-06-19 16:27:08 +00:00

..

author

author tests: update for_loop.stdout file

2018-05-28 14:50:41 +02:00

absurd-extreme-comparisons.rs

Fix #1159: avoid comparing fixed and target sized types in lint

2018-01-12 18:33:25 +01:00

absurd-extreme-comparisons.stderr

Update test suite

2018-03-28 23:49:32 +02:00

approx_const.rs

New excessive precision lint for floats

2018-04-24 15:18:23 -07:00

approx_const.stderr

New excessive precision lint for floats

2018-04-24 15:18:23 -07:00

arithmetic.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

arithmetic.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

array_indexing.rs

Extend indexing_slicing lint

2018-06-19 16:27:08 +00:00

array_indexing.stderr

Extend indexing_slicing lint

2018-06-19 16:27:08 +00:00

assign_ops2.rs

Additionally suggest the semantic equal variant

2018-01-30 17:45:35 +01:00

assign_ops2.stderr

Additionally suggest the semantic equal variant

2018-01-30 17:45:35 +01:00

assign_ops.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

assign_ops.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

attrs.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

attrs.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

author.rs

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

author.stdout

Patterns, locals and matches for author lint

2018-05-11 19:05:34 +02:00

bit_masks.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

bit_masks.stderr

Update test suite

2018-03-28 23:49:32 +02:00

blacklisted_name.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

blacklisted_name.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

block_in_if_condition.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

block_in_if_condition.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

bool_comparison.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

bool_comparison.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

booleans.rs

Cleaned implements_ord helper function in boolean lint file.

2018-06-03 22:56:17 +02:00

booleans.stderr

Fix nonminimal_bool false positive

2018-04-07 12:52:59 +02:00

borrow_box.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

borrow_box.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

box_vec.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

box_vec.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

builtin-type-shadow.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

builtin-type-shadow.stderr

Update tests

2018-03-15 10:25:57 +01:00

bytecount.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

bytecount.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cast_alignment.rs

Make cast_ptr_alignment ignore c_void

2018-04-24 11:37:51 -07:00

cast_alignment.stderr

Make cast_ptr_alignment ignore c_void

2018-04-24 11:37:51 -07:00

cast_lossless_float.rs

Split up casting UI tests

2018-01-06 11:22:20 +01:00

cast_lossless_float.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cast_lossless_integer.rs

Split up casting UI tests

2018-01-06 11:22:20 +01:00

cast_lossless_integer.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cast_size.rs

Split up casting UI tests

2018-01-06 11:22:20 +01:00

cast_size.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cast.rs

Split up casting UI tests

2018-01-06 11:22:20 +01:00

cast.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

char_lit_as_u8.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

char_lit_as_u8.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

checked_unwrap.rs

Categorize the unwrap lints correctly.

2018-06-12 15:06:46 +02:00

checked_unwrap.stderr

Categorize the unwrap lints correctly.

2018-06-12 15:06:46 +02:00

clone_on_copy_impl.rs

Don't suggest changing explicit Clone impls if they have generics

2018-01-11 10:28:42 +01:00

clone_on_copy_mut.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

cmp_nan.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

cmp_nan.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cmp_null.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

cmp_null.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cmp_owned.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

cmp_owned.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

collapsible_if.rs

typo

2018-04-05 04:13:14 +02:00

collapsible_if.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

complex_types.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

complex_types.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

const_static_lifetime.rs

Fix const_static_lifetime

2018-02-02 02:03:21 -05:00

const_static_lifetime.stderr

don't suggest eliding 'static on associated consts

2018-02-06 12:22:34 -06:00

copies.rs

Rustup

2018-03-16 09:44:20 +01:00

copies.stderr

Rustup

2018-03-16 09:44:20 +01:00

cstring.rs

move cstring tests

2017-10-09 23:39:45 -05:00

cstring.stderr

Update test suite

2018-03-28 23:49:32 +02:00

cyclomatic_complexity_attr_used.rs

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

cyclomatic_complexity_attr_used.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

cyclomatic_complexity.rs

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

cyclomatic_complexity.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

decimal_literal_representation.rs

Make decimal_literal_representation a restriction lint

2018-02-06 13:05:20 +01:00

decimal_literal_representation.stderr

Fix #2494 add suggestion for unreadable_literal

2018-03-03 12:25:20 -05:00

default_trait_access.rs

Exclude generated code

2018-06-18 10:29:25 +01:00

default_trait_access.stderr

Exclude generated code

2018-06-18 10:29:25 +01:00

default_trait_access.stdout

Add default_trait_access lint

2018-06-14 09:11:46 +01:00

deprecated.rs

Deprecate misaligned_transmute

2018-04-11 02:50:04 -07:00

deprecated.stderr

Deprecate misaligned_transmute

2018-04-11 02:50:04 -07:00

derive.rs

Update test suite

2018-03-28 23:49:32 +02:00

derive.stderr

Update test suite

2018-03-28 23:49:32 +02:00

diverging_sub_expression.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

diverging_sub_expression.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

dlist.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

dlist.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

doc.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

doc.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

double_comparison.rs

Add double comparions lint

2018-01-30 10:35:35 +09:00

double_comparison.stderr

Update test suite

2018-03-28 23:49:32 +02:00

double_neg.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

double_neg.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

double_parens.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

double_parens.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

drop_forget_copy.rs

Apply requested changes

2018-01-23 15:29:31 +01:00

drop_forget_copy.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

drop_forget_ref.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

drop_forget_ref.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

duplicate_underscore_argument.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

duplicate_underscore_argument.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

duration_subsec.rs

duration_subsec: Add check for subsec_micros

2018-06-12 08:25:10 +02:00

duration_subsec.stderr

duration_subsec: Add check for subsec_micros

2018-06-12 08:25:10 +02:00

duration_subsec.stdout

Add duration_subsec lint

2018-06-09 10:21:26 +02:00

else_if_without_else.rs

add new lint else_if_without_else

2018-01-14 22:53:00 -06:00

else_if_without_else.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

empty_enum.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

empty_enum.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

empty_line_after_outer_attribute.rs

Handle nested block comments

2018-03-30 12:36:50 +02:00

empty_line_after_outer_attribute.stderr

Make lint work on all members of ast::Item_

2018-01-29 10:03:52 +01:00

entry.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

entry.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

enum_glob_use.rs

Fix enum_glob_use false positives

2018-03-27 06:34:11 +02:00

enum_glob_use.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

enum_variants.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

enum_variants.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

enums_clike.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

enums_clike.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

eq_op.rs

Add tests to ensure that issue #2420 is resolved

2018-03-23 20:26:52 +02:00

eq_op.stderr

Add tests to ensure that issue #2420 is resolved

2018-03-23 20:26:52 +02:00

erasing_op.rs

Add erasing_op lint

2017-10-14 12:34:37 +03:00

erasing_op.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

escape_analysis.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

escape_analysis.stderr

…

eta.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

eta.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

eval_order_dependence.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

eval_order_dependence.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

excessive_precision.rs

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

excessive_precision.stderr

Fix 1x..x.0 false positive, pretty suggestion

2018-05-05 09:45:14 -07:00

explicit_write.rs

Change lint filename

2017-10-14 21:42:14 -03:00

explicit_write.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

fallible_impl_from.rs

Fix #2188

2017-11-29 17:20:00 +01:00

fallible_impl_from.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

filter_methods.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

filter_methods.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

float_cmp_const.rs

put back negative tests but allow float_cmp

2017-11-06 21:34:30 +11:00

float_cmp_const.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

float_cmp.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

float_cmp.stderr

Update to rustc master

2018-03-13 11:38:21 +01:00

for_loop.rs

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

for_loop.stderr

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

format.rs

Fix useless_format false negative

2018-04-12 08:21:03 +02:00

format.stderr

Fix useless_format false negative

2018-04-12 08:21:03 +02:00

formatting.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

formatting.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

functions.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

functions.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

get_unwrap.rs

move get_unwrap tests

2017-10-10 00:14:47 -05:00

get_unwrap.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

identity_conversion.rs

Test if #[allow] works

2017-10-04 22:26:41 +09:00

identity_conversion.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

identity_op.rs

Apply requested changes

2018-01-23 15:29:31 +01:00

identity_op.stderr

Apply requested changes

2018-01-23 15:29:31 +01:00

if_let_redundant_pattern_matching.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

if_let_redundant_pattern_matching.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

if_not_else.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

if_not_else.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

impl.rs

adding to pedantic a lint that check for multiple inherent implementations

2018-05-29 21:28:52 +02:00

impl.stderr

adding to pedantic a lint that check for multiple inherent implementations

2018-05-29 21:28:52 +02:00

implicit_hasher.rs

Fix some existing test expectations

2018-06-14 23:13:12 +01:00

implicit_hasher.stderr

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

inconsistent_digit_grouping.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

inconsistent_digit_grouping.stderr

Fix #2494 add suggestion for unreadable_literal

2018-03-03 12:25:20 -05:00

infallible_destructuring_match.rs

rustup

2018-04-27 14:00:43 +02:00

infallible_destructuring_match.stderr

Implement lint for destructuring tuple structs with a let and a match (closes #2671)

2018-04-24 17:56:13 +01:00

infinite_iter.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

infinite_iter.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

infinite_loop.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

infinite_loop.stderr

Don't trigger while_immutable_condition for mutable fields of tuples/structs

2018-04-03 16:41:30 +02:00

inline_fn_without_body.rs

Make lint work on all members of ast::Item_

2018-01-29 10:03:52 +01:00

inline_fn_without_body.stderr

Make lint work on all members of ast::Item_

2018-01-29 10:03:52 +01:00

int_plus_one.rs

Apply changes that were required for running in the rustc test suite

2017-11-14 14:56:00 +01:00

int_plus_one.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

invalid_ref.rs

Apply changes that were required for running in the rustc test suite

2017-11-14 14:56:00 +01:00

invalid_ref.stderr

Update test suite

2018-03-28 23:49:32 +02:00

invalid_upcast_comparisons.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

invalid_upcast_comparisons.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

issue_2356.rs

Fix get_enclosing_block

2018-02-02 01:53:48 -05:00

issue_2356.stderr

Fix get_enclosing_block

2018-02-02 01:53:48 -05:00

item_after_statement.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

item_after_statement.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

large_digit_groups.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

large_digit_groups.stderr

Update other tests

2018-05-28 14:43:44 +02:00

large_enum_variant.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

large_enum_variant.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

len_zero.rs

Update len_zero to handle comparisions with one

2018-05-06 23:54:05 +02:00

len_zero.stderr

Update len_zero to handle comparisions with one

2018-05-06 23:54:05 +02:00

let_if_seq.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

let_if_seq.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

let_return.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

let_return.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

let_unit.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

let_unit.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

lifetimes.rs

Add notes for test examples.

2018-06-19 23:18:53 +08:00

lifetimes.stderr

Add notes for test examples.

2018-06-19 23:18:53 +08:00

literals.rs

Add tests

2018-05-28 14:23:06 +02:00

literals.stderr

Update other tests

2018-05-28 14:43:44 +02:00

map_clone.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

map_clone.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

map_unit_fn.stderr

Rename option_map_unit_fn to map_unit_fn

2018-04-15 13:01:10 +02:00

match_bool.rs

Split up match_bool UI tests

2018-04-07 10:23:27 +02:00

match_bool.stderr

Split up match_bool UI tests

2018-04-07 10:23:27 +02:00

matches.rs

Split up match_bool UI tests

2018-04-07 10:23:27 +02:00

matches.stderr

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

mem_forget.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

mem_forget.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

methods.rs

Fix some existing test expectations

2018-06-14 23:13:12 +01:00

methods.stderr

Fix some existing test expectations

2018-06-14 23:13:12 +01:00

min_max.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

min_max.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

missing-doc.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

missing-doc.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

module_inception.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

module_inception.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

modulo_one.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

modulo_one.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

mut_from_ref.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

mut_from_ref.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

mut_mut.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

mut_mut.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

mut_range_bound.rs

Apply changes that were required for running in the rustc test suite

2017-11-14 14:56:00 +01:00

mut_range_bound.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

mut_reference.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

mut_reference.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

mutex_atomic.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

mutex_atomic.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

needless_bool.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

needless_bool.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

needless_borrow.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

needless_borrow.stderr

Move ref cow tests

2018-04-05 18:13:39 +02:00

needless_borrowed_ref.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

needless_borrowed_ref.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

needless_continue.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

needless_continue.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

needless_pass_by_value_proc_macro.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

needless_pass_by_value.rs

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

needless_pass_by_value.stderr

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

needless_range_loop.rs

Don't lint mixed slice indexing and usize indexing in needless_range_loop

2017-11-07 15:32:52 +01:00

needless_range_loop.stderr

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

needless_return.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

needless_return.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

needless_update.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

needless_update.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

neg_cmp_op_on_partial_ord.rs

Reduced scope of nonminimal_bool so that it doesn't evaluate only partially orded types.

2018-06-03 21:46:09 +02:00

neg_cmp_op_on_partial_ord.stderr

Reduced scope of nonminimal_bool so that it doesn't evaluate only partially orded types.

2018-06-03 21:46:09 +02:00

neg_multiply.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

neg_multiply.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

never_loop.rs

lint: immutable only vars in while condition

2018-02-25 18:25:31 +01:00

never_loop.stderr

Address review comments

2018-03-29 13:41:53 +02:00

new_without_default.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

new_without_default.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

no_effect.rs

Remove all mention and testing of #[plugin(clippy)] and warn if used

2018-05-11 13:20:39 +02:00

no_effect.stderr

Rustup field -> method transition of ..=

2018-05-03 15:52:44 +02:00

non_expressive_names.rs

Fix non_expressive_names

2018-02-02 01:54:07 -05:00

non_expressive_names.stderr

Fix non_expressive_names

2018-02-02 01:54:07 -05:00

ok_expect.rs

move ok_expect tests

2017-10-10 00:03:39 -05:00

ok_expect.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

ok_if_let.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

ok_if_let.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

op_ref.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

op_ref.stderr

Update to nightly 2018-05-28

2018-05-29 10:56:58 +02:00

open_options.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

open_options.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

option_map_unit_fn.rs

Rename option_map_unit_fn to map_unit_fn

2018-04-15 13:01:10 +02:00

option_map_unit_fn.stderr

Rename option_map_unit_fn to map_unit_fn

2018-04-15 13:01:10 +02:00

option_option.rs

Added further tests

2018-01-19 08:10:09 +02:00

option_option.stderr

Added further tests

2018-01-19 08:10:09 +02:00

overflow_check_conditional.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

overflow_check_conditional.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

panic_unimplemented.rs

Fix note on macro outside current crate. Changed group to restricted

2018-05-24 19:38:40 +02:00

panic_unimplemented.stderr

Fix note on macro outside current crate. Changed group to restricted

2018-05-24 19:38:40 +02:00

partialeq_ne_impl.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

partialeq_ne_impl.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

patterns.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

patterns.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

precedence.rs

Add macro check to precedence lint

2018-01-16 15:52:16 +01:00

precedence.stderr

Merge pull request #2364 from flip1995/precedence

2018-01-19 12:07:00 +01:00

print_literal.rs

Add more tests to print_ and write_literal

2018-04-21 19:51:35 +01:00

print_literal.stderr

Update stderrs for print and write_literal

2018-04-21 19:51:58 +01:00

print_with_newline.rs

Add #![allow(print_literal)] to other test/ui/print_*.rs tests

2018-04-02 00:24:40 +01:00

print_with_newline.stderr

Add #![allow(print_literal)] to other test/ui/print_*.rs tests

2018-04-02 00:24:40 +01:00

print.rs

New lints for write! / writeln! macros.

2018-04-07 22:45:26 -07:00

print.stderr

Add #![allow(print_literal)] to other test/ui/print_*.rs tests

2018-04-02 00:24:40 +01:00

println_empty_string.rs

fixing error message for empty println macro

2018-04-15 14:00:28 +02:00

println_empty_string.stderr

fixing error message for empty println macro

2018-04-15 14:00:28 +02:00

ptr_arg.rs

Move ref cow tests

2018-04-05 18:13:39 +02:00

ptr_arg.stderr

Move ref cow tests

2018-04-05 18:13:39 +02:00

question_mark.rs

Add question mark operator

2018-01-31 00:10:35 +01:00

question_mark.stderr

Update UI tests

2018-01-31 00:10:35 +01:00

range_plus_minus_one.rs

Rustup

2018-03-16 09:44:20 +01:00

range_plus_minus_one.stderr

Rustup

2018-03-16 09:44:20 +01:00

range.rs

Rustup

2018-03-16 09:44:20 +01:00

range.stderr

Rustup

2018-03-16 09:44:20 +01:00

redundant_closure_call.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

redundant_closure_call.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

redundant_field_names.rs

Rustup field -> method transition of ..=

2018-05-03 15:52:44 +02:00

redundant_field_names.stderr

Rustup field -> method transition of ..=

2018-05-03 15:52:44 +02:00

reference.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

reference.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

regex.rs

allow invalid UTF-8 in bytes Regexes

2018-04-07 22:18:51 +02:00

regex.stderr

allow invalid UTF-8 in bytes Regexes

2018-04-07 22:18:51 +02:00

replace_consts.rs

Removed stable feature flags

2018-05-28 10:03:27 +02:00

replace_consts.stderr

Removed stable feature flags

2018-05-28 10:03:27 +02:00

result_map_unit_fn.rs

rustup

2018-04-27 14:00:43 +02:00

result_map_unit_fn.stderr

rustup

2018-04-27 14:00:43 +02:00

serde.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

serde.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

shadow.rs

Update test suite

2018-03-28 23:49:32 +02:00

shadow.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

short_circuit_statement.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

short_circuit_statement.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

single_char_pattern.rs

Fix single_char_pattern for \n, \t, etc.

2018-03-02 22:00:01 +07:00

single_char_pattern.stderr

Fix single_char_pattern for \n, \t, etc.

2018-03-02 22:00:01 +07:00

single_match.rs

Split up some single_match UI tests

2018-04-05 22:45:36 +02:00

single_match.stderr

Split up some single_match UI tests

2018-04-05 22:45:36 +02:00

starts_ends_with.rs

move starts_ends_with tests

2017-10-09 23:36:29 -05:00

starts_ends_with.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

string_extend.rs

move string_extend tests

2017-10-09 23:57:17 -05:00

string_extend.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

strings.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

strings.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

stutter.rs

Update ui tests

2017-11-26 18:57:34 +01:00

stutter.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

suspicious_arithmetic_impl.rs

Don't lint comparison operators in arithmetic impls

2018-03-17 22:02:34 +01:00

suspicious_arithmetic_impl.stderr

Update test suite

2018-03-28 23:49:32 +02:00

swap.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

swap.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

temporary_assignment.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

temporary_assignment.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

toplevel_ref_arg.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

toplevel_ref_arg.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

trailing_zeros.rs

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

trailing_zeros.stderr

Use the new scoped tool attributes

2018-05-19 14:04:57 +02:00

trailing_zeros.stdout

manual fixups if_let_chain -> if_chain

2017-10-23 17:53:30 -04:00

transmute_32bit.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

transmute_64bit.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

transmute_64bit.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

transmute.rs

Fix behavior with generic lifetime parameters

2018-05-29 09:18:49 -07:00

transmute.stderr

Fix behavior with generic lifetime parameters

2018-05-29 09:18:49 -07:00

trivially_copy_pass_by_ref.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

trivially_copy_pass_by_ref.stderr

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

ty_fn_sig.rs

Add regression test (fixes #2234)

2017-11-29 16:05:13 +01:00

types_fn_to_int.rs

Divide FN_TO_NUMERIC lint into two.

2018-06-01 23:08:11 +07:00

types_fn_to_int.stderr

Divide FN_TO_NUMERIC lint into two.

2018-06-01 23:08:11 +07:00

types.rs

Start regression tests for types.rs

2017-12-23 10:15:11 -08:00

types.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unicode.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

unicode.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unit_arg.rs

Replace is_unit_expr

2018-01-18 17:04:26 -05:00

unit_arg.stderr

Replace is_unit_expr

2018-01-18 17:04:26 -05:00

unit_cmp.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

unit_cmp.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unnecessary_clone.rs

Moves clone_on_ref_ptr to be a restriction lint

2018-01-14 19:58:09 -08:00

unnecessary_clone.stderr

Update test suite

2018-03-28 23:49:32 +02:00

unnecessary_fold.rs

Move unnecessary_fold UI tests to separate file

2018-04-12 22:16:43 +02:00

unnecessary_fold.stderr

Move unnecessary_fold UI tests to separate file

2018-04-12 22:16:43 +02:00

unnecessary_ref.rs

Added lint for unnecessary references

2018-05-28 13:07:19 +02:00

unnecessary_ref.stderr

Added lint for unnecessary references

2018-05-28 13:07:19 +02:00

unneeded_field_pattern.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

unneeded_field_pattern.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unreadable_literal.rs

Increase unreadable_literal digits (fixes #1958)

2018-03-06 14:24:01 +01:00

unreadable_literal.stderr

Update other tests

2018-05-28 14:43:44 +02:00

unsafe_removed_from_name.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

unsafe_removed_from_name.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unused_io_amount.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

unused_io_amount.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unused_labels.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

unused_labels.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

unused_lt.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

unused_lt.stderr

Rustup

2018-05-26 10:23:34 +02:00

unwrap_or.rs

Add newlines in unwrap_or ui test

2018-02-20 12:37:30 -05:00

unwrap_or.stderr

Stop unwanted newlines being applied on unwrap_or

2018-02-21 11:29:08 -05:00

unwrap_or.stdout

Fix: point to correct problem part of code

2018-02-19 12:14:53 -05:00

update-all-references.sh

tests: fixup arg handling for update-all-references

2017-11-18 16:11:55 +01:00

update-references.sh

…

use_self.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

use_self.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

used_underscore_binding.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

used_underscore_binding.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

useless_asref.rs

Allow configuring the trivial copy size limit

2018-06-15 16:53:34 +02:00

useless_asref.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

useless_attribute.rs

Partly fix incorrect useless_attribute suggestion

2018-02-06 22:35:11 +01:00

useless_attribute.stderr

Partly fix incorrect useless_attribute suggestion

2018-02-06 22:35:11 +01:00

vec.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

vec.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

while_loop.rs

#1121: already fixed, adding a test

2018-01-29 16:52:22 +01:00

while_loop.stderr

Update spans

2018-01-29 09:48:11 +05:30

write_literal.rs

Add more tests to print_ and write_literal

2018-04-21 19:51:35 +01:00

write_literal.stderr

Update stderrs for print and write_literal

2018-04-21 19:51:58 +01:00

write_with_newline.rs

New lints for write! / writeln! macros.

2018-04-07 22:45:26 -07:00

write_with_newline.stderr

New lints for write! / writeln! macros.

2018-04-07 22:45:26 -07:00

writeln_empty_string.rs

New lints for write! / writeln! macros.

2018-04-07 22:45:26 -07:00

writeln_empty_string.stderr

fixing error message for empty println macro

2018-04-15 14:00:28 +02:00

wrong_self_convention.rs

New Lint: Pass small trivially copyable objects by value

2018-06-15 16:53:34 +02:00

wrong_self_convention.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00

zero_div_zero.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

zero_div_zero.stderr

Update test suite

2018-03-28 23:49:32 +02:00

zero_ptr.rs

Reduce the hackiness of cargo-clippy

2017-10-03 12:07:24 +02:00

zero_ptr.stderr

Update changed ui tests

2018-01-17 14:44:40 +01:00