Alex Macleod 90d0085ff4

match_as_ref: do not lint if other arm is not None => None (#15693) ...

Fixes rust-lang/rust-clippy#15691

changelog: [`match_as_ref`]: do not lint if other arm is not `None =>
None`

2025-09-17 17:56:20 +00:00

..

attrs

fix: useless_attribute FP on deprecated_in_future

2025-09-10 00:10:05 +08:00

cargo

…

casts

Fix as_underscore to only suggest when it's suggestable (#15652)

2025-09-12 13:28:28 +00:00

derive

Split out each lint into a separate module

2025-09-06 13:00:39 +02:00

doc

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

functions

fix(ref_option): don't lint in external and proc-macros

2025-09-13 11:29:24 +02:00

loops

Fix never_loop forget to remove break in nested loop (#15356)

2025-09-05 18:14:54 +00:00

matches

suggestion for rest_pat_in_fully_bound_structs (#15648)

2025-09-17 17:43:12 +00:00

methods

Refactor ptr_offset_with_cast (#15613)

2025-09-14 15:01:46 +00:00

misc_early

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

operators

clean-up a bit

2025-09-06 12:43:56 +02:00

returns

fix(needless_return): FP with cfgd code after return

2025-09-13 12:24:01 +02:00

transmute

fix(transmute_ptr_to_ref): don't suggest .cast when to-type is DST

2025-09-06 11:20:30 +02:00

types

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

unit_types

unit_cmp: don't lint on explicitly written unit expr

2025-08-26 19:14:36 -04:00

utils

add span to struct pattern rest (..)

2025-08-25 09:55:50 +02:00

absolute_paths.rs

…

almost_complete_range.rs

…

approx_const.rs

…

arbitrary_source_item_ordering.rs

…

arc_with_non_send_sync.rs

…

as_conversions.rs

…

asm_syntax.rs

…

assertions_on_constants.rs

…

assertions_on_result_states.rs

fix: assertions_on_result_states avoid changing return type in more cases

2025-08-30 16:50:43 +02:00

assigning_clones.rs

…

async_yields_async.rs

fix: async_yields_async wrongly unmangled macros

2025-08-26 00:55:54 +08:00

await_holding_invalid.rs

…

blocks_in_conditions.rs

…

bool_assert_comparison.rs

…

bool_comparison.rs

extract bool_comparison to a separate file

2025-08-22 23:50:02 +02:00

bool_to_int_with_if.rs

…

booleans.rs

…

borrow_deref_ref.rs

…

box_default.rs

…

byte_char_slices.rs

…

cfg_not_test.rs

…

checked_conversions.rs

…

cloned_ref_to_slice_refs.rs

…

coerce_container_to_any.rs

…

cognitive_complexity.rs

docs(cognitive_complexity): Correct lint group

2025-08-26 14:22:16 +02:00

collapsible_if.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

collection_is_never_read.rs

…

comparison_chain.rs

…

copies.rs

…

copy_iterator.rs

…

crate_in_macro_def.rs

…

create_dir.rs

…

dbg_macro.rs

…

declared_lints.rs

Refactor ptr_offset_with_cast (#15613)

2025-09-14 15:01:46 +00:00

default_constructed_unit_structs.rs

…

default_instead_of_iter_empty.rs

…

default_numeric_fallback.rs

…

default_union_representation.rs

…

default.rs

…

deprecated_lints.rs

…

dereference.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

derivable_impls.rs

fix: derivable_impls FN when enum is qualified with Self

2025-08-23 06:08:33 +08:00

disallowed_macros.rs

…

disallowed_methods.rs

…

disallowed_names.rs

…

disallowed_script_idents.rs

…

disallowed_types.rs

…

double_parens.rs

…

drop_forget_ref.rs

…

duplicate_mod.rs

…

else_if_without_else.rs

…

empty_drop.rs

…

empty_enum.rs

…

empty_line_after.rs

…

empty_with_brackets.rs

…

endian_bytes.rs

…

entry.rs

use get_diagnostic_item in even more places (#15528)

2025-08-23 23:16:29 +00:00

enum_clike.rs

…

equatable_if_let.rs

add span to struct pattern rest (..)

2025-08-25 09:55:50 +02:00

error_impl_error.rs

…

escape.rs

…

eta_reduction.rs

fix(needless_closure): don't lint on AsyncFn*s

2025-09-10 10:25:39 +02:00

excessive_bools.rs

…

excessive_nesting.rs

…

exhaustive_items.rs

…

exit.rs

…

explicit_write.rs

…

extra_unused_type_parameters.rs

…

fallible_impl_from.rs

…

field_scoped_visibility_modifiers.rs

…

float_literal.rs

Supress excessive_precision when constants are overly precise

2025-08-31 16:38:57 +01:00

floating_point_arithmetic.rs

…

format_args.rs

…

format_impl.rs

…

format_push_string.rs

…

format.rs

…

formatting.rs

…

four_forward_slashes.rs

…

from_over_into.rs

…

from_raw_with_void_ptr.rs

…

from_str_radix_10.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

future_not_send.rs

split any in two parts

2025-09-07 00:13:40 +02:00

if_let_mutex.rs

…

if_not_else.rs

…

if_then_some_else_none.rs

…

ignored_unit_patterns.rs

…

impl_hash_with_borrow_str_and_bytes.rs

…

implicit_hasher.rs

…

implicit_return.rs

…

implicit_saturating_add.rs

…

implicit_saturating_sub.rs

…

implied_bounds_in_impls.rs

…

incompatible_msrv.rs

…

inconsistent_struct_constructor.rs

…

index_refutable_slice.rs

…

indexing_slicing.rs

…

ineffective_open_options.rs

…

infallible_try_from.rs

…

infinite_iter.rs

…

inherent_impl.rs

…

inherent_to_string.rs

…

init_numbered_fields.rs

…

inline_fn_without_body.rs

…

instant_subtraction.rs

use is_path_diagnostic_item

2025-08-22 15:03:15 +02:00

int_plus_one.rs

…

integer_division_remainder_used.rs

…

invalid_upcast_comparisons.rs

fix: invalid_upcast_comparisons wrongly unmangled macros

2025-09-12 09:09:44 +08:00

item_name_repetitions.rs

…

items_after_statements.rs

…

items_after_test_module.rs

…

iter_not_returning_iterator.rs

…

iter_over_hash_type.rs

…

iter_without_into_iter.rs

…

large_const_arrays.rs

…

large_enum_variant.rs

…

large_futures.rs

…

large_include_file.rs

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

large_stack_arrays.rs

…

large_stack_frames.rs

…

legacy_numeric_constants.rs

…

len_zero.rs

fix(len_zero): don't eagerly call GenericArgs::type_at

2025-09-11 20:14:33 +02:00

let_if_seq.rs

…

let_underscore.rs

…

let_with_type_underscore.rs

make the lint early-pass

2025-08-22 15:03:26 +02:00

lib.rs

Refactor ptr_offset_with_cast (#15613)

2025-09-14 15:01:46 +00:00

lifetimes.rs

fix(elidable_lifetime_names): avoid overlapping spans in suggestions

2025-09-14 11:31:23 +02:00

lines_filter_map_ok.rs

…

literal_representation.rs

…

literal_string_with_formatting_args.rs

…

macro_metavars_in_unsafe.rs

…

macro_use.rs

…

main_recursion.rs

…

manual_abs_diff.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

manual_assert.rs

…

manual_async_fn.rs

…

manual_bits.rs

…

manual_clamp.rs

…

manual_div_ceil.rs

…

manual_float_methods.rs

…

manual_hash_one.rs

…

manual_ignore_case_cmp.rs

…

manual_is_ascii_check.rs

fix: also get ty_sugg in the matches! case

2025-08-22 20:15:52 +02:00

manual_is_power_of_two.rs

…

manual_let_else.rs

add span to struct pattern rest (..)

2025-08-25 09:55:50 +02:00

manual_main_separator_str.rs

…

manual_non_exhaustive.rs

…

manual_option_as_slice.rs

match_as_ref: do not lint if other arm is not None => None

2025-09-17 19:35:05 +02:00

manual_range_patterns.rs

…

manual_rem_euclid.rs

…

manual_retain.rs

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

manual_rotate.rs

…

manual_slice_size_calculation.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

manual_string_new.rs

…

manual_strip.rs

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

map_unit_fn.rs

Preserve unsafe blocks in option_map_unit suggestion

2025-08-26 22:45:25 +02:00

match_result_ok.rs

…

mem_replace.rs

other uses of get_diagnostic_name

2025-08-22 15:03:13 +02:00

min_ident_chars.rs

…

minmax.rs

…

misc.rs

extract to a separate file

2025-09-07 15:39:21 +02:00

mismatching_type_param_order.rs

…

missing_assert_message.rs

…

missing_asserts_for_indexing.rs

…

missing_const_for_fn.rs

…

missing_const_for_thread_local.rs

…

missing_doc.rs

…

missing_enforced_import_rename.rs

…

missing_fields_in_debug.rs

…

missing_inline.rs

Merge remote-tracking branch 'upstream/master' into rustup

2025-09-04 18:18:20 -04:00

missing_trait_methods.rs

…

mixed_read_write_in_expression.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

module_style.rs

…

multi_assignments.rs

…

multiple_bound_locations.rs

…

multiple_unsafe_ops_per_block.rs

fix: ignore unsafe ops from .await desugaring

2025-09-12 18:23:29 +02:00

mut_key.rs

…

mut_mut.rs

…

mut_reference.rs

unnecessary_mut_passed: add structured suggestion

2025-08-24 22:23:43 +02:00

mutable_debug_assertion.rs

…

mutex_atomic.rs

…

needless_arbitrary_self_type.rs

…

needless_bool.rs

extract bool_comparison to a separate file

2025-08-22 23:50:02 +02:00

needless_borrowed_ref.rs

…

needless_borrows_for_generic_args.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

needless_continue.rs

…

needless_else.rs

…

needless_for_each.rs

fix: needless_for_each suggests wrongly with explicit closure input types

2025-08-30 19:47:00 +02:00

needless_if.rs

…

needless_late_init.rs

…

needless_maybe_sized.rs

…

needless_parens_on_range_literals.rs

…

needless_pass_by_ref_mut.rs

…

needless_pass_by_value.rs

…

needless_question_mark.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

…

new_without_default.rs

…

no_effect.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

no_mangle_with_rust_abi.rs

…

non_canonical_impls.rs

misc: don't bother checking the other case

2025-08-22 15:03:18 +02:00

non_copy_const.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

non_expressive_names.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

non_octal_unix_permissions.rs

misc: reorder to have struct first, then its method

2025-08-22 15:03:17 +02:00

non_send_fields_in_send_ty.rs

…

non_std_lazy_statics.rs

…

non_zero_suggestions.rs

…

nonstandard_macro_braces.rs

…

octal_escapes.rs

…

only_used_in_recursion.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

option_env_unwrap.rs

…

option_if_let_else.rs

…

panic_in_result_fn.rs

…

panic_unimplemented.rs

Enable clippy::panic in const contexts

2025-08-26 18:42:58 +03:00

panicking_overflow_checks.rs

…

partial_pub_fields.rs

…

partialeq_ne_impl.rs

…

partialeq_to_none.rs

…

pass_by_ref_or_value.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

pathbuf_init_then_push.rs

…

pattern_type_mismatch.rs

…

permissions_set_readonly_false.rs

…

pointers_in_nomem_asm_block.rs

…

precedence.rs

…

ptr.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

pub_underscore_fields.rs

…

pub_use.rs

…

question_mark_used.rs

…

question_mark.rs

Recognize canonical ? pattern with Result

2025-09-15 19:17:32 +02:00

ranges.rs

…

raw_strings.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

rc_clone_in_vec_init.rs

…

read_zero_byte_vec.rs

fix: read_zero_byte_vec suggests wrongly inside let stmt

2025-09-04 06:56:24 +08:00

redundant_async_block.rs

…

redundant_clone.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

redundant_closure_call.rs

…

redundant_else.rs

…

redundant_field_names.rs

…

redundant_locals.rs

…

redundant_pub_crate.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

redundant_slicing.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

redundant_static_lifetimes.rs

…

redundant_test_prefix.rs

…

redundant_type_annotations.rs

…

ref_option_ref.rs

…

ref_patterns.rs

…

reference.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

regex.rs

…

repeat_vec_with_capacity.rs

…

reserve_after_initialization.rs

…

return_self_not_must_use.rs

…

same_name_method.rs

…

self_named_constructors.rs

…

semicolon_block.rs

fix(semicolon_inside_block): don't lint if block is in parens

2025-09-08 21:24:04 +02:00

semicolon_if_nothing_returned.rs

…

serde_api.rs

…

set_contains_or_insert.rs

…

shadow.rs

…

significant_drop_tightening.rs

…

single_call_fn.rs

…

single_char_lifetime_names.rs

…

single_component_path_imports.rs

…

single_option_map.rs

…

single_range_in_vec_init.rs

…

size_of_in_element_count.rs

…

size_of_ref.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

slow_vector_initialization.rs

…

std_instead_of_core.rs

fix: alloc_instead_of_core FP when alloc is an alias

2025-09-01 23:04:17 +08:00

string_patterns.rs

…

strings.rs

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

strlen_on_c_strings.rs

…

suspicious_operation_groupings.rs

…

suspicious_trait_impl.rs

…

suspicious_xor_used_as_pow.rs

…

swap_ptr_to_ref.rs

…

swap.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

tests_outside_test_module.rs

…

to_digit_is_some.rs

…

to_string_trait_impl.rs

…

toplevel_ref_arg.rs

tiny clean-up

2025-09-07 15:39:21 +02:00

trailing_empty_array.rs

…

trait_bounds.rs

…

tuple_array_conversions.rs

…

unconditional_recursion.rs

…

undocumented_unsafe_blocks.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

unicode.rs

…

uninhabited_references.rs

…

uninit_vec.rs

Remove expect collapsible_span_lint_calls from span_lint_and_then

2025-08-25 23:55:33 +05:00

unit_return_expecting_ord.rs

…

unnecessary_box_returns.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

unnecessary_literal_bound.rs

…

unnecessary_map_on_constructor.rs

…

unnecessary_owned_empty_strings.rs

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

unnecessary_self_imports.rs

…

unnecessary_semicolon.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

unnecessary_struct_initialization.rs

…

unnecessary_wraps.rs

get_diagnostic_name in other places

2025-08-22 15:03:17 +02:00

unneeded_struct_pattern.rs

…

unnested_or_patterns.rs

fix: unnested_or_patterns FP on structs with only shorthand field pats

2025-08-22 15:11:47 +02:00

unsafe_removed_from_name.rs

…

unused_async.rs

…

unused_io_amount.rs

other uses of get_diagnostic_name

2025-08-22 15:03:13 +02:00

unused_peekable.rs

reorganize peel_*_ty_refs functions

2025-09-12 18:13:20 +02:00

unused_result_ok.rs

…

unused_rounding.rs

…

unused_self.rs

…

unused_trait_names.rs

…

unused_unit.rs

unused_unit: don't lint on closure return types

2025-08-24 15:36:48 +02:00

unwrap_in_result.rs

Rewrite unwrap_in_result lint

2025-08-24 10:24:47 +02:00

unwrap.rs

Fix unnecessary_unwrap false negative when unwrapping a known value inside a macro call

2025-09-16 19:20:39 -03:00

upper_case_acronyms.rs

…

use_self.rs

remove has_lifetime

2025-09-06 12:43:56 +02:00

useless_concat.rs

…

useless_conversion.rs

clean-up a bit

2025-09-06 12:43:56 +02:00

vec_init_then_push.rs

…

vec.rs

…

visibility.rs

…

wildcard_imports.rs

…

write.rs

fix: print_literal suggests wrongly for inline literal following a numbered arg

2025-08-28 22:46:08 +08:00

zero_div_zero.rs

…

zero_repeat_side_effects.rs

…

zero_sized_map_values.rs

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-subtree-update

2025-08-22 14:57:22 +02:00

zombie_processes.rs

get_diagnostic_item in a bunch more places (#15519)

2025-08-23 22:01:42 +00:00