bors 8c4db851a7 Auto merge of #122662 - Mark-Simulacrum:optional-drop, r=bjorn3
Omit non-needs_drop drop_in_place in vtables

This replaces the drop_in_place reference with null in vtables. On librustc_driver.so, this drops about ~17k (11%) dynamic relocations from the output, since many vtables can now be placed in read-only memory, rather than having a relocated pointer included.

This makes a tradeoff by adding a null check at vtable call sites. I'm not sure that's readily avoidable without changing the vtable format (e.g., so that we can use a pc-relative relocation instead of an absolute address, and avoid the dynamic relocation that way). But it seems likely that the check is cheap at runtime.

Accepted MCP: https://github.com/rust-lang/compiler-team/issues/730
2024-05-28 16:04:14 +00:00
..
2024-04-24 13:12:33 +01:00
2024-05-28 13:38:44 +00:00
2024-04-24 13:12:33 +01:00
2024-04-11 21:42:35 -04:00
2024-04-11 21:42:35 -04:00
2024-04-11 21:42:35 -04:00
2024-04-11 21:42:35 -04:00
2024-04-22 18:48:47 +02:00
2024-04-11 21:42:35 -04:00
2024-02-24 19:49:16 +00:00
2024-03-13 01:17:15 -04:00
2024-04-24 13:12:33 +01:00
2024-03-10 22:47:30 -04:00
2024-04-22 18:48:47 +02:00
2024-04-22 18:48:47 +02:00
2024-04-11 21:42:35 -04:00
2024-04-11 21:42:35 -04:00
2024-03-29 15:37:43 -07:00
2024-02-23 18:04:01 -05:00

The files here use the LLVM FileCheck framework, documented at https://llvm.org/docs/CommandGuide/FileCheck.html.

One extension worth noting is the use of revisions as custom prefixes for FileCheck. If your codegen test has different behavior based on the chosen target or different compiler flags that you want to exercise, you can use a revisions annotation, like so:

// revisions: aaa bbb
// [bbb] compile-flags: --flags-for-bbb

After specifying those variations, you can write different expected, or explicitly unexpected output by using <prefix>-SAME: and <prefix>-NOT:, like so:

// CHECK: expected code
// aaa-SAME: emitted-only-for-aaa
// aaa-NOT:                        emitted-only-for-bbb
// bbb-NOT:  emitted-only-for-aaa
// bbb-SAME:                       emitted-only-for-bbb