Philipp Krones 935b45db61
Rollup merge of #5409 - dtolnay:letunit, r=flip1995 ...
Downgrade let_unit_value to pedantic
Given that the false positive in #1502 is marked E-hard and I don't have much hope of it getting fixed, I think it would be wise to disable this lint by default. I have had to suppress this lint in every substantial codebase (\>100k line) I have worked in. Any time this lint is being triggered, it's always the false positive case.
The motivation for this lint is documented as:
> A unit value cannot usefully be used anywhere. So binding one is kind of pointless.
with this example:
> ```rust
> let x = {
> 1;
> };
> ```
Sure, but the author would find this out via an unused_variable warning or from `x` not being the type that they need further down. If there ends up being a type error on `x`, clippy's advice isn't going to help get the code compiling because it can only run if the code already compiles.
changelog: Remove let_unit_value from default set of enabled lints
2020-04-08 15:50:16 +02:00
2020-03-04 00:56:43 +01:00
2020-03-30 11:17:58 +02:00
2020-03-18 15:26:24 +01:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-03-23 21:21:18 +01:00
2020-03-23 21:21:18 +01:00
2020-03-23 21:21:18 +01:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-03-30 11:17:58 +02:00
2020-03-11 06:35:07 +09:00
2020-04-02 18:31:31 -07:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-03-18 15:50:01 +01:00
2020-03-18 15:50:01 +01:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-03-03 19:23:04 -08:00
2020-03-03 18:06:59 -08:00
2020-03-03 15:52:53 -08:00
2020-03-30 21:42:16 +02:00
2020-03-30 21:42:16 +02:00
2020-03-13 00:31:09 +09:00
2020-03-13 00:31:09 +09:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-04-08 00:43:27 +02:00
2020-03-18 03:27:05 +01:00
2020-03-18 15:50:01 +01:00
2020-03-18 15:50:01 +01:00
2020-03-11 06:35:07 +09:00
2020-03-19 12:03:02 +05:30
2020-04-02 00:44:09 +05:30
2020-03-30 11:17:58 +02:00
2020-03-11 06:35:07 +09:00
2020-03-05 19:22:17 +01:00
2020-03-22 10:31:30 +01:00
2020-03-22 10:31:30 +01:00
2020-03-22 10:31:30 +01:00
2020-03-11 06:35:07 +09:00
2020-04-02 00:02:25 +02:00
2020-04-02 00:02:25 +02:00
2020-03-10 14:30:07 -07:00
2020-03-10 20:19:37 +01:00
2020-03-19 12:03:02 +05:30
2020-03-09 20:37:06 +01:00
2020-03-09 20:37:06 +01:00
2020-03-09 20:37:06 +01:00
2020-04-01 12:15:39 -07:00
2020-04-01 12:15:39 -07:00
2020-04-01 20:14:05 +02:00
2020-04-01 20:14:05 +02:00
2020-04-01 20:14:05 +02:00
2020-03-30 11:17:58 +02:00
2020-03-30 11:17:58 +02:00
2020-03-08 10:47:18 +01:00
2020-03-08 10:47:18 +01:00
2020-03-08 10:47:18 +01:00
2020-03-04 17:37:01 +09:00
2020-03-04 17:37:01 +09:00
2020-03-04 17:37:01 +09:00
2020-04-02 00:02:25 +02:00
2020-04-02 00:02:25 +02:00
2020-04-02 00:02:25 +02:00
2020-03-13 02:06:47 +09:00
2020-03-13 02:06:47 +09:00
2020-03-13 01:25:18 +09:00
2020-04-02 18:31:31 -07:00
2020-04-02 18:31:31 -07:00
2020-03-20 22:52:53 +00:00
2020-03-20 22:52:53 +00:00
2020-03-20 22:52:53 +00:00
2020-03-04 09:11:07 +01:00
2020-03-04 09:11:07 +01:00
2020-03-08 21:28:06 +00:00
2020-03-11 06:35:07 +09:00
2020-03-11 06:35:07 +09:00
2020-03-31 15:49:49 +05:30
2020-03-31 16:13:51 +05:30
2020-03-04 00:56:43 +01:00
2020-03-04 00:56:43 +01:00
2020-03-23 20:32:04 +01:00
2020-03-18 03:27:05 +01:00
2020-03-18 03:27:05 +01:00
2020-04-02 18:31:31 -07:00
2020-04-02 18:31:31 -07:00
2020-04-01 20:12:36 +02:00
2020-04-01 20:12:36 +02:00
2020-03-04 13:21:01 +01:00
2020-03-04 13:21:01 +01:00
2020-03-29 22:22:36 +02:00
2020-03-11 06:35:07 +09:00
2020-03-11 06:35:07 +09:00
2020-03-30 11:17:58 +02:00
2020-03-30 11:17:58 +02:00
2020-03-10 18:00:37 -04:00
2020-03-10 18:00:37 -04:00
2020-03-30 21:42:16 +02:00
2020-03-30 21:42:16 +02:00
2020-03-25 18:14:11 +01:00
2020-03-25 18:14:11 +01:00
2020-03-23 16:45:31 +00:00
2020-04-08 00:43:27 +02:00
935b45db61