Taylor Cramer d00d4dfe0d Refactor dyn-compatibility error and suggestions ...

This CL makes a number of small changes to dyn compatibility errors:
- "object safety" has been renamed to "dyn-compatibility" throughout
- "Convert to enum" suggestions are no longer generated when there
  exists a type-generic impl of the trait or an impl for `dyn OtherTrait`
- Several error messages are reorganized for user readability

Additionally, the dyn compatibility error creation code has been
split out into functions.

cc #132713
cc #133267

2025-01-22 09:20:57 -08:00

..

auxiliary

Add tests cases from review of #132289

2025-01-09 21:43:25 +01:00

fuzzing

reword trait bound suggestion message to include the bounds

2024-12-07 21:26:20 +00:00

negative-coherence

Re-enable ConstArgKind::Path lowering by default

2024-09-12 13:56:01 -04:00

occurs-check

avoid running the overlap check twice

2025-01-15 09:58:04 +01:00

super-traits

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

associated-type2.rs

Fix typos (taking into account review comments)

2024-05-18 18:12:18 +02:00

associated-type2.stderr

…

coherence_copy_like_err_fundamental_struct_ref.rs

…

coherence_copy_like_err_fundamental_struct_tuple.rs

…

coherence_copy_like_err_fundamental_struct_tuple.stderr

…

coherence_copy_like_err_fundamental_struct.rs

…

coherence_copy_like_err_struct.rs

…

coherence_copy_like_err_struct.stderr

…

coherence_copy_like_err_tuple.rs

…

coherence_copy_like_err_tuple.stderr

…

coherence_copy_like.rs

…

coherence_inherent_cc.rs

…

coherence_inherent_cc.stderr

…

coherence_inherent.rs

…

coherence_inherent.stderr

…

coherence_local_err_struct.rs

…

coherence_local_err_struct.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence_local_err_tuple.rs

…

coherence_local_err_tuple.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence_local_ref.rs

…

coherence_local.rs

…

coherence-all-remote.rs

…

coherence-all-remote.stderr

…

coherence-bigint-int.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-bigint-param.rs

…

coherence-bigint-param.stderr

…

coherence-bigint-vecint.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-blanket-conflicts-with-blanket-implemented.rs

…

coherence-blanket-conflicts-with-blanket-implemented.stderr

…

coherence-blanket-conflicts-with-blanket-unimplemented.rs

…

coherence-blanket-conflicts-with-blanket-unimplemented.stderr

…

coherence-blanket-conflicts-with-specific-cross-crate.rs

…

coherence-blanket-conflicts-with-specific-cross-crate.stderr

…

coherence-blanket-conflicts-with-specific-multidispatch.rs

Silence some follow-up errors on trait impls in case the trait has conflicting or otherwise incoherent impls

2024-04-09 10:23:58 +00:00

coherence-blanket-conflicts-with-specific-multidispatch.stderr

Silence some follow-up errors on trait impls in case the trait has conflicting or otherwise incoherent impls

2024-04-09 10:23:58 +00:00

coherence-blanket-conflicts-with-specific-trait.rs

…

coherence-blanket-conflicts-with-specific-trait.stderr

…

coherence-blanket-conflicts-with-specific.rs

…

coherence-blanket-conflicts-with-specific.stderr

…

coherence-blanket.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-conflicting-negative-trait-impl.rs

…

coherence-conflicting-negative-trait-impl.stderr

…

coherence-conflicting-repeated-negative-trait-impl-70849.rs

(fix) conflicting negative impl marker and add tests

2024-09-14 09:25:06 +08:00

coherence-conflicting-repeated-negative-trait-impl-70849.stderr

(fix) conflicting negative impl marker and add tests

2024-09-14 09:25:06 +08:00

coherence-covered-type-parameter.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-cow.re_a.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-cow.re_b.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-cow.re_c.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-cow.rs

…

coherence-cross-crate-conflict.rs

…

coherence-cross-crate-conflict.stderr

…

coherence-default-trait-impl.rs

…

coherence-default-trait-impl.stderr

…

coherence-doesnt-use-infcx-evaluate.rs

…

coherence-doesnt-use-infcx-evaluate.stderr

…

coherence-error-suppression.rs

…

coherence-error-suppression.stderr

…

coherence-fn-covariant-bound-vs-static.rs

…

coherence-fn-covariant-bound-vs-static.stderr

…

coherence-fn-implied-bounds.rs

…

coherence-fn-implied-bounds.stderr

…

coherence-fn-inputs.rs

…

coherence-fn-inputs.stderr

…

coherence-free-vs-bound-region.rs

…

coherence-free-vs-bound-region.stderr

…

coherence-fundamental-trait-objects.rs

…

coherence-fundamental-trait-objects.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-impl-in-fn.rs

…

coherence-impl-trait-for-marker-trait-negative.rs

…

coherence-impl-trait-for-marker-trait-negative.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-impl-trait-for-marker-trait-positive.rs

…

coherence-impl-trait-for-marker-trait-positive.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-impl-trait-for-trait-dyn-compatible.rs

UI tests: Rename "object safe" to "dyn compatible"

2024-10-10 01:13:29 +02:00

coherence-impl-trait-for-trait-dyn-compatible.stderr

Refactor dyn-compatibility error and suggestions

2025-01-22 09:20:57 -08:00

coherence-impl-trait-for-trait.rs

…

coherence-impl-trait-for-trait.stderr

…

coherence-impls-copy.rs

…

coherence-impls-copy.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-impls-send.rs

…

coherence-impls-send.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-impls-sized.rs

…

coherence-impls-sized.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-inherited-assoc-ty-cycle-err.rs

…

coherence-inherited-assoc-ty-cycle-err.stderr

…

coherence-inherited-subtyping.rs

…

coherence-inherited-subtyping.stderr

…

coherence-iterator-vec-any-elem.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-iterator-vec.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-lone-type-parameter.rs

…

coherence-lone-type-parameter.stderr

…

coherence-multidispatch-tuple.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-negative-impls-copy-bad.rs

…

coherence-negative-impls-copy-bad.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-negative-impls-copy.rs

Update tests.

2025-01-07 16:04:14 +01:00

coherence-negative-impls-safe-rpass.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

coherence-negative-impls-safe.rs

…

coherence-negative-impls-safe.stderr

…

coherence-negative-inherent-where-bounds.rs

…

coherence-negative-inherent.rs

…

coherence-negative-outlives-lifetimes.rs

…

coherence-negative-outlives-lifetimes.stock.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

coherence-negative-outlives-lifetimes.with_negative_coherence.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

coherence-no-direct-lifetime-dispatch.rs

…

coherence-no-direct-lifetime-dispatch.stderr

…

coherence-orphan.rs

Silence some follow-up errors on trait impls in case the trait has conflicting or otherwise incoherent impls

2024-04-09 10:23:58 +00:00

coherence-orphan.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-overlap-all-t-and-tuple.rs

…

coherence-overlap-all-t-and-tuple.stderr

…

coherence-overlap-double-negative.rs

…

coherence-overlap-downstream-inherent.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-downstream-inherent.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-downstream.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-downstream.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-issue-23516-inherent.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-issue-23516-inherent.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-issue-23516.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-issue-23516.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-messages.rs

…

coherence-overlap-messages.stderr

…

coherence-overlap-negate-alias-strict.rs

…

coherence-overlap-negate-not-use-feature-gate.rs

…

coherence-overlap-negate-not-use-feature-gate.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

coherence-overlap-negate-strict.rs

…

coherence-overlap-negate-use-feature-gate.rs

…

coherence-overlap-negative-impls.rs

…

coherence-overlap-negative-trait2.rs

…

coherence-overlap-negative-trait.rs

…

coherence-overlap-super-negative.rs

…

coherence-overlap-trait-alias.rs

…

coherence-overlap-trait-alias.stderr

…

coherence-overlap-unnormalizable-projection-0.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-unnormalizable-projection-0.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-unnormalizable-projection-1.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-unnormalizable-projection-1.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

coherence-overlap-upstream-inherent.rs

…

coherence-overlap-upstream-inherent.stderr

…

coherence-overlap-upstream.rs

…

coherence-overlap-upstream.stderr

…

coherence-overlap-with-regions.rs

…

coherence-overlapping-pairs.rs

…

coherence-overlapping-pairs.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-pair-covered-uncovered-1.rs

…

coherence-pair-covered-uncovered-1.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-pair-covered-uncovered.rs

…

coherence-pair-covered-uncovered.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-projection-conflict-orphan.rs

…

coherence-projection-conflict-orphan.stderr

…

coherence-projection-conflict-ty-param.rs

…

coherence-projection-conflict-ty-param.stderr

…

coherence-projection-conflict.rs

…

coherence-projection-conflict.stderr

…

coherence-projection-ok-orphan.rs

…

coherence-projection-ok.rs

…

coherence-rfc447-constrained.rs

…

coherence-subtyping.rs

…

coherence-subtyping.stderr

…

coherence-tuple-conflict.rs

…

coherence-tuple-conflict.stderr

…

coherence-unsafe-trait-object-impl.rs

Rename feature object_safe_for_dispatch to dyn_compatible_for_dispatch

2024-10-10 00:57:59 +02:00

coherence-unsafe-trait-object-impl.stderr

…

coherence-vec-local-2.rs

…

coherence-vec-local-2.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-vec-local.rs

…

coherence-vec-local.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

coherence-wasm-bindgen.rs

…

coherence-wasm-bindgen.stderr

…

coherence-where-clause.rs

…

coherence-with-closure.rs

…

coherence-with-closure.stderr

…

coherence-with-coroutine.rs

Error on using yield without also using #[coroutine] on the closure

2024-04-24 08:05:29 +00:00

coherence-with-coroutine.stock.stderr

Error on using yield without also using #[coroutine] on the closure

2024-04-24 08:05:29 +00:00

coherent-due-to-fulfill.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

conflicting-impl-with-err.rs

…

conflicting-impl-with-err.stderr

…

const-errs-dont-conflict-103369.rs

…

const-errs-dont-conflict-103369.stderr

…

const-generics-orphan-check-ok.rs

…

deep-bad-copy-reason.rs

…

deep-bad-copy-reason.stderr

Remove detail from label/note that is already available in other note

2024-10-29 16:26:57 +00:00

illegal-copy-bad-projection.rs

…

illegal-copy-bad-projection.stderr

…

impl-foreign-for-foreign.rs

…

impl-foreign-for-foreign.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

impl-foreign-for-foreign[foreign].rs

…

impl-foreign-for-foreign[foreign].stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

impl-foreign-for-foreign[local].rs

…

impl-foreign-for-fundamental[foreign].rs

…

impl-foreign-for-fundamental[foreign].stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

impl-foreign-for-fundamental[local].rs

…

impl-foreign-for-local.rs

…

impl-foreign-for-locally-defined-fundamental.rs

…

impl-foreign-for-locally-defined-fundamental[foreign].rs

…

impl-foreign[foreign]-for-foreign.rs

…

impl-foreign[foreign]-for-foreign.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

impl-foreign[foreign]-for-local.rs

…

impl-foreign[fundemental[foreign]]-for-foreign.rs

…

impl-foreign[fundemental[foreign]]-for-foreign.stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

impl-foreign[fundemental[local]]-for-foreign.rs

…

impl[t]-foreign-for-foreign[t].rs

…

impl[t]-foreign-for-foreign[t].stderr

Make new information notes instead of labels

2024-09-26 17:17:11 +00:00

impl[t]-foreign-for-fundamental[t].rs

…

impl[t]-foreign-for-fundamental[t].stderr

…

impl[t]-foreign[foreign[t]_local]-for-foreign.rs

…

impl[t]-foreign[foreign]-for-fundamental[t].rs

…

impl[t]-foreign[foreign]-for-fundamental[t].stderr

…

impl[t]-foreign[foreign]-for-t.rs

…

impl[t]-foreign[foreign]-for-t.stderr

…

impl[t]-foreign[fundamental[t]_local]-for-foreign.rs

…

impl[t]-foreign[fundamental[t]_local]-for-foreign.stderr

…

impl[t]-foreign[fundamental[t]]-for-foreign.rs

…

impl[t]-foreign[fundamental[t]]-for-foreign.stderr

…

impl[t]-foreign[fundamental[t]]-for-fundamental[t].rs

…

impl[t]-foreign[fundamental[t]]-for-fundamental[t].stderr

…

impl[t]-foreign[fundamental[t]]-for-local.rs

…

impl[t]-foreign[fundamental[t]]-for-t.rs

…

impl[t]-foreign[fundamental[t]]-for-t.stderr

…

impl[t]-foreign[fundemental[local]]-for-foreign[t].rs

…

impl[t]-foreign[local_fundamental[t]]-for-foreign.rs

…

impl[t]-foreign[local]-for-foreign.rs

…

impl[t]-foreign[local]-for-foreign[t].rs

…

impl[t]-foreign[local]-for-fundamental[foreign[t]].rs

…

impl[t]-foreign[local]-for-fundamental[t].rs

…

impl[t]-foreign[local]-for-fundamental[t].stderr

…

impl[t]-foreign[local]-for-local.rs

…

impl[t]-foreign[local]-for-t.rs

…

impl[t]-foreign[local]-for-t.stderr

…

impl[t]-foreign[t]-for-foreign.rs

…

impl[t]-foreign[t]-for-foreign.stderr

…

impl[t]-foreign[t]-for-fundamental.rs

…

impl[t]-foreign[t]-for-fundamental.stderr

…

impl[t]-foreign[t]-for-local.rs

…

impl[t]-foreign[t]-for-t.rs

…

impl[t]-foreign[t]-for-t.stderr

…

incoherent-even-though-we-fulfill.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

incoherent-even-though-we-fulfill.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

indirect-impl-for-trait-obj-coherence.next.stderr

better error message for normalizes-to ambiguities

2024-06-12 19:03:37 -04:00

indirect-impl-for-trait-obj-coherence.rs

better error message for normalizes-to ambiguities

2024-06-12 19:03:37 -04:00

inter-crate-ambiguity-causes-notes.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

inter-crate-ambiguity-causes-notes.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

issue-85026.rs

…

issue-85026.stderr

…

issue-99663-2.rs

…

issue-99663.rs

…

negative-coherence-check-placeholder-outlives.rs

…

negative-coherence-check-placeholder-outlives.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

negative-coherence-considering-regions.any_lt.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

negative-coherence-considering-regions.rs

…

negative-coherence-placeholder-region-constraints-on-unification.explicit.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

negative-coherence-placeholder-region-constraints-on-unification.rs

…

normalize-for-errors.rs

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

normalize-for-errors.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

orphan-check-alias.classic.stderr

Cleanup some known-bug issues

2024-09-27 18:15:37 +00:00

orphan-check-alias.next.stderr

Cleanup some known-bug issues

2024-09-27 18:15:37 +00:00

orphan-check-alias.rs

Cleanup some known-bug issues

2024-09-27 18:15:37 +00:00

orphan-check-diagnostics.rs

Move 100 entries from tests/ui into subdirs

2024-05-20 19:55:59 -07:00

orphan-check-diagnostics.stderr

Move 100 entries from tests/ui into subdirs

2024-05-20 19:55:59 -07:00

orphan-check-opaque-types-not-covering.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

orphan-check-opaque-types-not-covering.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

orphan-check-projections-covering.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

orphan-check-projections-nested.rs

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering-ambiguity.classic.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering-ambiguity.next.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering-ambiguity.rs

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering-multiple-params.classic.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering-multiple-params.next.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering-multiple-params.rs

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering.classic.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering.next.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-not-covering.rs

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-unsat-bounds.classic.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-unsat-bounds.next.stderr

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-projections-unsat-bounds.rs

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-weak-aliases-covering.rs

Normalize trait ref before orphan check & consider ty params in alias types to be uncovered

2024-04-30 21:54:54 +02:00

orphan-check-weak-aliases-not-covering.rs

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

orphan-check-weak-aliases-not-covering.stderr

remove unnecessary revisions

2024-10-15 13:26:59 +02:00

pr-review-132289-1.rs

Add tests cases from review of #132289

2025-01-09 21:43:25 +01:00

pr-review-132289-2.rs

Add tests cases from review of #132289

2025-01-09 21:43:25 +01:00

pr-review-132289-3.rs

Add tests cases from review of #132289

2025-01-09 21:43:25 +01:00

pr-review-132289-3.run.stdout

Add tests cases from review of #132289

2025-01-09 21:43:25 +01:00

re-rebalance-coherence-default-generic-associated-type.rs

…

re-rebalance-coherence.rs

Revert "Rollup merge of #125572 - mu001999-contrib:dead/enhance, r=pnkfelix"

2024-08-03 07:57:31 -04:00

skip-reporting-if-references-err.rs

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

skip-reporting-if-references-err.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

strict-coherence-needs-negative-coherence.rs

…

strict-coherence-needs-negative-coherence.stderr

…

warn-when-cycle-is-error-in-coherence.rs

…

warn-when-cycle-is-error-in-coherence.stderr

…