rust/codegen at c58e0bd09368a96dbde1ec1f30e36764e1431125 - rust

mirror of https://github.com/rust-lang/rust.git synced 2025-11-28 14:57:06 +00:00

History

Matthias Krüger accf61dd42

Rollup merge of #143293 - folkertdev:naked-function-kcfi, r=compiler-errors

fix `-Zsanitizer=kcfi` on `#[naked]` functions

fixes https://github.com/rust-lang/rust/issues/143266

With `-Zsanitizer=kcfi`, indirect calls happen via generated intermediate shim that forwards the call. The generated shim preserves the attributes of the original, including `#[unsafe(naked)]`. The shim is not a naked function though, and violates its invariants (like having a body that consists of a single `naked_asm!` call).

My fix here is to match on the `InstanceKind`, and only use `codegen_naked_asm` when the instance is not a `ReifyShim`. That does beg the question whether there are other `InstanceKind`s that could come up. As far as I can tell the answer is no: calling via `dyn` seems to work find, and `#[track_caller]` is disallowed in combination with `#[naked]`.

r? codegen
````@rustbot```` label +A-naked
cc ````@maurer```` ````@rcvalle````

2025-07-18 04:27:51 +02:00

asm

remove asm_goto feature annotation, for it is now stabilized

2025-06-21 23:26:56 +02:00

autodiff

Update generic tests

2025-05-21 07:24:43 +00:00

autovec

tests: Revise dont-shuffle-bswaps-opt3 per tested arch

2025-06-09 23:15:44 -07:00

auxiliary

…

avr

…

bounds-checking

…

cffi

stabilize naked_functions

2025-04-20 11:18:38 +02:00

compiletest-self-test

…

cross-crate-inlining

…

debug-accessibility

…

debuginfo-proc-macro

…

dllimports

…

enum

Rollup merge of #143270 - TimNN:fix-enum-match, r=nikic

2025-07-10 03:23:55 -04:00

ergonomic-clones

…

float

…

hint

…

instrument-coverage

…

instrument-xray

…

intrinsics

Add BuilderMethods::unreachable_nonterminator

2025-07-10 09:17:28 -07:00

issues

Describe lifetime of call argument temporaries passed indirectly

2025-05-17 09:49:03 +02:00

lib-optimizations

…

loongarch-abi

…

macos

…

meta-filecheck

…

naked-fn

Skip align tests on wasm

2025-07-06 18:10:52 -04:00

non-terminate

…

option-niche-unfixed

tests: mark option-niche-eq as fixed on LLVM 21

2025-05-27 11:20:52 -04:00

patchable-function-entry

…

remap_path_prefix

…

repr

enable msa feature for mips in codegen tests

2025-04-29 10:20:25 +02:00

riscv-abi

Fix RISC-V C function ABI when passing/returning structs containing floats

2025-06-16 10:14:07 +01:00

sanitizer

add codegen_instance_attrs query

2025-07-16 21:38:58 +02:00

simd

Let rvalue_creates_operand return true for *all* Rvalue::Aggregates

2025-07-07 23:08:10 -07:00

simd-intrinsic

Block SIMD in transmute_immediate; delete OperandValueKind

2025-07-03 22:23:15 -07:00

src-hash-algorithm

…

unwind-abis

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

aarch64-softfloat.rs

…

aarch64-struct-align-128.rs

…

abi-efiapi.rs

…

abi-main-signature-16bit-c-int.rs

…

abi-main-signature-32bit-c-int.rs

…

abi-repr-ext.rs

…

abi-sysv64.rs

…

abi-win64-zst.rs

…

abi-x86_64_sysv.rs

…

abi-x86-interrupt.rs

Error on invalid signatures for interrupt ABIs

2025-06-24 14:40:11 +02:00

abi-x86-sse.rs

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

addr-of-mutate.rs

…

adjustments.rs

…

align-byval-alignment-mismatch.rs

Describe lifetime of call argument temporaries passed indirectly

2025-05-17 09:49:03 +02:00

align-byval-vector.rs

…

align-byval.rs

…

align-enum.rs

…

align-fn.rs

Skip align tests on wasm

2025-07-06 18:10:52 -04:00

align-offset.rs

…

align-struct.rs

Allow all MIR Aggregates to take the operand path (if layout permits)

2025-07-03 22:53:19 -07:00

alloc-optimisation.rs

Change __rust_no_alloc_shim_is_unstable to be a function

2025-06-16 10:54:07 -07:00

amdgpu-addrspacecast.rs

…

array-clone.rs

…

array-cmp.rs

…

array-codegen.rs

…

array-equality.rs

…

array-from_fn.rs

…

array-map.rs

…

array-optimized.rs

…

array-repeat.rs

…

ascii-char.rs

…

assign-desugar-debuginfo.rs

…

async-closure-debug.rs

…

async-fn-debug-awaitee-field.rs

…

async-fn-debug-msvc.rs

…

async-fn-debug.rs

…

atomic-operations.rs

…

atomicptr.rs

…

autodiffv2.rs

…

autovectorize-f32x4.rs

…

bigint-helpers.rs

…

binary-heap-peek-mut-pop-no-panic.rs

…

binary-search-index-no-bound-check.rs

…

bool-cmp.rs

…

box-default-debug-copies.rs

…

box-uninit-bytes.rs

…

bpf-alu32.rs

…

branch-protection.rs

…

call-llvm-intrinsics.rs

…

call-tmps-lifetime.rs

Describe lifetime of call argument temporaries passed indirectly

2025-05-17 09:49:03 +02:00

cast-optimized.rs

…

cast-target-abi.rs

…

catch-unwind.rs

…

cdylib-external-inline-fns.rs

…

cf-protection.rs

…

cfguard-checks.rs

…

cfguard-disabled.rs

…

cfguard-nochecks.rs

…

cfguard-non-msvc.rs

…

char-ascii-branchless.rs

…

char-escape-debug-no-bounds-check.rs

…

checked_ilog.rs

…

checked_math.rs

…

clone_as_copy.rs

…

clone-shims.rs

…

codemodels.rs

…

coercions.rs

…

cold-call-declare-and-call.rs

…

common_prim_int_ptr.rs

Allow all MIR Aggregates to take the operand path (if layout permits)

2025-07-03 22:53:19 -07:00

comparison-operators-2-struct.rs

…

comparison-operators-2-tuple.rs

…

comparison-operators-newtype.rs

…

const_scalar_pair.rs

…

const-array.rs

…

const-vector.rs

Rollup merge of #140457 - fneddy:fix_s390x_codegen_const_vector, r=Mark-Simulacrum

2025-05-04 18:11:48 -04:00

constant-branch.rs

…

consts.rs

…

coroutine-debug-msvc.rs

…

coroutine-debug.rs

…

dealloc-no-unwind.rs

…

debug-alignment.rs

…

debug-column-msvc.rs

…

debug-column.rs

…

debug-compile-unit-path.rs

…

debug-fndef-size.rs

…

debug-limited.rs

…

debug-line-directives-only.rs

…

debug-line-tables-only.rs

…

debug-linkage-name.rs

…

debug-vtable.rs

…

debuginfo-constant-locals.rs

…

debuginfo-generic-closure-env-names.rs

…

debuginfo-inline-callsite-location.rs

…

deduced-param-attrs.rs

Unimplement unsized_locals

2025-06-13 01:16:36 +02:00

default-requires-uwtable.rs

…

default-visibility.rs

…

direct-access-external-data.rs

…

dont_codegen_private_const_fn_only_used_in_const_eval.rs

…

drop-in-place-noalias.rs

…

drop.rs

…

dst-offset.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

dst-vtable-align-nonzero.rs

…

dst-vtable-size-range.rs

…

ehcontguard_disabled.rs

…

ehcontguard_enabled.rs

…

emscripten-catch-unwind-js-eh.rs

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

emscripten-catch-unwind-wasm-eh.rs

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

enable-lto-unit-splitting.rs

…

error-provide.rs

Add opaque TypeId handles for CTFE

2025-07-09 16:37:11 +00:00

export-no-mangle.rs

…

external-no-mangle-fns.rs

…

external-no-mangle-statics.rs

…

f128-wasm32-callconv.rs

…

fastcall-inreg.rs

…

fatptr.rs

…

fewer-names.rs

…

fixed-x18.rs

…

float_math.rs

…

fn-impl-trait-self.rs

…

fn-parameters-on-different-lines-debuginfo.rs

tests: Test line debuginfo for linebreaked function parameters

2025-07-14 07:11:57 +02:00

force-frame-pointers.rs

…

force-no-unwind-tables.rs

…

force-unwind-tables.rs

…

frame-pointer-cli-control.rs

tests: remove define so dso_local attr does not disrupt test

2025-06-16 23:21:23 -07:00

frame-pointer.rs

aarch64-linux: Default to FramePointer::NonLeaf

2025-05-17 06:42:46 +02:00

function-arguments-noopt.rs

…

function-arguments.rs

Remove support for dyn*

2025-07-01 19:00:21 +00:00

function-return.rs

…

gdb_debug_script_load.rs

…

generic-debug.rs

…

gep-index.rs

…

gpu-kernel-abi.rs

…

i128-wasm32-callconv.rs

…

i128-x86-align.rs

…

i128-x86-callconv.rs

…

infallible-unwrap-in-opt-z.rs

…

inherit_overflow.rs

…

inline-always-works-always.rs

…

inline-debuginfo.rs

…

inline-function-args-debug-info.rs

…

inline-hint.rs

…

instrument-mcount.rs

…

integer-cmp.rs

…

integer-overflow.rs

…

internalize-closures.rs

…

intrinsic-no-unnamed-attr.rs

…

is_val_statically_known.rs

…

issue-97217.rs

…

iter-repeat-n-trivial-drop.rs

100% safe implementation of RepeatN

2025-06-13 22:32:15 +02:00

layout-size-checks.rs

…

lifetime_start_end.rs

…

link_section.rs

…

link-dead-code.rs

…

llvm_module_flags.rs

…

llvm-ident.rs

…

loads.rs

…

local-generics-in-exe-internalized.rs

…

lto-removes-invokes.rs

…

mainsubprogram.rs

…

match-optimized.rs

…

match-optimizes-away.rs

…

match-unoptimized.rs

…

maybeuninit-rvo.rs

…

mem-replace-big-type.rs

…

mem-replace-simple-type.rs

…

merge-functions.rs

…

method-declaration.rs

…

min-function-alignment.rs

Skip align tests on wasm

2025-07-06 18:10:52 -04:00

mir_zst_stores.rs

…

mir-aggregate-no-alloca.rs

…

mir-inlined-line-numbers.rs

…

move-before-nocapture-ref-arg.rs

…

move-operands.rs

…

naked-asan.rs

error on calls to ABIs that cannot be called

2025-06-20 19:09:02 +02:00

no_builtins-at-crate.rs

…

no-alloca-inside-if-false.rs

…

no-assumes-on-casts.rs

…

no-dllimport-w-cross-lang-lto.rs

…

no-jump-tables.rs

…

no-plt.rs

…

no-redundant-item-monomorphization.rs

…

noalias-box-off.rs

…

noalias-box.rs

…

noalias-flag.rs

…

noalias-freeze.rs

…

noalias-refcell.rs

…

noalias-rwlockreadguard.rs

…

noalias-unpin.rs

…

noreturn-uninhabited.rs

…

noreturnflag.rs

…

nounwind.rs

…

nrvo.rs

…

optimize-attr-1.rs

…

option-as-slice.rs

…

option-niche-eq.rs

tests: mark option-niche-eq as fixed on LLVM 21

2025-05-27 11:20:52 -04:00

overaligned-constant.rs

…

packed.rs

…

panic-abort-windows.rs

…

panic-in-drop-abort.rs

…

panic-unwind-default-uwtable.rs

…

pattern_type_symbols.rs

…

personality_lifetimes.rs

…

pgo-counter-bias.rs

…

pgo-instrumentation.rs

…

pic-relocation-model.rs

…

pie-relocation-model.rs

Apply ABI attributes on return types in rustc_codegen_cranelift

2025-06-12 00:47:01 +01:00

placement-new.rs

…

powerpc64le-struct-align-128.rs

…

precondition-checks.rs

…

ptr-arithmetic.rs

…

ptr-read-metadata.rs

…

range_to_inclusive.rs

…

range-attribute.rs

…

range-loop.rs

…

README.md

…

refs.rs

…

reg-struct-return.rs

…

regparm-inreg.rs

make abi_unsupported_vector_types a hard error

2025-04-20 11:34:56 +02:00

repeat-trusted-len.rs

…

retpoline.rs

tests: Convert two handwritten minicores to add-core-stubs

2025-06-13 18:59:41 -07:00

riscv-target-abi.rs

…

rust-abi-arch-specific-adjustment.rs

…

s390x-simd.rs

…

scalar-pair-bool.rs

…

set-discriminant-invalid.rs

Allow all MIR Aggregates to take the operand path (if layout permits)

2025-07-03 22:53:19 -07:00

skip-mono-inside-if-false.rs

…

slice_as_from_ptr_range.rs

…

slice-as_chunks.rs

…

slice-indexing.rs

…

slice-init.rs

…

slice-is-ascii.rs

…

slice-iter-fold.rs

…

slice-iter-len-eq-zero.rs

…

slice-iter-nonnull.rs

…

slice-last-elements-optimization.rs

…

slice-pointer-nonnull-unwrap.rs

…

slice-position-bounds-check.rs

…

slice-ref-equality.rs

…

slice-reverse.rs

…

slice-split-at.rs

…

slice-windows-no-bounds-check.rs

…

some-abis-do-extend-params-to-32-bits.rs

…

some-global-nonnull.rs

…

sparc-struct-abi.rs

…

split-lto-unit.rs

…

sroa-fragment-debuginfo.rs

…

sse42-implies-crc32.rs

…

stack-probes-inline.rs

…

stack-protector.rs

…

static-relocation-model-msvc.rs

…

staticlib-external-inline-fns.rs

…

step_by-overflow-checks.rs

…

stores.rs

…

string-push.rs

…

swap-large-types.rs

…

swap-small-types.rs

…

target-cpu-on-functions.rs

…

target-feature-inline-closure.rs

…

target-feature-negative-implication.rs

unify two -Ctarget-feature parsers

2025-06-19 09:44:24 +09:00

target-feature-overrides.rs

unify two -Ctarget-feature parsers

2025-06-19 09:44:24 +09:00

terminating-catchpad.rs

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

thread-local.rs

rustc_codegen_llvm: use threadlocal.address intrinsic to access TLS

2025-05-29 16:07:43 +02:00

tied-features-strength.rs

unify two -Ctarget-feature parsers

2025-06-19 09:44:24 +09:00

to_vec.rs

…

trailing_zeros.rs

…

transmute-optimized.rs

…

transmute-scalar.rs

Block SIMD in transmute_immediate; delete OperandValueKind

2025-07-03 22:23:15 -07:00

try_question_mark_nop.rs

…

tune-cpu-on-functions.rs

…

tuple-layout-opt.rs

…

ub-checks.rs

…

unchecked_shifts.rs

…

unchecked-float-casts.rs

…

uninhabited-transparent-return-abi.rs

…

uninit-consts.rs

…

uninit-repeat-in-aggregate.rs

…

union-abi.rs

…

union-aggregate.rs

Let rvalue_creates_operand return true for *all* Rvalue::Aggregates

2025-07-07 23:08:10 -07:00

unwind-and-panic-abort.rs

…

unwind-extern-exports.rs

…

unwind-extern-imports.rs

…

unwind-landingpad-cold.rs

…

unwind-landingpad-inline.rs

Change __rust_no_alloc_shim_is_unstable to be a function

2025-06-16 10:54:07 -07:00

used_with_arg.rs

…

var-names.rs

…

vec_pop_push_noop.rs

…

vec-as-ptr.rs

…

vec-calloc.rs

…

vec-in-place.rs

Block SIMD in transmute_immediate; delete OperandValueKind

2025-07-03 22:23:15 -07:00

vec-iter-collect-len.rs

Change __rust_no_alloc_shim_is_unstable to be a function

2025-06-16 10:54:07 -07:00

vec-iter.rs

…

vec-len-invariant.rs

…

vec-optimizes-away.rs

Change __rust_no_alloc_shim_is_unstable to be a function

2025-06-16 10:54:07 -07:00

vec-reserve-extend.rs

…

vec-shrink-panik.rs

…

vec-with-capacity.rs

…

vecdeque_no_panic.rs

…

vecdeque_pop_push.rs

…

vecdeque-drain.rs

…

vecdeque-nonempty-get-no-panic.rs

…

virtual-call-attrs-issue-137646.rs

…

virtual-function-elimination-32bit.rs

…

virtual-function-elimination.rs

Unimplement unsized_locals

2025-06-13 01:16:36 +02:00

vtable-loads.rs

…

vtable-upcast.rs

…

wasm_casts_trapping.rs

…

wasm_exceptions.rs

…

zip.rs

…

zst-offset.rs

…

README.md

The files here use the LLVM FileCheck framework, documented at https://llvm.org/docs/CommandGuide/FileCheck.html.

One extension worth noting is the use of revisions as custom prefixes for FileCheck. If your codegen test has different behavior based on the chosen target or different compiler flags that you want to exercise, you can use a revisions annotation, like so:

// revisions: aaa bbb
// [bbb] compile-flags: --flags-for-bbb

After specifying those variations, you can write different expected, or explicitly unexpected output by using <prefix>-SAME: and <prefix>-NOT:, like so:

// CHECK: expected code
// aaa-SAME: emitted-only-for-aaa
// aaa-NOT:                        emitted-only-for-bbb
// bbb-NOT:  emitted-only-for-aaa
// bbb-SAME:                       emitted-only-for-bbb