Nicholas Nethercote 958bc7b365 Handle _ properly in a couple of places. ...

Currently (PatKind::Wild` (i.e. `_`) gets turned by
`lower_fn_params_to_names` into an empty identifier, which means it is
printed incorrectly by HIR pretty printing.

And likewise for `lower_fn_params_to_names`, which affects some error
messages.

This commit fixes them. This requires a slight tweak in a couple of
places to continue using parameter numbers in some error messages. And
it improves the output of `tests/ui/typeck/cyclic_type_ice.rs`:
`/* _ */` is a better suggestion than `/*  */`.

2025-03-14 09:45:38 +11:00

..

auxiliary

Fix invalid suggestion from type error for derive macro

2025-02-23 14:44:27 +08:00

issue-87181

…

issue-114918

Manually walk into WF obligations in BestObligation proof tree visitor

2025-01-31 18:21:58 +00:00

apit-with-error-type-in-sig.rs

…

apit-with-error-type-in-sig.stderr

…

assign-non-lval-derefmut.fixed

…

assign-non-lval-derefmut.rs

…

assign-non-lval-derefmut.stderr

Move some things to std::sync::poison and reexport them in std::sync

2025-01-02 15:21:41 +03:00

assign-non-lval-mut-ref.fixed

…

assign-non-lval-mut-ref.rs

…

assign-non-lval-mut-ref.stderr

…

assign-non-lval-needs-deref.rs

…

assign-non-lval-needs-deref.stderr

…

attempted-access-non-fatal.rs

…

attempted-access-non-fatal.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

autoderef-with-param-env-error.rs

…

autoderef-with-param-env-error.stderr

…

bad-index-due-to-nested.current.stderr

Don't pick T: FnPtr nested goals

2025-01-22 06:55:38 +00:00

bad-index-due-to-nested.next.stderr

Don't pick T: FnPtr nested goals

2025-01-22 06:55:38 +00:00

bad-index-due-to-nested.rs

Don't pick T: FnPtr nested goals

2025-01-22 06:55:38 +00:00

bad-index-modulo-higher-ranked-regions.rs

…

bad-index-modulo-higher-ranked-regions.stderr

…

bad-recursive-type-sig-infer.rs

…

bad-recursive-type-sig-infer.stderr

…

bad-type-in-vec-contains.rs

…

bad-type-in-vec-contains.stderr

…

bad-type-in-vec-push.rs

…

bad-type-in-vec-push.stderr

…

call-block.rs

…

call-block.stderr

…

check-args-on-fn-err-2.rs

…

check-args-on-fn-err-2.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

check-args-on-fn-err.rs

…

check-args-on-fn-err.stderr

…

coercion-check-for-addition-issue-40610.rs

Rename and Move some UI tests to more suitable subdirs

2025-02-04 17:02:37 +05:30

coercion-check-for-addition-issue-40610.stderr

Rename and Move some UI tests to more suitable subdirs

2025-02-04 17:02:37 +05:30

coercion-check-for-indexing-expression-issue-40861.rs

Rename and Move some UI tests to more suitable subdirs

2025-02-04 17:02:37 +05:30

coercion-check-for-indexing-expression-issue-40861.stderr

Rename and Move some UI tests to more suitable subdirs

2025-02-04 17:02:37 +05:30

const-in-fn-call-generics.rs

…

const-in-fn-call-generics.stderr

…

conversion-methods.rs

…

conversion-methods.stderr

…

cyclic_type_ice.rs

…

cyclic_type_ice.stderr

Handle _ properly in a couple of places.

2025-03-14 09:45:38 +11:00

deref-multi.rs

…

deref-multi.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

derive-sugg-arg-arity.rs

…

derive-sugg-arg-arity.stderr

…

do-not-suggest-adding-missing-zero-to-floating-point-number.rs

…

do-not-suggest-adding-missing-zero-to-floating-point-number.stderr

…

do-not-suggest-placeholder-to-const-static-without-type.rs

…

do-not-suggest-placeholder-to-const-static-without-type.stderr

…

dont-record-adjustments-when-pointing-at-arg.rs

…

dont-record-adjustments-when-pointing-at-arg.stderr

…

escaping_bound_vars.rs

…

escaping_bound_vars.stderr

…

explain_clone_autoref.rs

…

explain_clone_autoref.stderr

…

foreign_struct_trait_unimplemented.rs

…

foreign_struct_trait_unimplemented.stderr

…

ice-self-mismatch-const-generics.rs

…

ice-self-mismatch-const-generics.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

ice-unexpected-region-123863.rs

…

ice-unexpected-region-123863.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

ice-with-expr-not-struct-127332.rs

…

ice-with-expr-not-struct-127332.stderr

…

invalid-stashed-level-issue-121812.rs

…

invalid-stashed-level-issue-121812.stderr

…

invalid-sugg-for-derive-macro-issue-136343.rs

Fix invalid suggestion from type error for derive macro

2025-02-23 14:44:27 +08:00

invalid-sugg-for-derive-macro-issue-136343.stderr

Fix invalid suggestion from type error for derive macro

2025-02-23 14:44:27 +08:00

issue-1871.rs

…

issue-1871.stderr

…

issue-2063-resource.rs

…

issue-2063.rs

…

issue-7813.rs

…

issue-7813.stderr

…

issue-10401.rs

…

issue-10401.stderr

…

issue-10969.rs

…

issue-10969.stderr

…

issue-13853-2.rs

…

issue-13853-2.stderr

…

issue-13853-5.rs

…

issue-13853-5.stderr

Trim suggestion part before generating highlights

2025-02-21 00:54:01 +00:00

issue-13853.rs

…

issue-13853.stderr

…

issue-16338.rs

…

issue-16338.stderr

…

issue-18937-1.rs

…

issue-18937.rs

…

issue-18937.stderr

…

issue-22375.rs

…

issue-29124.rs

…

issue-29124.stderr

…

issue-29181.rs

…

issue-29181.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

issue-31173.rs

…

issue-31173.stderr

…

issue-33575.rs

…

issue-33575.stderr

…

issue-36708.rs

…

issue-36708.stderr

…

issue-43189.rs

Enable more tests on Windows

2025-02-03 10:39:32 -05:00

issue-43189.stderr

Enable more tests on Windows

2025-02-03 10:39:32 -05:00

issue-46112.rs

Enable more tests on Windows

2025-02-03 10:39:32 -05:00

issue-46112.stderr

Enable more tests on Windows

2025-02-03 10:39:32 -05:00

issue-50687-ice-on-borrow.rs

…

issue-50687-ice-on-borrow.stderr

…

issue-52082-type-param-shadows-existing-type.rs

…

issue-52082-type-param-shadows-existing-type.stderr

…

issue-53712.rs

…

issue-53712.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-55810-must-typeck-match-pats-before-guards.rs

…

issue-57404.rs

…

issue-57404.stderr

…

issue-57673-ice-on-deref-of-boxed-trait.rs

…

issue-57673-ice-on-deref-of-boxed-trait.stderr

…

issue-61711-once-caused-rustc-inf-loop.rs

…

issue-65611.rs

…

issue-65611.stderr

…

issue-67971.rs

…

issue-67971.stderr

…

issue-68590-reborrow-through-derefmut.rs

…

issue-69378-ice-on-invalid-type-node-after-recovery.rs

…

issue-69378-ice-on-invalid-type-node-after-recovery.stderr

…

issue-72225-call-fnmut-through-derefmut.rs

…

issue-73592-borrow_mut-through-deref.fixed

…

issue-73592-borrow_mut-through-deref.rs

…

issue-73592-borrow_mut-through-deref.stderr

…

issue-74086.rs

…

issue-74086.stderr

…

issue-74933.rs

…

issue-75883.rs

…

issue-75883.stderr

…

issue-75889.rs

…

issue-75889.stderr

…

issue-79040.rs

Remove diagnostic_only_typeck and fix placeholder suggestion for const/static

2025-01-02 23:39:16 +00:00

issue-79040.stderr

Remove diagnostic_only_typeck and fix placeholder suggestion for const/static

2025-01-02 23:39:16 +00:00

issue-80207-unsized-return.rs

…

issue-80779.rs

…

issue-80779.stderr

…

issue-81293.rs

…

issue-81293.stderr

…

issue-81885.rs

…

issue-81885.stderr

…

issue-81943.rs

…

issue-81943.stderr

…

issue-82772.rs

…

issue-82772.stderr

Emit a single privacy error for multiple fields on the same struct expression

2025-01-18 20:33:15 +00:00

issue-83621-placeholder-static-in-extern.rs

…

issue-83621-placeholder-static-in-extern.stderr

…

issue-83693.rs

…

issue-83693.stderr

…

issue-84160.rs

…

issue-84160.stderr

…

issue-84768.rs

…

issue-84768.stderr

Use final path segment for diagnostic

2025-03-05 23:06:54 +00:00

issue-84831.rs

…

issue-84831.stderr

…

issue-86721-return-expr-ice.rev1.stderr

…

issue-86721-return-expr-ice.rev2.stderr

…

issue-86721-return-expr-ice.rs

…

issue-87771-ice-assign-assign-to-bool.rs

…

issue-87771-ice-assign-assign-to-bool.stderr

…

issue-87872-missing-inaccessible-field-literal.rs

…

issue-87872-missing-inaccessible-field-literal.stderr

…

issue-87872-missing-inaccessible-field-pattern.rs

…

issue-87872-missing-inaccessible-field-pattern.stderr

More sophisticated span trimming

2025-02-21 00:41:17 +00:00

issue-88609.rs

…

issue-88643.rs

…

issue-88643.stderr

…

issue-88803-call-expr-method.fixed

…

issue-88803-call-expr-method.rs

…

issue-88803-call-expr-method.stderr

…

issue-88844.rs

…

issue-88844.stderr

…

issue-89044-wrapped-expr-method.fixed

…

issue-89044-wrapped-expr-method.rs

…

issue-89044-wrapped-expr-method.stderr

…

issue-89275.rs

…

issue-89275.stderr

…

issue-89806.rs

…

issue-89806.stderr

…

issue-89856.fixed

…

issue-89856.rs

…

issue-89856.stderr

…

issue-89935.rs

…

issue-90027-async-fn-return-suggestion.rs

…

issue-90027-async-fn-return-suggestion.stderr

…

issue-90101.rs

…

issue-90101.stderr

…

issue-90164.rs

…

issue-90164.stderr

…

issue-90319.rs

…

issue-90319.stderr

…

issue-90483-inaccessible-field-adjustment.rs

…

issue-90483-inaccessible-field-adjustment.stderr

…

issue-90804-incorrect-reference-suggestion.rs

…

issue-90804-incorrect-reference-suggestion.stderr

…

issue-91210-ptr-method.fixed

…

issue-91210-ptr-method.rs

…

issue-91210-ptr-method.stderr

…

issue-91267.rs

…

issue-91267.stderr

…

issue-91328.fixed

…

issue-91328.rs

…

issue-91328.stderr

…

issue-91334.rs

…

issue-91334.stderr

…

issue-91450-inner-ty-error.rs

…

issue-91450-inner-ty-error.stderr

…

issue-91633.rs

…

issue-92481.rs

…

issue-92481.stderr

…

issue-93486.rs

…

issue-93486.stderr

…

issue-96530.rs

…

issue-96530.stderr

…

issue-96738.rs

…

issue-96738.stderr

…

issue-98260.rs

…

issue-98260.stderr

…

issue-98982.rs

…

issue-98982.stderr

…

issue-100164.fixed

…

issue-100164.rs

…

issue-100164.stderr

…

issue-100246.rs

…

issue-100246.stderr

…

issue-100285.rs

…

issue-100285.stderr

…

issue-103899.current.stderr

Update tests for dropck normalization errors

2025-02-17 11:33:07 +00:00

issue-103899.next.stderr

Update tests for dropck normalization errors

2025-02-17 11:33:07 +00:00

issue-103899.rs

Update tests for dropck normalization errors

2025-02-17 11:33:07 +00:00

issue-104510-ice.rs

…

issue-104510-ice.stderr

…

issue-104513-ice.rs

…

issue-104513-ice.stderr

…

issue-104582.rs

…

issue-104582.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-105946.rs

Check Sizedness of return type in WF

2025-02-03 19:00:22 +00:00

issue-105946.stderr

Check Sizedness of return type in WF

2025-02-03 19:00:22 +00:00

issue-106929.rs

…

issue-106929.stderr

…

issue-107087.rs

…

issue-107087.stderr

…

issue-107775.rs

…

issue-107775.stderr

Rework "long type names" printing logic

2025-01-31 20:39:01 +00:00

issue-110017-format-into-help-deletes-macro.fixed

…

issue-110017-format-into-help-deletes-macro.rs

…

issue-110017-format-into-help-deletes-macro.stderr

…

issue-110052.rs

…

issue-110052.stderr

More sophisticated span trimming

2025-02-21 00:41:17 +00:00

issue-112007-leaked-writeln-macro-internals.rs

…

issue-112007-leaked-writeln-macro-internals.stderr

…

issue-112252-ptr-arithmetics-help.fixed

…

issue-112252-ptr-arithmetics-help.rs

…

issue-112252-ptr-arithmetics-help.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-112385-while-assign-lhs-place-expr-ice.rs

…

issue-112385-while-assign-lhs-place-expr-ice.stderr

…

issue-114423-ice-regression-in-suggestion.rs

…

issue-114423-ice-regression-in-suggestion.stderr

…

issue-114529-illegal-break-with-value.rs

…

issue-114529-illegal-break-with-value.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-116473-ice-wrong-span-variant-args.rs

…

issue-116473-ice-wrong-span-variant-args.stderr

…

issue-116864.rs

…

issue-120856.rs

Reword "crate not found" resolve message

2025-01-24 01:19:50 +00:00

issue-120856.stderr

Reword "crate not found" resolve message

2025-01-24 01:19:50 +00:00

method-chain-gats.rs

…

method-chain-gats.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

mismatched-map-under-self.rs

…

mismatched-map-under-self.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

missing-private-fields-in-struct-literal.rs

…

missing-private-fields-in-struct-literal.stderr

…

no-type-for-node-ice.rs

…

no-type-for-node-ice.stderr

…

nonexistent-field-not-ambiguous.rs

…

nonexistent-field-not-ambiguous.stderr

…

output-type-mismatch.rs

…

output-type-mismatch.stderr

…

path-to-method-sugg-unresolved-expr.cargo-invoked.stderr

Reword "crate not found" resolve message

2025-01-24 01:19:50 +00:00

path-to-method-sugg-unresolved-expr.only-rustc.stderr

Reword "crate not found" resolve message

2025-01-24 01:19:50 +00:00

path-to-method-sugg-unresolved-expr.rs

Fix two malformed error annotations in a UI test

2025-02-01 22:26:07 +01:00

pin-unsound-issue-85099-derefmut.rs

…

point-at-type-param-in-path-expr.rs

…

point-at-type-param-in-path-expr.stderr

…

point-at-type-parameter-definition.rs

…

point-at-type-parameter-definition.stderr

…

prim-with-args.fixed

…

prim-with-args.rs

…

prim-with-args.stderr

…

project-cache-issue-37154.rs

…

ptr-null-mutability-suggestions.fixed

…

ptr-null-mutability-suggestions.rs

…

ptr-null-mutability-suggestions.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

question-mark-operator-suggestion-span.rs

…

question-mark-operator-suggestion-span.stderr

…

quiet-type-err-let-binding.rs

…

quiet-type-err-let-binding.stderr

…

remove-extra-argument.fixed

…

remove-extra-argument.rs

…

remove-extra-argument.stderr

When displaying a parameter mismatch error, only highlight the mismatched parameters when showing the definition.

2025-02-05 10:36:32 -05:00

remove-semi-but-confused-char.rs

…

remove-semi-but-confused-char.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

repeat-expr-checks-wf.rs

…

repeat-expr-checks-wf.stderr

…

return_type_containing_closure.rs

Rework "long type names" printing logic

2025-01-31 20:39:01 +00:00

return_type_containing_closure.stderr

Rework "long type names" printing logic

2025-01-31 20:39:01 +00:00

return-dyn-type-mismatch-2.rs

…

return-dyn-type-mismatch-2.stderr

…

return-dyn-type-mismatch.rs

…

return-dyn-type-mismatch.stderr

…

rhs-ty-hint-134162.e2018.stderr

…

rhs-ty-hint-134162.e2021.stderr

…

rhs-ty-hint-134162.e2024.stderr

…

rhs-ty-hint-134162.rs

…

slow-lhs-suggestion.rs

…

slow-lhs-suggestion.stderr

…

span-bug-issue-121410.rs

…

span-bug-issue-121410.stderr

…

struct-enum-wrong-args.rs

…

struct-enum-wrong-args.stderr

More sophisticated span trimming

2025-02-21 00:41:17 +00:00

struct-index-err-ice-issue-126744.rs

…

struct-index-err-ice-issue-126744.stderr

…

suggest-adding-missing-zero-to-floating-point-number.fixed

…

suggest-adding-missing-zero-to-floating-point-number.rs

…

suggest-adding-missing-zero-to-floating-point-number.stderr

…

suggest-arg-comma-delete-ice.rs

…

suggest-arg-comma-delete-ice.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

suggest-box-on-divergent-if-else-arms.fixed

…

suggest-box-on-divergent-if-else-arms.rs

…

suggest-box-on-divergent-if-else-arms.stderr

…

suggest-similar-impls-for-root-obligation.rs

…

suggest-similar-impls-for-root-obligation.stderr

…

suppressed-error.rs

…

suppressed-error.stderr

…

tag-that-dare-not-speak-its-name.rs

…

tag-that-dare-not-speak-its-name.stderr

…

terr-in-field.rs

…

terr-in-field.stderr

…

terr-sorts.rs

…

terr-sorts.stderr

…

type-placeholder-fn-in-const.rs

…

type-placeholder-fn-in-const.stderr

…

typeck_type_placeholder_1.rs

…

typeck_type_placeholder_item_help.rs

…

typeck_type_placeholder_item_help.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

typeck_type_placeholder_item.rs

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

typeck_type_placeholder_item.stderr

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

typeck_type_placeholder_lifetime_1.rs

…

typeck_type_placeholder_lifetime_1.stderr

…

typeck_type_placeholder_lifetime_2.rs

…

typeck_type_placeholder_lifetime_2.stderr

…

typeck_type_placeholder_mismatch.rs

…

typeck_type_placeholder_mismatch.stderr

…

typeck-builtin-bound-type-parameters.rs

…

typeck-builtin-bound-type-parameters.stderr

…

typeck-cast-pointer-to-float.rs

…

typeck-cast-pointer-to-float.stderr

…

typeck-closure-to-unsafe-fn-ptr.rs

…

typeck-default-trait-impl-assoc-type.fixed

…

typeck-default-trait-impl-assoc-type.rs

…

typeck-default-trait-impl-assoc-type.stderr

…

typeck-default-trait-impl-cross-crate-coherence.rs

…

typeck-default-trait-impl-cross-crate-coherence.stderr

…

typeck-default-trait-impl-negation-send.rs

…

typeck-default-trait-impl-negation-send.stderr

…

typeck-default-trait-impl-negation-sync.rs

…

typeck-default-trait-impl-negation-sync.stderr

…

typeck-default-trait-impl-send-param.rs

…

typeck-default-trait-impl-send-param.stderr

…

typeck-fn-to-unsafe-fn-ptr.rs

…

typeck-unsafe-always-share.rs

…

typeck-unsafe-always-share.stderr

…

ufcs-type-params.rs

…

unify-return-ty.rs

…

unsized-rvalue-issue-41139.rs

Rename and Move some UI tests to more suitable subdirs

2025-02-04 17:02:37 +05:30

unsized-rvalue-issue-41139.stderr

Rename and Move some UI tests to more suitable subdirs

2025-02-04 17:02:37 +05:30

while-loop-block-cond.rs

…

while-loop-block-cond.stderr

…

while-type-error.rs

…

while-type-error.stderr

…

wrong-ret-type.rs

…

wrong-ret-type.stderr

…