Matthias Krüger c77191f46b

Rollup merge of #142034 - estebank:issue-141258, r=davidtwco ...

Detect method not being present that is present in other tuple types

When a method is not present because of a trait bound not being met, and that trait bound is on a tuple, we check if making the tuple have no borrowed types makes the method to be found and highlight it if it does. This is a common problem for Bevy in particular and ORMs in general.

<img width="1166" alt="Screenshot 2025-06-04 at 10 38 24 AM" src="https://github.com/user-attachments/assets/d257c9ea-c2d7-42e7-8473-8b93aa54b8e0" />

Address rust-lang/rust#141258. I believe that more combination of cases in the tuple types should be handled (like adding borrows and checking when a specific type needs to not be a borrow while the rest stay the same), but for now this handles the most common case.

2025-06-12 22:09:43 +02:00

..

auxiliary

…

issues

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

supertrait-shadowing

Implement lint for definition site item shadowing too

2025-02-13 05:45:53 +00:00

assign-to-method.rs

…

assign-to-method.stderr

…

bad-wf-when-selecting-method.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

bad-wf-when-selecting-method.stderr

Do not ICE when encountering predicates from other items in method error reporting

2025-01-03 19:39:39 +00:00

call_method_unknown_pointee.rs

Use the more informative generic type inference failure error on method calls on raw pointers

2024-03-20 15:53:06 +00:00

call_method_unknown_pointee.stderr

Use the more informative generic type inference failure error on method calls on raw pointers

2024-03-20 15:53:06 +00:00

call_method_unknown_referent2.rs

Arbitrary self types v2: use Receiver trait

2024-12-11 11:59:12 +00:00

call_method_unknown_referent.rs

Arbitrary self types v2: use Receiver trait

2024-12-11 11:59:12 +00:00

call_method_unknown_referent.stderr

Arbitrary self types v2: use Receiver trait

2024-12-11 11:59:12 +00:00

clone-missing.rs

Coalesce duplicate missing clone tests

2025-04-29 12:46:26 +02:00

clone-missing.stderr

Coalesce duplicate missing clone tests

2025-04-29 12:46:26 +02:00

disambiguate-associated-function-first-arg.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

disambiguate-associated-function-first-arg.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

disambiguate-multiple-blanket-impl.rs

…

disambiguate-multiple-blanket-impl.stderr

Do not gather local all together at the beginning of typeck

2025-05-05 14:27:09 +00:00

disambiguate-multiple-impl.rs

…

disambiguate-multiple-impl.stderr

Do not gather local all together at the beginning of typeck

2025-05-05 14:27:09 +00:00

disambiguate-multiple-trait-2.rs

…

disambiguate-multiple-trait-2.stderr

Do not gather local all together at the beginning of typeck

2025-05-05 14:27:09 +00:00

disambiguate-multiple-trait.rs

…

disambiguate-multiple-trait.stderr

Do not gather local all together at the beginning of typeck

2025-05-05 14:27:09 +00:00

dont-ice-on-object-lookup-w-error-region.rs

Don't ICE when encountering error regions when confirming object method candidate

2024-07-26 13:18:35 -04:00

dont-ice-on-object-lookup-w-error-region.stderr

Don't ICE when encountering error regions when confirming object method candidate

2024-07-26 13:18:35 -04:00

dont-suggest-import-on-deref-err.rs

Don't give method suggestions when method probe fails due to bad impl of Deref

2024-09-29 11:57:18 -04:00

dont-suggest-import-on-deref-err.stderr

Don't give method suggestions when method probe fails due to bad impl of Deref

2024-09-29 11:57:18 -04:00

field-method-suggestion-using-return-ty.rs

…

field-method-suggestion-using-return-ty.stderr

…

filter-relevant-fn-bounds.rs

Make sure trait def ids match before zipping args in note_function_argument_obligation

2024-07-15 17:53:22 -04:00

filter-relevant-fn-bounds.stderr

Mention type parameter in more cases and don't suggest ~const bound already there

2024-12-07 21:37:13 +00:00

fulfillment-disqualifies-method.rs

Use fulfillment, not evaluate, during method probe

2024-04-21 20:10:12 -04:00

ident-from-macro-expansion.rs

Point of macro expansion from call expr if it involves macro var

2025-03-03 23:53:42 +00:00

ident-from-macro-expansion.stderr

Point of macro expansion from call expr if it involves macro var

2025-03-03 23:53:42 +00:00

inherent-bound-in-probe.rs

tests: remove explicit long type filename hash normalization from some ui tests

2025-03-04 00:21:02 +08:00

inherent-bound-in-probe.stderr

tests: remove explicit long type filename hash normalization from some ui tests

2025-03-04 00:21:02 +08:00

inherent-methods-same-name.rs

cleaned up some tests

2025-06-11 20:51:49 +05:00

issue-3707.rs

…

issue-3707.stderr

…

issue-7950.rs

Move tests

2024-03-03 16:30:48 -03:00

issue-7950.stderr

Move tests

2024-03-03 16:30:48 -03:00

issue-19521.rs

Move tests

2024-03-03 16:30:48 -03:00

issue-19521.stderr

Avoid extra path trimming in method not found error

2025-05-24 23:31:07 +02:00

leak-check-disquality.rs

Use fulfillment, not evaluate, during method probe

2024-04-21 20:10:12 -04:00

method-ambig-one-trait-unknown-int-type.rs

…

method-ambig-one-trait-unknown-int-type.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-ambig-two-traits-cross-crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-ambig-two-traits-cross-crate.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-ambig-two-traits-from-bounds.rs

…

method-ambig-two-traits-from-bounds.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-ambig-two-traits-from-impls2.rs

…

method-ambig-two-traits-from-impls2.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-ambig-two-traits-from-impls.rs

…

method-ambig-two-traits-from-impls.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-ambig-two-traits-with-default-method.rs

…

method-ambig-two-traits-with-default-method.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-ambiguity-no-rcvr.rs

…

method-ambiguity-no-rcvr.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-argument-inference-associated-type.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-call-err-msg.rs

…

method-call-err-msg.stderr

More sophisticated span trimming

2025-02-21 00:41:17 +00:00

method-call-lifetime-args-fail.rs

…

method-call-lifetime-args-fail.stderr

Revert suggestion verbosity change

2024-07-22 22:51:53 +00:00

method-call-lifetime-args-lint-fail.rs

…

method-call-lifetime-args-lint-fail.stderr

…

method-call-lifetime-args-lint.rs

…

method-call-lifetime-args-lint.stderr

…

method-call-lifetime-args-subst-index.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-call-lifetime-args-unresolved.rs

…

method-call-lifetime-args-unresolved.stderr

…

method-call-lifetime-args.rs

…

method-call-lifetime-args.stderr

…

method-call-type-binding.rs

Rename HIR TypeBinding to AssocItemConstraint and related cleanup

2024-05-30 22:52:33 +02:00

method-call-type-binding.stderr

Rename HIR TypeBinding to AssocItemConstraint and related cleanup

2024-05-30 22:52:33 +02:00

method-deref-to-same-trait-object-with-separate-params.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

method-deref-to-same-trait-object-with-separate-params.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

method-early-bound-lifetimes-on-self.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

method-lookup-order.rs

Fix test problems discovered by the revision check

2024-05-09 14:47:09 +10:00

method-macro-backtrace.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-macro-backtrace.stderr

…

method-missing-call.rs

…

method-missing-call.stderr

…

method-mut-self-modifies-mut-slice-lvalue.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-normalize-bounds-issue-20604.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

method-not-found-but-doc-alias.rs

…

method-not-found-but-doc-alias.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

method-not-found-generic-arg-elision.rs

…

method-not-found-generic-arg-elision.stderr

Avoid extra path trimming in method not found error

2025-05-24 23:31:07 +02:00

method-on-ambiguous-numeric-type.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-on-ambiguous-numeric-type.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

method-path-in-pattern.rs

…

method-path-in-pattern.stderr

…

method-probe-no-guessing-dyn-trait.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-projection.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-recursive-blanket-impl.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

method-recursive-blanket-impl.stderr

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

method-resolvable-path-in-pattern.rs

…

method-resolvable-path-in-pattern.stderr

…

method-self-arg-1.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

method-self-arg-1.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

method-self-arg-2.rs

…

method-self-arg-2.stderr

…

method-self-arg-aux1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-self-arg-aux2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-self-arg-trait.rs

Update tests for hidden references to mutable static

2024-09-13 14:10:56 +03:00

method-self-arg.rs

Update tests for hidden references to mutable static

2024-09-13 14:10:56 +03:00

method-trait-object-with-hrtb.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-two-trait-defer-resolution-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-two-trait-defer-resolution-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

method-two-trait-defer-resolution-2.stderr

…

method-two-traits-distinguished-via-where-clause.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

method-two-traits-distinguished-via-where-clause.stderr

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

method-where-clause.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

missing-bound-on-tuple.rs

Detect method not being present that is present in other tuple types

2025-06-04 18:18:06 +00:00

missing-bound-on-tuple.stderr

Detect method not being present that is present in other tuple types

2025-06-04 18:18:06 +00:00

missing-method-on-type-parameter.rs

Do not ICE on non-ADT rcvr type when looking for crate version collision

2024-08-26 13:02:21 -04:00

missing-method-on-type-parameter.stderr

Do not ICE on non-ADT rcvr type when looking for crate version collision

2024-08-26 13:02:21 -04:00

opaque_param_in_ufc.rs

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

probe-error-on-infinite-deref.rs

Use Autoderef::silence_errors more liberally throughout diagnostics code

2024-09-12 14:48:01 -04:00

probe-error-on-infinite-deref.stderr

Use Autoderef::silence_errors more liberally throughout diagnostics code

2024-09-12 14:48:01 -04:00

probe-for-diagnostic-doesnt-do-extra-work.rs

Add test to make sure suggestions are still quick

2024-05-13 23:38:31 -04:00

probe-for-diagnostic-doesnt-do-extra-work.stderr

Add test to make sure suggestions are still quick

2024-05-13 23:38:31 -04:00

probe-overflow-due-to-sized-predicate-ordering.rs

Make sure to insert Sized bound first into clauses list

2024-04-01 21:41:45 -04:00

receiver-equality.rs

Relate receiver invariantly in method probe for Mode::Path

2024-09-16 10:55:07 -04:00

receiver-equality.stderr

Avoid extra path trimming in method not found error

2025-05-24 23:31:07 +02:00

self-type-is-sup-no-eq.rs

Use sup instead of eq when unifying self type

2024-04-21 20:10:12 -04:00

suggest-convert-ptr-to-ref.rs

rework ptr-to-ref conversion suggestion for method calls

2024-04-10 18:51:09 +02:00

suggest-convert-ptr-to-ref.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

suggest-method-on-call-for-ambig-receiver.rs

Don't continue probing for method if in suggestion and autoderef hits ambiguity

2024-05-23 19:42:10 -04:00

suggest-method-on-call-for-ambig-receiver.stderr

Don't continue probing for method if in suggestion and autoderef hits ambiguity

2024-05-23 19:42:10 -04:00

suggest-method-on-call-with-macro-rcvr.rs

…

suggest-method-on-call-with-macro-rcvr.stderr

…

untrimmed-path-type.rs

Avoid extra path trimming in method not found error

2025-05-24 23:31:07 +02:00

untrimmed-path-type.stderr

Avoid extra path trimming in method not found error

2025-05-24 23:31:07 +02:00

vec-autoderef-autoref.rs

cleaned up some tests

2025-05-31 19:49:19 +05:00

vec-autoderef-autoref.stderr

cleaned up some tests

2025-05-31 19:49:19 +05:00