Nicholas Nethercote
f1ac54123f
Don't consider delayed bugs for -Ztreat-err-as-bug.
...
`-Ztreat-err-as-bug` treats normal errors and delayed bugs equally,
which can lead to some really surprising results.
This commit changes `-Ztreat-err-as-bug` so it ignores delayed bugs,
unless they get promoted to proper bugs and are printed.
This feels to me much simpler and more logical. And it simplifies the
implementation:
- The `-Ztreat-err-as-bug` check is removed from in
`DiagCtxt::{delayed_bug,span_delayed_bug}`.
- `treat_err_as_bug` doesn't need to count delayed bugs.
- The `-Ztreat-err-as-bug` panic message is simpler, because it doesn't
have to mention delayed bugs.
Output of delayed bugs is now more consistent. They're always printed
the same way. Previously when they triggered `-Ztreat-err-as-bug` they
would be printed slightly differently, via `span_bug` in
`span_delayed_bug` or `delayed_bug`.
A minor behaviour change: the "no errors encountered even though
`span_delayed_bug` issued" printed before delayed bugs is now a note
rather than a bug. This is done so it doesn't get counted as an error
that might trigger `-Ztreat-err-as-bug`, which would be silly.
This means that if you use `-Ztreat-err-as-bug=1` and there are no
normal errors but there are delayed bugs, the first delayed bug will be
shown (and the panic will happen after it's printed).
Also, I have added a second note saying "those delayed bugs will now be
shown as internal compiler errors". I think this makes it clearer what
is happening, because the whole concept of delayed bugs is non-obvious.
There are some test changes.
- equality-in-canonical-query.rs: Minor output changes, and the error
count reduces by one because the "no errors encountered even though
`span_delayed_bug` issued" message is no longer counted as an error.
- rpit_tait_equality_in_canonical_query.rs: Ditto.
- storage-live.rs: The query stack disappears because these delayed bugs
are now printed at the end, rather than when they are created.
- storage-return.rs, span_delayed_bug.rs: now need
`-Zeagerly-emit-delayed-bugs` because they need the delayed bugs
emitted immediately to preserve behaviour.
2024-01-13 09:59:56 +11:00
..
2023-08-19 18:47:08 +00:00
2023-12-14 15:22:37 +01:00
2023-11-24 19:15:52 +01:00
2023-05-12 10:26:50 +00:00
2023-08-28 03:16:48 -07:00
2023-11-24 19:15:52 +01:00
2023-10-26 17:58:02 +00:00
2023-11-24 19:15:52 +01:00
2023-06-16 19:39:48 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-06-16 19:39:48 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-06-16 19:39:48 +00:00
2023-07-27 08:23:06 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-10-20 21:14:01 +00:00
2023-10-08 10:06:17 +00:00
2023-11-24 19:15:52 +01:00
2023-05-30 12:40:35 +02:00
2023-11-24 19:15:52 +01:00
2023-08-12 17:18:46 +00:00
2023-08-12 17:18:46 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-09-28 16:13:38 +00:00
2023-12-14 15:22:37 +01:00
2023-06-18 20:56:30 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-07-14 12:35:33 +00:00
2023-06-16 19:39:48 +00:00
2023-09-28 16:13:38 +00:00
2023-09-28 16:13:38 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-08-19 18:47:08 +00:00
2023-10-29 17:45:05 -04:00
2023-10-29 17:45:05 -04:00
2023-09-05 20:20:55 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-08-30 11:06:46 +00:00
2023-08-30 11:06:46 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-10-08 10:06:17 +00:00
2023-10-25 12:04:54 +00:00
2024-01-02 14:17:56 +00:00
2023-10-25 12:04:54 +00:00
2024-01-02 14:17:56 +00:00
2023-06-22 15:51:20 +00:00
2023-11-24 19:15:52 +01:00
2023-06-22 15:51:20 +00:00
2023-06-22 15:51:20 +00:00
2023-07-21 13:19:36 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:17:00 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:17:00 +00:00
2023-07-07 13:17:00 +00:00
2023-07-07 13:13:18 +00:00
2023-06-16 19:39:48 +00:00
2023-11-24 19:15:52 +01:00
2023-10-23 23:35:27 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-06-21 16:33:17 +00:00
2023-06-21 16:33:17 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-10-08 10:06:17 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-01-08 20:30:24 +00:00
2024-01-08 20:30:24 +00:00
2023-10-26 17:58:02 +00:00
2023-11-24 19:15:52 +01:00
2023-10-30 19:24:15 +00:00
2023-11-24 19:15:52 +01:00
2023-05-12 10:24:03 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-01-02 14:17:56 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-06-16 19:39:48 +00:00
2023-11-24 19:15:52 +01:00
2023-10-20 21:14:02 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-11-24 19:15:52 +01:00
2023-10-20 21:14:02 +00:00
2023-10-20 21:14:01 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-11-02 20:57:05 +00:00
2023-11-02 20:57:05 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:17:00 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-12-14 15:22:37 +01:00
2024-01-10 08:52:44 +00:00
2024-01-10 08:52:44 +00:00
2023-12-14 15:22:37 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-10-20 21:14:02 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-10-27 05:16:26 +02:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-07-06 02:45:54 +09:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-06-22 15:36:42 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-08-30 11:06:46 +00:00
2023-05-26 14:42:52 +00:00
2023-11-24 19:15:52 +01:00
2023-09-13 17:35:44 +00:00
2023-11-24 19:15:52 +01:00
2023-10-30 13:46:44 +00:00
2023-07-07 13:17:00 +00:00
2023-07-07 13:13:18 +00:00
2023-11-24 19:15:52 +01:00
2023-12-20 00:19:45 -05:00
2023-12-20 00:19:45 -05:00
2024-01-05 21:49:37 +00:00
2024-01-05 21:54:41 +00:00
2023-07-21 13:19:36 +00:00
2023-09-14 15:16:48 +00:00
2023-09-14 15:16:48 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-07-07 13:13:18 +00:00
2023-06-22 15:36:42 +00:00
2023-11-24 19:15:52 +01:00
2023-10-05 18:56:30 +03:00
2023-06-24 13:00:15 +00:00
2023-12-14 15:22:37 +01:00
2023-10-13 19:13:56 +00:00
2023-10-13 19:13:56 +00:00
2023-11-24 19:15:52 +01:00
2023-06-21 16:41:52 +00:00
2023-11-24 19:15:52 +01:00
2023-06-16 19:39:48 +00:00
2023-08-02 13:40:28 +03:00
2023-08-02 13:40:28 +03:00
2023-10-16 18:23:12 +00:00
2023-11-24 19:15:52 +01:00
2023-07-18 15:56:03 +00:00
2023-11-24 19:15:52 +01:00
2023-07-18 15:56:03 +00:00
2023-11-24 19:15:52 +01:00
2023-10-26 17:58:02 +00:00
2023-10-26 17:58:02 +00:00
2023-10-18 06:19:04 +00:00
2024-01-13 09:59:56 +11:00
2024-01-13 09:59:56 +11:00
2023-08-30 11:06:46 +00:00
2023-11-24 19:15:52 +01:00
2023-12-18 23:55:47 +00:00
2023-12-18 23:55:47 +00:00
2023-12-18 23:55:47 +00:00
2023-12-18 23:55:47 +00:00
2023-12-18 23:55:47 +00:00
2023-12-18 23:55:47 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-10-05 18:56:30 +03:00
2023-07-07 13:13:18 +00:00
2023-07-07 13:13:18 +00:00
2024-01-07 18:00:03 +00:00
2024-01-07 18:00:03 +00:00
2023-06-16 19:39:48 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-10-30 20:16:22 +00:00
2023-11-24 19:15:52 +01:00
2023-08-12 17:18:46 +00:00
2023-11-24 19:15:52 +01:00
2023-08-06 12:08:32 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-06-22 15:51:19 +00:00
2023-09-05 20:20:55 +00:00
2023-09-05 20:20:55 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-08-08 09:39:42 +00:00
2023-11-09 11:32:51 +01:00
2023-12-14 15:22:37 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-05-07 01:41:20 +03:00