mirror of
https://github.com/rust-lang/rust.git
synced 2025-10-03 10:47:16 +00:00
d05323c7b4
This adds labels to the icons and moves them away from the search box. These changes are made together, because they work together, but are based on several complaints: * The [+/-] thing are a Reddit-ism. They don't look like buttons, but look like syntax <https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/More.20visual.20difference.20for.20the.20.2B.2F-.20.20Icons>, <https://github.com/rust-lang/rust/issues/59851> (some of these are laundry lists with more suggestions, but they all mention [+/-] looking wrong) * The settings, help, and summary buttons are also too hard to recognize <https://lwn.net/Articles/987070/>, <https://github.com/rust-lang/rust/issues/90310>, <https://github.com/rust-lang/rust/issues/14475#issuecomment-274241997>, <https://internals.rust-lang.org/t/improve-rustdoc-design/12758> ("Not all functionality is self-explanatory, for example the [+] button in the top right corner, the theme picker or the settings button.") The toggle-all and toggle-individual buttons both need done at once, since we want them to look like they go together. This changes them from both being [+/-] to both being arrows. Settings and Help are also migrated, so that the whole group can benefit from being described using actual words. Additionally, the Help button is only shown on SERPs, not all the time. This is done for two major reasons: * Most of what's in there is search-related. The things that aren't are keyboard commands, and the search box tells you about that anyway. Pressing <kbd>?</kbd> will temporarily show the button and its popover. * I'm trading it off by showing the help button, even on mobile. It's useful since you can use the search engine suggestions there. * The three buttons were causing line wrapping on too many desktop layouts.
21 lines
894 B
Plaintext
21 lines
894 B
Plaintext
// We check that when the anchor changes and is output of the displayed content,
|
|
// the page is scrolled to it.
|
|
go-to: "file://" + |DOC_PATH| + "/src/link_to_definition/lib.rs.html"
|
|
|
|
// We reduce the window size to make it easier to make an element "out of the page".
|
|
set-window-size: (600, 800)
|
|
// We check that the scroll is at the top first.
|
|
assert-property: ("html", {"scrollTop": "0"})
|
|
|
|
click: '//a[text() = "barbar" and @href="#5-7"]'
|
|
assert-property: ("html", {"scrollTop": "196"})
|
|
click: '//a[text() = "bar" and @href="#28-36"]'
|
|
assert-property: ("html", {"scrollTop": "228"})
|
|
click: '//a[normalize-space() = "sub_fn" and @href="#2-4"]'
|
|
assert-property: ("html", {"scrollTop": "124"})
|
|
|
|
// We now check that clicking on lines doesn't change the scroll
|
|
// Extra information: the "sub_fn" function header is on line 1.
|
|
click: '//*[@id="6"]'
|
|
assert-property: ("html", {"scrollTop": "124"})
|