mirror of
https://github.com/rust-lang/rust.git
synced 2025-10-10 06:09:21 +00:00
d9a67ea922
* Manually preserve rbx across cpuid instruction This fixes an issue observed when using __cpuid and __cpuid_count with Address Sanitizer enabled: the generated code uses the rbx register to access ASAN tracking information without reloading it after cpuid, resulting in a segfault since the rbx register is overwritten by cpuid (https://crbug.com/1072045). This seems like a compiler backend bug, and indeed there is a long-standing LLVM bug report about a very similar issue: https://bugs.llvm.org/show_bug.cgi?id=17907 To work around this issue, we can manually preserve the rbx register contents in the inline assembly. This is the approach taken by LLVM's own host cpuid detection code (lib/Host/Support.cpp). The original rbx value is stashed in rsi, which is then swapped with rbx to restore the original value as well as keep the output ebx value from the CPUID instruction to be used as an output of the inline assembly. The rbx clobber is also removed; this seems ineffective, and it conflicts with the ebx output of the inline assembly (ebx is a subregister of rbx): "Note that clobbering named registers that are also present in output constraints is not legal." (https://llvm.org/docs/LangRef.html#clobber-constraints) * Add link to LLVM bug in cpuid workaround comment