mirror of
https://github.com/rust-lang/rust.git
synced 2025-11-23 01:26:55 +00:00
786d828710
Remove double check when decoding ExpnId to avoid races Fixes debug assertion failure as described in https://github.com/rust-lang/rust/issues/141540#issuecomment-3462723909 Essentially failure happens during the race while decoding one `ExpnId` from different threads. This ICE doesn't happen with single threaded thread_pool due to early return within `decode_expn_id` with the same condition:8205e6b75e/compiler/rustc_middle/src/query/on_disk_cache.rs (L605-L607)However I believe this race does not hurt because `register_expn_id` is pretty much idempotent:8205e6b75e/compiler/rustc_span/src/hygiene.rs (L1397-L1413)