Matthias Krüger 4bf7765388

Rollup merge of #142477 - JonathanBrouwer:associated-type-suggestion, r=WaffleLapkin ...

Fix incorrect suggestion when calling an associated type with a type anchor

`sugg_span` here is the span of the call expression.
That span here is the `<Self>::Assoc`, which is exactly what we need here (even though I would expect it to include the arguments, but I guess it doesn't)

r? ``@WaffleLapkin``
One commit with failing tests and one that fixes it for reviewability

closes rust-lang/rust#142473

2025-06-14 11:27:12 +02:00

..

auxiliary

…

cache

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

associate-type-bound-normalization.rs

…

associated-item-long-paths.rs

…

associated-type-call.fixed

Fix incorrect suggestion when calling an associated type with a type anchor

2025-06-14 00:08:28 +02:00

associated-type-call.rs

Failing test

2025-06-14 00:08:02 +02:00

associated-type-call.stderr

Fix incorrect suggestion when calling an associated type with a type anchor

2025-06-14 00:08:28 +02:00

associated-type-destructuring-assignment.rs

…

associated-type-macro.rs

Use cfg(false) in UI tests

2025-04-03 21:41:58 +00:00

associated-type-macro.stderr

…

associated-type-projection-ambig-between-bound-and-where-clause.rs

…

associated-type-projection-ambig-between-bound-and-where-clause.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-type-projection-from-multiple-supertraits.rs

…

associated-type-projection-from-multiple-supertraits.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-type-projection-from-supertrait.rs

…

associated-type-projection-from-supertrait.stderr

…

associated-type-shadowed-from-non-local-supertrait.rs

…

associated-type-shadowed-from-non-local-supertrait.stderr

…

associated-type-shadowed-from-supertrait.rs

…

associated-type-shadowed-from-supertrait.stderr

…

associated-type-struct-construction.rs

…

associated-types-basic.rs

…

associated-types-binding-in-trait.rs

…

associated-types-binding-in-where-clause.rs

…

associated-types-binding-to-type-defined-in-supertrait.rs

…

associated-types-binding-to-type-defined-in-supertrait.stderr

…

associated-types-bound-ambiguity.rs

…

associated-types-bound-failure.fixed

…

associated-types-bound-failure.rs

…

associated-types-bound-failure.stderr

…

associated-types-bound.rs

…

associated-types-cc.rs

…

associated-types-coherence-failure.rs

…

associated-types-coherence-failure.stderr

…

associated-types-conditional-dispatch.rs

…

associated-types-constant-type.rs

…

associated-types-doubleendediterator-object.rs

…

associated-types-duplicate-binding-in-env-hrtb.rs

…

associated-types-duplicate-binding-in-env.rs

…

associated-types-enum-field-named.rs

…

associated-types-enum-field-numbered.rs

…

associated-types-eq-1.rs

…

associated-types-eq-1.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-types-eq-2.rs

chore: fix typos

2024-12-30 14:56:21 +07:00

associated-types-eq-2.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-types-eq-3.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

associated-types-eq-3.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

associated-types-eq-expr-path.rs

…

associated-types-eq-expr-path.stderr

…

associated-types-eq-hr.rs

…

associated-types-eq-hr.stderr

…

associated-types-eq-obj.rs

…

associated-types-for-unimpl-trait.fixed

…

associated-types-for-unimpl-trait.rs

…

associated-types-for-unimpl-trait.stderr

Normalize each signature input/output in typeck_with_fallback with its own span

2025-01-06 17:58:30 +00:00

associated-types-from-supertrait.rs

…

associated-types-ICE-when-projecting-out-of-err.rs

tests: use minicore more

2025-02-24 09:26:54 +00:00

associated-types-ICE-when-projecting-out-of-err.stderr

tests: use minicore more

2025-02-24 09:26:54 +00:00

associated-types-impl-redirect.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

associated-types-in-ambiguous-context.rs

Remove the -test suffix from normalize directives

2024-12-27 19:58:16 +11:00

associated-types-in-ambiguous-context.stderr

Preserve generic args in suggestions for ambiguous associated items

2025-05-06 17:04:03 +02:00

associated-types-in-bound-type-arg.rs

…

associated-types-in-default-method.rs

…

associated-types-in-fn.rs

…

associated-types-in-impl-generics.rs

…

associated-types-in-inherent-method.rs

…

associated-types-incomplete-object.rs

…

associated-types-incomplete-object.stderr

…

associated-types-invalid-trait-ref-issue-18865.rs

…

associated-types-invalid-trait-ref-issue-18865.stderr

…

associated-types-issue-17359.rs

…

associated-types-issue-17359.stderr

…

associated-types-issue-20220.rs

…

associated-types-issue-20220.stderr

…

associated-types-issue-20346.rs

…

associated-types-issue-20346.stderr

…

associated-types-issue-20371.rs

…

associated-types-issue-21212.rs

…

associated-types-iterator-binding.rs

…

associated-types-method.rs

…

associated-types-multiple-types-one-trait.rs

…

associated-types-multiple-types-one-trait.stderr

…

associated-types-nested-projections.rs

…

associated-types-nested-projections.stderr

…

associated-types-no-suitable-bound.rs

…

associated-types-no-suitable-bound.stderr

Normalize each signature input/output in typeck_with_fallback with its own span

2025-01-06 17:58:30 +00:00

associated-types-no-suitable-supertrait-2.rs

…

associated-types-no-suitable-supertrait-2.stderr

Normalize each signature input/output in typeck_with_fallback with its own span

2025-01-06 17:58:30 +00:00

associated-types-no-suitable-supertrait.rs

…

associated-types-no-suitable-supertrait.stderr

Normalize each signature input/output in typeck_with_fallback with its own span

2025-01-06 17:58:30 +00:00

associated-types-normalize-in-bounds-binding.rs

…

associated-types-normalize-in-bounds-ufcs.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

associated-types-normalize-in-bounds.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

associated-types-normalize-unifield-struct.rs

…

associated-types-outlives.rs

…

associated-types-outlives.stderr

…

associated-types-overridden-binding-2.rs

Do not deduplicate list of associated types provided by dyn principal

2025-02-21 19:32:45 +00:00

associated-types-overridden-binding-2.stderr

Do not deduplicate list of associated types provided by dyn principal

2025-02-21 19:32:45 +00:00

associated-types-overridden-binding.rs

Do not deduplicate list of associated types provided by dyn principal

2025-02-21 19:32:45 +00:00

associated-types-overridden-binding.stderr

Do not deduplicate list of associated types provided by dyn principal

2025-02-21 19:32:45 +00:00

associated-types-overridden-default.rs

…

associated-types-path-1.rs

…

associated-types-path-1.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-types-path-2.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

associated-types-path-2.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

associated-types-project-from-hrtb-in-fn-body.rs

…

associated-types-project-from-hrtb-in-fn-body.stderr

best_blame_constraint: don't filter constraints by sup SCC

2025-01-06 16:08:29 -08:00

associated-types-project-from-hrtb-in-fn.fixed

…

associated-types-project-from-hrtb-in-fn.rs

…

associated-types-project-from-hrtb-in-fn.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-types-project-from-hrtb-in-struct.rs

…

associated-types-project-from-hrtb-in-struct.stderr

…

associated-types-project-from-hrtb-in-trait-method.fixed

…

associated-types-project-from-hrtb-in-trait-method.rs

…

associated-types-project-from-hrtb-in-trait-method.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

associated-types-project-from-type-param-via-bound-in-where.rs

…

associated-types-projection-bound-ambiguity.rs

…

associated-types-projection-bound-in-supertraits.rs

…

associated-types-projection-from-known-type-in-impl.rs

…

associated-types-projection-from-known-type-in-impl.stderr

…

associated-types-projection-in-object-type.rs

…

associated-types-projection-in-supertrait.rs

…

associated-types-projection-in-where-clause.rs

…

associated-types-projection-to-unrelated-trait-in-method-without-default.fixed

…

associated-types-projection-to-unrelated-trait-in-method-without-default.rs

…

associated-types-projection-to-unrelated-trait-in-method-without-default.stderr

…

associated-types-projection-to-unrelated-trait.rs

…

associated-types-qualified-path-with-trait-with-type-parameters.rs

…

associated-types-ref-from-struct.rs

…

associated-types-ref-in-struct-literal.rs

…

associated-types-region-erasure-issue-20582.rs

…

associated-types-resolve-lifetime.rs

…

associated-types-return.rs

…

associated-types-simple.rs

…

associated-types-stream.rs

…

associated-types-struct-field-named.rs

…

associated-types-struct-field-numbered.rs

…

associated-types-subtyping-1.rs

…

associated-types-subtyping-1.stderr

…

associated-types-sugar-path.rs

…

associated-types-unconstrained.rs

…

associated-types-unconstrained.stderr

…

associated-types-unsized.fixed

…

associated-types-unsized.rs

…

associated-types-unsized.stderr

Unimplement unsized_locals

2025-06-13 01:16:36 +02:00

associated-types-where-clause-impl-ambiguity.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

avoid-getting-associated-items-of-undefined-trait.rs

fix #137508

2025-02-26 05:11:18 +09:00

avoid-getting-associated-items-of-undefined-trait.stderr

fix #137508

2025-02-26 05:11:18 +09:00

bound-lifetime-constrained.clause.stderr

…

bound-lifetime-constrained.func.stderr

…

bound-lifetime-constrained.object.stderr

…

bound-lifetime-constrained.rs

Remove attribute #[rustc_error]

2025-03-30 01:32:21 +03:00

bound-lifetime-in-binding-only.angle.stderr

…

bound-lifetime-in-binding-only.elision.stderr

…

bound-lifetime-in-binding-only.paren.stderr

…

bound-lifetime-in-binding-only.rs

Remove attribute #[rustc_error]

2025-03-30 01:32:21 +03:00

bound-lifetime-in-return-only.elision.stderr

…

bound-lifetime-in-return-only.local.stderr

…

bound-lifetime-in-return-only.rs

Remove attribute #[rustc_error]

2025-03-30 01:32:21 +03:00

bound-lifetime-in-return-only.sig.stderr

…

bound-lifetime-in-return-only.structure.stderr

…

default-associated-types.rs

…

defaults-cyclic-fail-1.rs

…

defaults-cyclic-fail-1.stderr

…

defaults-cyclic-fail-2.rs

…

defaults-cyclic-fail-2.stderr

…

defaults-cyclic-pass-1.rs

…

defaults-cyclic-pass-2.rs

…

defaults-in-other-trait-items-pass.rs

…

defaults-in-other-trait-items.rs

…

defaults-in-other-trait-items.stderr

…

defaults-mixed.rs

…

defaults-mixed.stderr

…

defaults-specialization.rs

…

defaults-specialization.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

defaults-suitability.current.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

defaults-suitability.next.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

defaults-suitability.rs

…

defaults-unsound-62211-1.current.stderr

…

defaults-unsound-62211-1.next.stderr

…

defaults-unsound-62211-1.rs

…

defaults-unsound-62211-2.current.stderr

…

defaults-unsound-62211-2.next.stderr

…

defaults-unsound-62211-2.rs

…

defaults-wf.rs

…

defaults-wf.stderr

…

dont-suggest-cyclic-constraint.rs

…

dont-suggest-cyclic-constraint.stderr

…

higher-ranked-projection.bad.stderr

…

higher-ranked-projection.rs

…

hr-associated-type-bound-1.rs

…

hr-associated-type-bound-1.stderr

…

hr-associated-type-bound-2.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

hr-associated-type-bound-2.stderr

…

hr-associated-type-bound-object.rs

fallout :skull_emoji:

2025-02-14 00:37:23 +01:00

hr-associated-type-bound-object.stderr

fallout :skull_emoji:

2025-02-14 00:37:23 +01:00

hr-associated-type-bound-param-1.rs

…

hr-associated-type-bound-param-1.stderr

…

hr-associated-type-bound-param-2.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

hr-associated-type-bound-param-2.stderr

fallout :skull_emoji:

2025-02-14 00:37:23 +01:00

hr-associated-type-bound-param-3.rs

…

hr-associated-type-bound-param-3.stderr

…

hr-associated-type-bound-param-4.rs

…

hr-associated-type-bound-param-4.stderr

…

hr-associated-type-bound-param-5.rs

…

hr-associated-type-bound-param-5.stderr

…

hr-associated-type-bound-param-6.rs

…

hr-associated-type-bound-param-6.stderr

…

hr-associated-type-projection-1.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

hr-associated-type-projection-1.stderr

Tweak wording

2024-12-07 22:18:51 +00:00

ident-from-macro-expansion.rs

Fix associated type errors too

2025-03-03 23:53:42 +00:00

ident-from-macro-expansion.stderr

Fix associated type errors too

2025-03-03 23:53:42 +00:00

impl-trait-return-missing-constraint.rs

…

impl-trait-return-missing-constraint.stderr

…

impl-wf-cycle-1.rs

…

impl-wf-cycle-1.stderr

…

impl-wf-cycle-2.rs

…

impl-wf-cycle-2.stderr

…

impl-wf-cycle-3.rs

…

impl-wf-cycle-3.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

impl-wf-cycle-4.rs

Use a query rather than recomputing the tail repeatedly

2025-04-09 20:26:58 +00:00

impl-wf-cycle-4.stderr

Use a query rather than recomputing the tail repeatedly

2025-04-09 20:26:58 +00:00

impl-wf-cycle-5.fixed

…

impl-wf-cycle-5.rs

…

impl-wf-cycle-5.stderr

…

impl-wf-cycle-6.fixed

…

impl-wf-cycle-6.rs

…

impl-wf-cycle-6.stderr

…

imply-relevant-nested-item-bounds-2.rs

…

imply-relevant-nested-item-bounds-for-gat.rs

…

imply-relevant-nested-item-bounds.rs

…

invalid-ctor.fixed

Suggest to replace tuple constructor through projection

2025-01-06 18:04:33 +00:00

invalid-ctor.rs

Suggest to replace tuple constructor through projection

2025-01-06 18:04:33 +00:00

invalid-ctor.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-18655.rs

…

issue-19081.rs

…

issue-19129-1.rs

…

issue-19129-2.rs

…

issue-19883.rs

…

issue-19883.stderr

…

issue-20005.rs

…

issue-20005.stderr

…

issue-20763-1.rs

…

issue-20763-2.rs

…

issue-20825-2.rs

…

issue-20825.rs

…

issue-20825.stderr

…

issue-21363.rs

…

issue-21726.rs

…

issue-22037.rs

…

issue-22037.stderr

…

issue-22066.rs

…

issue-22560.rs

…

issue-22560.stderr

…

issue-22828.rs

…

issue-23208.rs

…

issue-23595-1.rs

…

issue-23595-1.stderr

…

issue-23595-2.rs

…

issue-23595-2.stderr

…

issue-24159.rs

…

issue-24204.rs

…

issue-24338.rs

…

issue-25339.rs

…

issue-25700-1.rs

…

issue-25700-2.rs

…

issue-25700.rs

…

issue-25700.stderr

…

issue-26262.rs

…

issue-26262.stderr

…

issue-26681.rs

…

issue-26681.stderr

…

issue-27675-unchecked-bounds.rs

…

issue-27675-unchecked-bounds.stderr

…

issue-27901.rs

…

issue-28871.rs

…

issue-31597.rs

…

issue-32323.rs

…

issue-32323.stderr

…

issue-32350.rs

…

issue-36499.rs

UI tests: migrate remaining compile time error-patterns to line annotations

2025-04-13 21:48:53 +03:00

issue-36499.stderr

UI tests: migrate remaining compile time error-patterns to line annotations

2025-04-13 21:48:53 +03:00

issue-37808.rs

…

issue-37883.rs

…

issue-38821.rs

…

issue-38821.stderr

Do not suggest using -Zmacro-backtrace for builtin macros

2025-03-14 19:50:03 +00:00

issue-38917.rs

…

issue-39532.rs

…

issue-40093.rs

…

issue-41868.rs

…

issue-43475.rs

…

issue-43784-associated-type.rs

…

issue-43784-associated-type.stderr

…

issue-43924.rs

…

issue-43924.stderr

Avoid extra path trimming in method not found error

2025-05-24 23:31:07 +02:00

issue-44153.rs

…

issue-44153.stderr

…

issue-47139-1.rs

…

issue-47139-2.rs

…

issue-47385.rs

…

issue-47814.rs

…

issue-47814.stderr

…

issue-48010.rs

…

issue-48551.rs

…

issue-50301.rs

…

issue-54108.current.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

issue-54108.next.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

issue-54108.rs

…

issue-54182-1.rs

…

issue-54182-2.rs

…

issue-54467.rs

…

issue-55846.rs

…

issue-59324.rs

Elaborate param-env built for checking DispatchFromDyn for dyn compat

2025-03-11 16:32:56 +00:00

issue-59324.stderr

Do not mix normalized and unnormalized caller bounds when constructing param-env for receiver_is_dispatchable

2025-03-30 02:39:19 +00:00

issue-62200.rs

…

issue-62200.stderr

…

issue-63591.rs

…

issue-63593.current.stderr

…

issue-63593.next.stderr

…

issue-63593.rs

…

issue-64848.rs

…

issue-64855-2.rs

Adjust tests

2025-04-29 03:07:24 +00:00

issue-64855-2.stderr

Adjust tests

2025-04-29 03:07:24 +00:00

issue-64855.rs

Adjust tests

2025-04-29 03:07:24 +00:00

issue-64855.stderr

Adjust tests

2025-04-29 03:07:24 +00:00

issue-65774-1.rs

…

issue-65774-1.stderr

…

issue-65774-2.rs

…

issue-65774-2.stderr

…

issue-65934.rs

…

issue-67684.rs

…

issue-69398.rs

…

issue-71113.rs

…

issue-72806.rs

…

issue-72806.stderr

…

issue-76179.rs

…

issue-82079.rs

…

issue-85103-layout-debug.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

issue-85103-layout-debug.stderr

…

issue-87261.rs

…

issue-87261.stderr

…

issue-88856.rs

…

issue-91069.rs

…

issue-91231.rs

Update tests.

2025-01-07 16:04:14 +01:00

issue-91234.rs

…

mismatch-two-relevant-impls.rs

Use select in projection lookup

2025-04-30 18:07:52 +00:00

mismatch-two-relevant-impls.stderr

Use select in projection lookup

2025-04-30 18:07:52 +00:00

missing-associated-types.rs

…

missing-associated-types.stderr

Fix ICE when multiple supertrait substitutions need assoc but only one is provided

2024-12-11 19:53:40 +00:00

normalization-debruijn-1.rs

…

normalization-debruijn-2.rs

…

normalization-debruijn-3.rs

…

normalization-generality-2.rs

…

normalization-generality.rs

…

normalization-probe-cycle.rs

…

normalize-cycle-in-eval-no-region.rs

…

normalize-cycle-in-eval.rs

…

object-method-numbering.rs

…

object-normalization.rs

…

param-env-normalize-cycle.rs

…

point-at-type-on-obligation-failure-2.rs

…

point-at-type-on-obligation-failure-2.stderr

…

point-at-type-on-obligation-failure.rs

…

point-at-type-on-obligation-failure.stderr

…

project-defer-unification.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

project-recursion-limit-non-fatal.rs

…

remove-invalid-type-bound-suggest-issue-127555.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

remove-invalid-type-bound-suggest-issue-127555.stderr

Report impl has stricter requirements even when RPITIT inference gets in the way

2025-01-03 02:45:29 +00:00

substs-ppaux.normal.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

substs-ppaux.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

substs-ppaux.verbose.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

trait-with-supertraits-needing-sized-self.rs

…

trait-with-supertraits-needing-sized-self.stderr

…

tuple-struct-expr-pat.fixed

Make error for tuple struct pat/expr w/ FQS clearer

2025-04-27 18:10:08 +02:00

tuple-struct-expr-pat.rs

Make error for tuple struct pat/expr w/ FQS clearer

2025-04-27 18:10:08 +02:00

tuple-struct-expr-pat.stderr

Make error for tuple struct pat/expr w/ FQS clearer

2025-04-27 18:10:08 +02:00

wf-cycle-2.rs

…

wf-cycle.rs

…