From 41823a96df37ae62f688628a270aa570ae519bef Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Sat, 30 Apr 2022 21:30:38 -0700 Subject: [PATCH] Ignore more type_repetition_in_bounds I'm not sure what is going on with this lint but it's triggering in a lot of test code. Will need to investigate further. error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:194:21 | 194 | bound = "E: SerializeWith + DeserializeWith" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D clippy::type-repetition-in-bounds` implied by `-D clippy::pedantic` = help: consider combining the bounds: `"E: SerializeWith + DeserializeWith": "E: SerializeWith + DeserializeWith" + "E: SerializeWith + DeserializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:184:21 | 184 | #[serde(bound = "D: SerializeWith + DeserializeWith")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"D: SerializeWith + DeserializeWith": "D: SerializeWith + DeserializeWith" + "D: SerializeWith + DeserializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:210:31 | 210 | bound(serialize = "E: SerializeWith") | ^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"E: SerializeWith": "E: SerializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:201:31 | 201 | #[serde(bound(serialize = "D: SerializeWith", deserialize = "D: DeserializeWith"))] | ^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"D: SerializeWith": "D: SerializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:231:21 | 231 | bound = "E: SerializeWith + DeserializeWith" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"E: SerializeWith + DeserializeWith": "E: SerializeWith + DeserializeWith" + "E: SerializeWith + DeserializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:221:21 | 221 | #[serde(bound = "D: SerializeWith + DeserializeWith")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"D: SerializeWith + DeserializeWith": "D: SerializeWith + DeserializeWith" + "D: SerializeWith + DeserializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:247:31 | 247 | bound(serialize = "E: SerializeWith") | ^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"E: SerializeWith": "E: SerializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_gen.rs:238:31 | 238 | #[serde(bound(serialize = "D: SerializeWith", deserialize = "D: DeserializeWith"))] | ^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `"D: SerializeWith": "D: SerializeWith"` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:84:5 | 84 | C: MyDefault, | ^^^^^^^^^^^^ | = note: `-D clippy::type-repetition-in-bounds` implied by `-D clippy::pedantic` = help: consider combining the bounds: `C: MyDefault` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:85:5 | 85 | E: MyDefault, | ^^^^^^^^^^^^ | = help: consider combining the bounds: `E: MyDefault` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:105:5 | 105 | C: MyDefault; | ^^^^^^^^^^^^ | = help: consider combining the bounds: `C: MyDefault` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:1066:5 | 1066 | B: 'a, | ^^^^^ | = help: consider combining the bounds: `` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:1067:5 | 1067 | D: SerializeWith, | ^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `D: SerializeWith` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:1106:5 | 1106 | B: SerializeWith, | ^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `B: SerializeWith` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:1150:5 | 1150 | B: SerializeWith, | ^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `B: SerializeWith` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds error: this type has already been used as a bound predicate --> test_suite/tests/test_annotations.rs:1368:5 | 1368 | B: DeserializeWith, | ^^^^^^^^^^^^^^^^^^ | = help: consider combining the bounds: `B: DeserializeWith` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds --- test_suite/tests/test_annotations.rs | 3 ++- test_suite/tests/test_gen.rs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test_suite/tests/test_annotations.rs b/test_suite/tests/test_annotations.rs index c97de81a..382a951d 100644 --- a/test_suite/tests/test_annotations.rs +++ b/test_suite/tests/test_annotations.rs @@ -4,7 +4,8 @@ // Clippy bug: https://github.com/rust-lang/rust-clippy/issues/7422 clippy::nonstandard_macro_braces, clippy::too_many_lines, - clippy::trivially_copy_pass_by_ref + clippy::trivially_copy_pass_by_ref, + clippy::type_repetition_in_bounds )] use serde::de::{self, MapAccess, Unexpected, Visitor}; diff --git a/test_suite/tests/test_gen.rs b/test_suite/tests/test_gen.rs index fc8c0a6e..32b75cbb 100644 --- a/test_suite/tests/test_gen.rs +++ b/test_suite/tests/test_gen.rs @@ -14,7 +14,8 @@ clippy::nonstandard_macro_braces, clippy::ptr_arg, clippy::too_many_lines, - clippy::trivially_copy_pass_by_ref + clippy::trivially_copy_pass_by_ref, + clippy::type_repetition_in_bounds )] use serde::de::DeserializeOwned;