itsscb/sqlx
1
0
Fork 0
mirror of https://github.com/launchbadge/sqlx.git synced 2026-02-23 00:09:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sqlite EXPLAIN type inference improvements (#1984)

Browse Source 
* AggValue and ROW_NUMBER()

* Some more functions

* cargo fmt
This commit is contained in:
Rongcui Dong 2022-09-21 00:20:31 -04:00 committed by Austin Bonander
parent 42dd78fe93
commit 3cb8e07b44
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sqlx-core/src/sqlite/connection/explain.rs
View File

@ -88,6 +88,7 @@ const OP_OPEN_WRITE: &str = "OpenWrite";
const OP_OPEN_EPHEMERAL: &str = "OpenEphemeral";
const OP_OPEN_AUTOINDEX: &str = "OpenAutoindex";
const OP_AGG_FINAL: &str = "AggFinal";
const OP_AGG_VALUE: &str = "AggValue";
const OP_AGG_STEP: &str = "AggStep";
const OP_FUNCTION: &str = "Function";
const OP_MOVE: &str = "Move";
@ -727,11 +728,16 @@ pub(super) fn explain(
//else we don't know about the cursor
}
OP_AGG_STEP => {
OP_AGG_STEP | OP_AGG_VALUE => {
//assume that AGG_FINAL will be called
let p4 = from_utf8(p4).map_err(Error::protocol)?;
if p4.starts_with("count(") {
if p4.starts_with("count(")
|| p4.starts_with("row_number(")
|| p4.starts_with("rank(")
|| p4.starts_with("dense_rank(")
|| p4.starts_with("ntile(")
{
// count(_) -> INTEGER
state.r.insert(
p3,
@ -749,7 +755,12 @@ pub(super) fn explain(
OP_AGG_FINAL => {
let p4 = from_utf8(p4).map_err(Error::protocol)?;
if p4.starts_with("count(") {
if p4.starts_with("count(")
|| p4.starts_with("row_number(")
|| p4.starts_with("rank(")
|| p4.starts_with("dense_rank(")
|| p4.starts_with("ntile(")
{
// count(_) -> INTEGER
state.r.insert(
p1,