itsscb/tokio
1
0
Fork 0
mirror of https://github.com/tokio-rs/tokio.git synced 2025-10-01 12:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

time: fix race condition leading to lost timers (#6683)

Browse Source
This commit is contained in:
Weijia Jiang 2024-07-16 21:25:59 +08:00 committed by GitHub
parent 14c17fc096
commit 24344dfe4b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tokio/src/runtime/time/mod.rs
View File

@ -190,11 +190,13 @@ impl Driver {
assert!(!handle.is_shutdown());
// Finds out the min expiration time to park.
let expiration_time = (0..rt_handle.time().inner.get_shard_size())
.filter_map(|id| {
let lock = rt_handle.time().inner.lock_sharded_wheel(id);
lock.next_expiration_time()
})
let locks = (0..rt_handle.time().inner.get_shard_size())
.map(|id| rt_handle.time().inner.lock_sharded_wheel(id))
.collect::<Vec<_>>();
let expiration_time = locks
.iter()
.filter_map(|lock| lock.next_expiration_time())
.min();
rt_handle
@ -203,6 +205,9 @@ impl Driver {
.next_wake
.store(next_wake_time(expiration_time));
// Safety: After updating the `next_wake`, we drop all the locks.
drop(locks);
match expiration_time {
Some(when) => {
let now = handle.time_source.now(rt_handle.clock());