itsscb/tokio
1
0
Fork 0
mirror of https://github.com/tokio-rs/tokio.git synced 2025-10-01 12:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

rt: fix rng_seed test for threaded runtime (#5133)

Browse Source 
The improvement to the `rng_seed` tests added in #5075 missed a case in
the `rt_threaded` tests which was still checking for a specific value.
As described in that PR, this makes the tests fragile and changing tokio
internals may require updating the test.

This change fixes that half-implemented improvement so that the tests no
longer depend on the exact internal ordering, but rather compare two
runs of separate runtimes built with the same seed to check that the
results are the same.
This commit is contained in:
Hayden Stainsby 2022-10-27 18:29:30 +02:00 committed by GitHub
parent cb67f28fe3
commit 4bcd08b938
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
tokio/tests/rt_threaded.rs
View File

@ -571,16 +571,18 @@ mod unstable {
.rng_seed(RngSeed::from_bytes(seed))
.build()
.unwrap();
let rt1_value = rt1.block_on(async {
let random = tokio::macros::support::thread_rng_n(100);
assert_eq!(random, 86);
let rt1_values = rt1.block_on(async {
let rand_1 = tokio::macros::support::thread_rng_n(100);
let _ = tokio::spawn(async {
let rand_2 = tokio::spawn(async {
// Because we only have a single worker thread, the
// RNG will be deterministic here as well.
tokio::macros::support::thread_rng_n(100);
tokio::macros::support::thread_rng_n(100)
})
.await;
.await
.unwrap();
(rand_1, rand_2)
});
let rt2 = tokio::runtime::Builder::new_multi_thread()
@ -588,18 +590,20 @@ mod unstable {
.rng_seed(RngSeed::from_bytes(seed))
.build()
.unwrap();
let rt2_value = rt2.block_on(async {
let random = tokio::macros::support::thread_rng_n(100);
assert_eq!(random, 86);
let rt2_values = rt2.block_on(async {
let rand_1 = tokio::macros::support::thread_rng_n(100);
let _ = tokio::spawn(async {
let rand_2 = tokio::spawn(async {
// Because we only have a single worker thread, the
// RNG will be deterministic here as well.
tokio::macros::support::thread_rng_n(100);
tokio::macros::support::thread_rng_n(100)
})
.await;
.await
.unwrap();
(rand_1, rand_2)
});
assert_eq!(rt1_value, rt2_value);
assert_eq!(rt1_values, rt2_values);
}
}