itsscb/tokio
1
0
Fork 0
mirror of https://github.com/tokio-rs/tokio.git synced 2025-10-01 12:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

io: improve safety comment on FillBuf (#4476)

Browse Source
This commit is contained in:
Alice Ryhl 2022-02-07 10:07:58 +01:00 committed by GitHub
parent 5690f0c32e
commit d6143c9566
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tokio/src/io/util/fill_buf.rs
View File

@ -40,6 +40,12 @@ impl<'a, R: AsyncBufRead + ?Sized + Unpin> Future for FillBuf<'a, R> {
// Safety: This is necessary only due to a limitation in the // Safety: This is necessary only due to a limitation in the
// borrow checker. Once Rust starts using the polonius borrow // borrow checker. Once Rust starts using the polonius borrow
// checker, this can be simplified. // checker, this can be simplified.
//
// The safety of this transmute relies on the fact that the
// value of `reader` is `None` when we return in this branch.
// Otherwise the caller could poll us again after
// completion, and access the mutable reference while the
// returned immutable reference still exists.
let slice = std::mem::transmute::<&[u8], &'a [u8]>(slice); let slice = std::mem::transmute::<&[u8], &'a [u8]>(slice);
Poll::Ready(Ok(slice)) Poll::Ready(Ok(slice))
}, },