
Span::enter
and record
to take &self
(#1029)
## Motivation The `Span::enter` function previously required an `&mut` reference to enter a span. This is a relic of an earlier design where span closure logic was determined by dropping an inner span component, and is no longer strictly necessary. Requiring `&mut self` to enter a span leads to awkward patterns in cases when a user wishes to enter a span and then call methods on the span (such as recording field values). For example, we cannot say ```rust let mut span = span!("foo", bar); span.enter(|| { span.record("bar" &false); }); ``` since the span is mutably borrowed by `enter`. Instead, we must clone the span, like so: ```rust let mut span = span!("foo", bar); span.clone().enter(|| { span.record("bar" &false); }); ``` Having to clone the span is somewhat less ergonomic, and it has performance disadvantages as well: cloning a `Span` will clone the span's `Dispatch` handle, requiring an `Arc` bump, as well as calling the `Subscriber`'s `clone_span` and `drop_span` functions. If we can enter spans without a mutable borrow, we don't have to update any of these ref counts. The other reason we may wish to require mutable borrows to enter a span is if we want to disallow entering a span multiple times before exiting it. However, it is trivially possible to re-enter a span on the same thread regardless, by cloning the span and entering it twice. Besides, there may be a valuable semantic meaning in entering a span from inside itself, such as when a function is called recursively, so disallowing this is not a goal. ## Solution This branch rewrites the `Span::enter`, `Span::record`, and `Span::record_all` functions to no longer require mutable borrows. In the case of `record` and `record_all`, this was trivial, as borrowing mutably was not actually *necessary* for those functions. For `enter`, the `Entered` guard type was reworked to consist of an `&'a Inner` rather than an `Inner`, so it is no longer necessary to `take` the span's `Inner`. ## Notes In addition to allowing spans to be entered without mutable borrows, `Entered` was changed to exit the span automatically when the guard is dropped, so we may now observe correct span exits even when unwinding. Furthermore, this allows us to simplify the `enter` function a bit, leading to a minor performance improvement when entering spans. Before: ``` test enter_span ... bench: 13 ns/iter (+/- 1) ``` ...and after: ``` test enter_span ... bench: 3 ns/iter (+/- 1) ``` Note that this branch also contains a change to make the `subscriber::enter_span` benchmark more accurate. Previously, this benchmark constructed a new span inside of `b.iter(|| {...})`. This means that the benchmark was measuring not only the time taken to enter a span, but the time taken to construct a `Span` handle as well. However, we already have benchmarks for span construction, and the intention of this particular benchmark was to measure the overhead of constructing a span. I've updated the benchmark by moving the span construction out of the `iter` closure. Now, the span is constructed a single time and entered on every iteration. This allows us to measure only the overhead of actually entering a span. The "before" benchmark numbers above were recorded after backporting this change to master, so they are "fair" to the previous implementation. Prior to this change the benchmark took approximately 53 ns. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Tokio
A runtime for writing reliable, asynchronous, and slim applications with the Rust programming language. It is:
-
Fast: Tokio's zero-cost abstractions give you bare-metal performance.
-
Reliable: Tokio leverages Rust's ownership, type system, and concurrency model to reduce bugs and ensure thread safety.
-
Scalable: Tokio has a minimal footprint, and handles backpressure and cancellation naturally.
Website | Guides | API Docs | Chat
The API docs for the master branch are published here.
Overview
Tokio is an event-driven, non-blocking I/O platform for writing asynchronous applications with the Rust programming language. At a high level, it provides a few major components:
- A multithreaded, work-stealing based task scheduler.
- A reactor backed by the operating system's event queue (epoll, kqueue, IOCP, etc...).
- Asynchronous TCP and UDP sockets.
These components provide the runtime components necessary for building an asynchronous application.
Example
A basic TCP echo server with Tokio:
extern crate tokio;
use tokio::prelude::*;
use tokio::io::copy;
use tokio::net::TcpListener;
fn main() {
// Bind the server's socket.
let addr = "127.0.0.1:12345".parse().unwrap();
let listener = TcpListener::bind(&addr)
.expect("unable to bind TCP listener");
// Pull out a stream of sockets for incoming connections
let server = listener.incoming()
.map_err(|e| eprintln!("accept failed = {:?}", e))
.for_each(|sock| {
// Split up the reading and writing parts of the
// socket.
let (reader, writer) = sock.split();
// A future that echos the data and returns how
// many bytes were copied...
let bytes_copied = copy(reader, writer);
// ... after which we'll print what happened.
let handle_conn = bytes_copied.map(|amt| {
println!("wrote {:?} bytes", amt)
}).map_err(|err| {
eprintln!("IO error {:?}", err)
});
// Spawn the future as a concurrent task.
tokio::spawn(handle_conn)
});
// Start the Tokio runtime
tokio::run(server);
}
More examples can be found here.
Getting Help
First, see if the answer to your question can be found in the [Guides] or the [API documentation]. If the answer is not there, there is an active community in the Tokio Gitter channel. We would be happy to try to answer your question. Last, if that doesn't work, try opening an issue with the question.
Contributing
🎈 Thanks for your help improving the project! We are so happy to have you! We have a contributing guide to help you get involved in the Tokio project.
Project layout
The tokio
crate, found at the root, is primarily intended for use by
application developers. Library authors should depend on the sub crates, which
have greater guarantees of stability.
The crates included as part of Tokio are:
-
tokio-async-await
: Experimentalasync
/await
support. -
tokio-codec
: Utilities for encoding and decoding protocol frames. -
tokio-current-thread
: Schedule the execution of futures on the current thread. -
tokio-executor
: Task execution related traits and utilities. -
tokio-fs
: Filesystem (and standard in / out) APIs. -
tokio-io
: Asynchronous I/O related traits and utilities. -
tokio-reactor
: Event loop that drives I/O resources (like TCP and UDP sockets). -
tokio-tcp
: TCP bindings for use withtokio-io
andtokio-reactor
. -
tokio-threadpool
: Schedules the execution of futures across a pool of threads. -
tokio-timer
: Time related APIs. -
tokio-udp
: UDP bindings for use withtokio-io
andtokio-reactor
. -
tokio-uds
: Unix Domain Socket bindings for use withtokio-io
andtokio-reactor
.
Supported Rust Versions
Tokio is built against the latest stable, nightly, and beta Rust releases. The minimum version supported is the stable release from three months before the current stable release version. For example, if the latest stable Rust is 1.29, the minimum version supported is 1.26. The current Tokio version is not guaranteed to build on Rust versions earlier than the minimum supported version.
License
This project is licensed under the MIT license.
Contribution
Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in Tokio by you, shall be licensed as MIT, without any additional terms or conditions.