mirror of
https://github.com/tokio-rs/tokio.git
synced 2025-09-28 12:10:37 +00:00

* util: add track_caller to public APIs Functions that may panic can be annotated with `#[track_caller]` so that in the event of a panic, the function where the user called the panicking function is shown instead of the file and line within Tokio source. This change adds `#[track_caller]` to all the non-unstable public APIs in tokio-util where the documentation describes how the function may panic due to incorrect context or inputs. In one place, an assert was added where the described behavior appeared not to be implemented. The documentation for `DelayQueue::reserve` states that the function will panic if the new capacity exceeds the maximum number of entries the queue can contain. However, the function didn't panic until a higher number caused by an allocation failure. This is inconsistent with `DelayQueue::insert_at` which will panic if the number of entries were to go over MAX_ENTRIES. Tests are included to cover each potentially panicking function. Refs: #4413 * fix tests on FreeBSD 32-bit (I hope) Some tests were failing on FreeBSD 32-bit because the "times too far in the future" for DelayQueue were also too far in the future for the OS. Fixed by copying the MAX_DURATION value from where it's defined and using it to create a duration that is just 1 more than the maximum. This will start to break once we get close (within 2 and a bit years) of the Epochalypse (19 Jan, 2038) - but a lot of other things are going to be breaking on FreeBSD 32-bit by then anyway.
227 lines
6.1 KiB
Rust
227 lines
6.1 KiB
Rust
#![warn(rust_2018_idioms)]
|
|
#![cfg(feature = "full")]
|
|
|
|
use parking_lot::{const_mutex, Mutex};
|
|
use std::error::Error;
|
|
use std::panic;
|
|
use std::sync::Arc;
|
|
use tokio::runtime::Runtime;
|
|
use tokio::sync::mpsc::channel;
|
|
use tokio::time::{Duration, Instant};
|
|
use tokio_test::task;
|
|
use tokio_util::io::SyncIoBridge;
|
|
use tokio_util::sync::PollSender;
|
|
use tokio_util::task::LocalPoolHandle;
|
|
use tokio_util::time::DelayQueue;
|
|
|
|
// Taken from tokio-util::time::wheel, if that changes then
|
|
const MAX_DURATION_MS: u64 = (1 << (36)) - 1;
|
|
|
|
fn test_panic<Func: FnOnce() + panic::UnwindSafe>(func: Func) -> Option<String> {
|
|
static PANIC_MUTEX: Mutex<()> = const_mutex(());
|
|
|
|
{
|
|
let _guard = PANIC_MUTEX.lock();
|
|
let panic_file: Arc<Mutex<Option<String>>> = Arc::new(Mutex::new(None));
|
|
|
|
let prev_hook = panic::take_hook();
|
|
{
|
|
let panic_file = panic_file.clone();
|
|
panic::set_hook(Box::new(move |panic_info| {
|
|
let panic_location = panic_info.location().unwrap();
|
|
panic_file
|
|
.lock()
|
|
.clone_from(&Some(panic_location.file().to_string()));
|
|
}));
|
|
}
|
|
|
|
let result = panic::catch_unwind(func);
|
|
// Return to the previously set panic hook (maybe default) so that we get nice error
|
|
// messages in the tests.
|
|
panic::set_hook(prev_hook);
|
|
|
|
if result.is_err() {
|
|
panic_file.lock().clone()
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn sync_bridge_new_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let _ = SyncIoBridge::new(tokio::io::empty());
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn poll_sender_send_item_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let (send, _) = channel::<u32>(3);
|
|
let mut send = PollSender::new(send);
|
|
|
|
let _ = send.send_item(42);
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
|
|
fn local_pool_handle_new_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let _ = LocalPoolHandle::new(0);
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
|
|
fn local_pool_handle_spawn_pinned_by_idx_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
|
|
rt.block_on(async {
|
|
let handle = LocalPoolHandle::new(2);
|
|
handle.spawn_pinned_by_idx(|| async { "test" }, 3);
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
#[test]
|
|
fn delay_queue_insert_at_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
rt.block_on(async {
|
|
let mut queue = task::spawn(DelayQueue::with_capacity(3));
|
|
|
|
//let st = std::time::Instant::from(SystemTime::UNIX_EPOCH);
|
|
let _k = queue.insert_at(
|
|
"1",
|
|
Instant::now() + Duration::from_millis(MAX_DURATION_MS + 1),
|
|
);
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn delay_queue_insert_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
rt.block_on(async {
|
|
let mut queue = task::spawn(DelayQueue::with_capacity(3));
|
|
|
|
let _k = queue.insert("1", Duration::from_millis(MAX_DURATION_MS + 1));
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn delay_queue_remove_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
rt.block_on(async {
|
|
let mut queue = task::spawn(DelayQueue::with_capacity(3));
|
|
|
|
let key = queue.insert_at("1", Instant::now());
|
|
queue.remove(&key);
|
|
queue.remove(&key);
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn delay_queue_reset_at_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
rt.block_on(async {
|
|
let mut queue = task::spawn(DelayQueue::with_capacity(3));
|
|
|
|
let key = queue.insert_at("1", Instant::now());
|
|
queue.reset_at(
|
|
&key,
|
|
Instant::now() + Duration::from_millis(MAX_DURATION_MS + 1),
|
|
);
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn delay_queue_reset_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
rt.block_on(async {
|
|
let mut queue = task::spawn(DelayQueue::with_capacity(3));
|
|
|
|
let key = queue.insert_at("1", Instant::now());
|
|
queue.reset(&key, Duration::from_millis(MAX_DURATION_MS + 1));
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
fn delay_queue_reserve_panic_caller() -> Result<(), Box<dyn Error>> {
|
|
let panic_location_file = test_panic(|| {
|
|
let rt = basic();
|
|
rt.block_on(async {
|
|
let mut queue = task::spawn(DelayQueue::<u32>::with_capacity(3));
|
|
|
|
queue.reserve((1 << 30) as usize);
|
|
});
|
|
});
|
|
|
|
// The panic location should be in this file
|
|
assert_eq!(&panic_location_file.unwrap(), file!());
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn basic() -> Runtime {
|
|
tokio::runtime::Builder::new_current_thread()
|
|
.enable_all()
|
|
.build()
|
|
.unwrap()
|
|
}
|