itsscb/tower
1
0
Fork 0
mirror of https://github.com/tower-rs/tower.git synced 2025-11-03 23:13:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Copy editing building-a-middleware-from-scratch.md (#718)

Browse Source
This commit is contained in:
Jeffrey Hutchins 2023-01-31 11:42:19 -07:00 committed by GitHub
parent b01bb12ddd
commit 74881d5311
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
guides/building-a-middleware-from-scratch.md
View File

@ -323,7 +323,7 @@ where
// long and we have to return an error.
match this.sleep.poll(cx) {
Poll::Ready(()) => {
// Our time is up, but error do we return?!
// Our time is up, but what error do we return?!
todo!()
}
Poll::Pending => {
@ -377,7 +377,7 @@ and can use `match` to get at the exact error, the approach has three issues:
1. In practice its common to nest lots of middleware. That would make the final
error enum very large. Its not unlikely to look something like
`BufferError<RateLimitError<TimeoutError<MyError>>>`. Pattern matching on
such a type (to for example determine if the error is retry-able) is very
such a type (to, for example, determine if the error is retry-able) is very
tedious.
2. If we change the order our middleware are applied in we also change the final
error type meaning we have to update our pattern matches.