itsscb/tracing
1
0
Fork 0
mirror of https://github.com/tokio-rs/tracing.git synced 2025-09-28 13:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

subscriber: update tracing-core to v0.1.33 (#3201)

Browse Source 
The change #2954 was released in 0.3.19 (#3162).

Notably, it relied on features from tracing-core 0.1.33, however, the
version was never bumped. Users of the `tracing` feature of
`tracing-subscriber` would have no issue since it pulls in the higher
version transitively.

The specific feature used was implementing trait method `record_bytes`
from the `field::Visit` trait on `JsonVisitor` from the
tracing-subscriber json format module. (see linked #2945, or [ `impl
field::Visit for
JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491))

I believe this dependency mismatch requires users to manually select the
higher tracing-core version or suffer compilation failure.

This probably reflects some failure in how the tests utilize features
and intra-workspace dependencies, but, a resolution for that is beyond
my current comprehension of the project.
This commit is contained in:
Hayden Stainsby 2025-01-27 17:10:22 +01:00 committed by GitHub
parent 6240c95518
commit bfca5460e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tracing-subscriber/Cargo.toml
View File

@ -39,7 +39,7 @@ local-time = ["time/local-offset"]
nu-ansi-term = ["dep:nu-ansi-term"]
[dependencies]
tracing-core = { path = "../tracing-core", version = "0.1.30", default-features = false }
tracing-core = { path = "../tracing-core", version = "0.1.33", default-features = false }
# only required by the filter feature
tracing = { optional = true, path = "../tracing", version = "0.1.41", default-features = false }