From e080a03c5d879a01ec7bf34061867cf14da11913 Mon Sep 17 00:00:00 2001 From: Eliza Weisman Date: Thu, 16 Dec 2021 16:40:07 -0800 Subject: [PATCH] core: derive `Default` for `NoSubscriber` (#1785) * core: derive `Default` for `NoSubscriber` * additional clippy nonsense Signed-off-by: Eliza Weisman --- tracing-core/src/subscriber.rs | 8 +------- tracing-subscriber/src/field/mod.rs | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tracing-core/src/subscriber.rs b/tracing-core/src/subscriber.rs index b85bdc10..212e8760 100644 --- a/tracing-core/src/subscriber.rs +++ b/tracing-core/src/subscriber.rs @@ -568,15 +568,9 @@ impl Interest { /// /// [`NoSubscriber`] implements the [`Subscriber`] trait by never being enabled, /// never being interested in any callsite, and dropping all spans and events. -#[derive(Debug, Copy, Clone)] +#[derive(Copy, Clone, Debug, Default)] pub struct NoSubscriber(()); -impl Default for NoSubscriber { - fn default() -> Self { - NoSubscriber(()) - } -} - impl Subscriber for NoSubscriber { #[inline] fn register_callsite(&self, _: &'static Metadata<'static>) -> Interest { diff --git a/tracing-subscriber/src/field/mod.rs b/tracing-subscriber/src/field/mod.rs index f7d03f2c..1d6fcd2a 100644 --- a/tracing-subscriber/src/field/mod.rs +++ b/tracing-subscriber/src/field/mod.rs @@ -341,7 +341,7 @@ pub(in crate::field) mod test_util { impl<'a> Visit for DebugVisitor<'a> { fn record_debug(&mut self, field: &Field, value: &dyn fmt::Debug) { - write!(&mut self.writer, "{}={:?}", field, value).unwrap(); + write!(self.writer, "{}={:?}", field, value).unwrap(); } }