tracing

mirror of https://github.com/tokio-rs/tracing.git synced 2025-10-02 15:24:47 +00:00

History

subscriber: fix missing on_layer for Box/Arc layer impls (#1576 )

The `Layer::on_layer` method on `Layer` was added in PR #1523. PR #1536,
which added `Layer` implementations to `Box<dyn Layer<...> + ...>` and
`Arc<dyn Layer<...> + ...>`, merged prior to #1523. However, when
merging #1523, I didn't think to update the `Layer` impl for `Box`ed and
`Arc`ed layers to forward `on_layer` to the inner `Layer`. This means
that when a `Layer` is wrapped in an `Arc` or a `Box`, the `on_layer`
method never gets called.

When per-layer filters are in use, the `on_layer` method is necessary to
ensure the filter is registered with the inner subscriber and has a
valid ID. This bug means that when per-layer filters are wrapped in a
`Box` or `Arc`, they won't be registered, and per-layer filtering
breaks.

This PR fixes the bug by adding `on_layer` implementations to the
`Layer` impls for `Arc`ed and `Box`ed layers. I also added some tests
--- thanks to @Noah-Kennedy for the original repro that these were based
on (https://github.com/tokio-rs/tracing/issues/1563#issuecomment-922014777).

I also added a nicer debug assertion to `Filtered` for cases where
`Layer` impls don't call `on_layer`, so that this fails less confusingly
in the future.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>

2021-09-17 14:25:57 -07:00

layer_filters

subscriber: fix missing on_layer for Box/Arc layer impls (#1576 )

2021-09-17 14:25:57 -07:00

cached_layer_filters_dont_break_other_layers.rs

subscriber: implement per-layer filtering (#1523 )

2021-09-09 14:06:38 -07:00

duplicate_spans.rs

subscriber: add feature flags to tests (#1532 )

2021-09-02 10:43:34 -07:00

field_filter.rs

subscriber: add feature flags to tests (#1532 )