mirror of
https://github.com/tokio-rs/tracing.git
synced 2025-09-28 21:42:15 +00:00
d2f47f1e3f
## Motivation Clippy check fails in recent CI runs in v0.1.x branch PRs, for example this run: https://github.com/tokio-rs/tracing/actions/runs/4641107803/jobs/8215263838 Relevant error logs: ``` error: lint `const_err` has been removed: converted into hard error, see issue #71800 <https://github.com/rust-lang/rust/issues/71800> for more information --> tracing-core/src/lib.rs:132:5 | 132 | const_err, | ^^^^^^^^^ | = note: `-D renamed-and-removed-lints` implied by `-D warnings` error: deref which would be done by auto-deref --> tracing-core/src/dispatcher.rs:371:26 | 371 | return f(&*entered.current()); | ^^^^^^^^^^^^^^^^^^^ help: try this: `&entered.current()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` error: deref which would be done by auto-deref --> tracing-core/src/dispatcher.rs:393:20 | 393 | Some(f(&*entered.current())) | ^^^^^^^^^^^^^^^^^^^ help: try this: `&entered.current()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref ``` ## Solution Fix the warnings based on the suggestions for Clippy.
99 lines
3.2 KiB
Plaintext
99 lines
3.2 KiB
Plaintext
error[E0308]: mismatched types
|
|
--> tests/ui/async_instrument.rs:5:5
|
|
|
|
|
5 | ""
|
|
| ^^ expected `()`, found `&str`
|
|
|
|
|
note: return type inferred to be `()` here
|
|
--> tests/ui/async_instrument.rs:4:10
|
|
|
|
|
4 | async fn unit() {
|
|
| ^^^^
|
|
|
|
error[E0308]: mismatched types
|
|
--> tests/ui/async_instrument.rs:10:5
|
|
|
|
|
10 | ""
|
|
| ^^- help: try using a conversion method: `.to_string()`
|
|
| |
|
|
| expected struct `String`, found `&str`
|
|
|
|
|
note: return type inferred to be `String` here
|
|
--> tests/ui/async_instrument.rs:9:31
|
|
|
|
|
9 | async fn simple_mismatch() -> String {
|
|
| ^^^^^^
|
|
|
|
error[E0277]: `(&str,)` doesn't implement `std::fmt::Display`
|
|
--> tests/ui/async_instrument.rs:14:1
|
|
|
|
|
14 | #[tracing::instrument]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ `(&str,)` cannot be formatted with the default formatter
|
|
|
|
|
= help: the trait `std::fmt::Display` is not implemented for `(&str,)`
|
|
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
|
|
= note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
error[E0277]: `(&str,)` doesn't implement `std::fmt::Display`
|
|
--> tests/ui/async_instrument.rs:15:34
|
|
|
|
|
15 | async fn opaque_unsatisfied() -> impl std::fmt::Display {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ `(&str,)` cannot be formatted with the default formatter
|
|
|
|
|
= help: the trait `std::fmt::Display` is not implemented for `(&str,)`
|
|
= note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
|
|
|
|
error[E0308]: mismatched types
|
|
--> tests/ui/async_instrument.rs:23:5
|
|
|
|
|
23 | ""
|
|
| ^^ expected struct `Wrapper`, found `&str`
|
|
|
|
|
= note: expected struct `Wrapper<_>`
|
|
found reference `&'static str`
|
|
note: return type inferred to be `Wrapper<_>` here
|
|
--> tests/ui/async_instrument.rs:22:36
|
|
|
|
|
22 | async fn mismatch_with_opaque() -> Wrapper<impl std::fmt::Display> {
|
|
| ^^^^^^^
|
|
help: try wrapping the expression in `Wrapper`
|
|
|
|
|
23 | Wrapper("")
|
|
| ++++++++ +
|
|
|
|
error[E0308]: mismatched types
|
|
--> tests/ui/async_instrument.rs:29:16
|
|
|
|
|
29 | return "";
|
|
| ^^ expected `()`, found `&str`
|
|
|
|
|
note: return type inferred to be `()` here
|
|
--> tests/ui/async_instrument.rs:27:10
|
|
|
|
|
27 | async fn early_return_unit() {
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
error[E0308]: mismatched types
|
|
--> tests/ui/async_instrument.rs:36:16
|
|
|
|
|
36 | return "";
|
|
| ^^- help: try using a conversion method: `.to_string()`
|
|
| |
|
|
| expected struct `String`, found `&str`
|
|
|
|
|
note: return type inferred to be `String` here
|
|
--> tests/ui/async_instrument.rs:34:28
|
|
|
|
|
34 | async fn early_return() -> String {
|
|
| ^^^^^^
|
|
|
|
error[E0308]: mismatched types
|
|
--> tests/ui/async_instrument.rs:42:35
|
|
|
|
|
42 | async fn extra_semicolon() -> i32 {
|
|
| ___________________________________^
|
|
43 | | 1;
|
|
| | - help: remove this semicolon to return this value
|
|
44 | | }
|
|
| |_^ expected `i32`, found `()`
|