owo-colors has a potential soundness bug, which I'm attempting to fix in
https://github.com/jam1garner/owo-colors/pull/131. However, a lot of
crates rely on the 3.x series, which may not get patched. Preemptively
updating them, would appreciate a release!!
Good day, dear eyre contributors.
I really like to use eyre in all my projects. Right now I use master to
stay on 1.0 version.
Unfortunately when I want to start using color-eyre the same way it
conflicts with eyre, because it uses 0.6.1 version.
What this PR addresses is to temporary set color-eyre -> eyre dependency
via path, not a version, until 1.0 will be released.
If it's not something you want to have in the codebase, just please let
me know, I will then switch to my fork and keep it sync with the main
repo. Thank you in advance, you are awesome! 💜
The word "developer" appears at the end of a sentence and it doesn't
make sense at all in that context. Maybe you meant to say "while
developing" but i just removed it entirely.
This addresses the invalid compile probe testing for a non-longer
existing feature by updating it and eyre to use the
`error_generic_member_access` features instead.
The report and errors have all been updated to accomodate this and the
new backtrace provide API
Fixes: #84 and #97
Remove structs that are unused and have been migrated to use the eyre
versions of the same:
- color_eyre::config::InstallError -> eyre::InstallError
- color_eyre::config::InstallThemeError -> eyre::InstallThemeError
- color_eyre::config::InstallColorSpantraceThemeError -> no equivalent
Add cfg guards to the DisplayExt, FooterWriter, Footer, and Header
to prevent unused warnings when the issue-url feature is not enabled.
The lint group is `clippy::suspicious`, not `clippy::suspiscious`
https://github.com/eyre-rs/eyre/actions/runs/9112483886/job/25051828362#step:5:176
```
warning[E0602]: unknown lint: `clippy::suspiscious`
Warning: |
= help: did you mean: `clippy::suspicious`
= note: requested on the command line with `-D clippy::suspiscious`
= note: `#[warn(unknown_lints)]` on by default
```
Deny style, suspicious and complexity categories, rather than all
warnings
If we find issues that could have been caught by a clippy lint we can
add that lint on as *deny* too, as for now, they still appear as
warnings but won't prevent CI from running.
This most notably fixes random CI breakages when clippy/rust updates and
introduces new warn level lints
Fixes#169
Besides enclosing inline code in backticks, I also made two tiny
documentation improvements - please let me know if you want them undone:
- In the `Report::msg` docs, the user is referred to `Report::new`. I
changed this from plain inline code into a link.
- I expanded _"`Display` impl"_ to _"`Display` implementation"_, since
`impl` is a Rust token, but
- _"`Display` `impl`"_ looked silly, and
- _"`impl Display`"_ disturbed the flow of reading.
Co-authored-by: Jane Losare-Lusby <jlusby@yaah.dev>
This addresses the invalid compile probe testing for a non-longer
existing feature by updating it and eyre to use the
`error_generic_member_access` features instead.
The report and errors have all been updated to accomodate this and the
new backtrace provide API
Fixes: #84 and #97
Since almost all files not on our gitignore are text files, it uses `*
text` as a catch-all and specifies *.png as binary.
Co-authored-by: Jane Losare-Lusby <jlusby@yaah.dev>
Applies the same fixes that was applied to `color-eyre-0.6` to master,
namely the new update to `trybuild` that breaks our MSRV requirement,
requiring us to pin the version, as the dependency only bumped the patch
version for the updated MRSV.
It also fixes the theme test breaking on windows due to new
*before-main* machinery on windows affecting the backtrace. This is
fixed by filtering out the functions before and including main(due to no
take_until iter adapter in std), but still includes the panicking
function call.
There are currently three branches that need/needed this fix
- master: containing latest breaking code for 1.0
- color-eyre-0.6
- release-0.6 (does not include the theme test change as color-eyre is
not present there)
1. Remove the conditional trait methods `context` and `with_context`
from `WrapErr`
2. Remove ambiguity between "wrapping errors" with another, and
converting a `None` value to an error.
The anyhow compatibility methods (`context` and `with_context`) were
introduced as conditional required methods for the trait `WrapErr`, as
well as another separate trait `ContextCompat`, implemented for options
*and* results.
The latter trait also provided methods `wrap_err` and `wrap_err_with`.
This led to confusion as the two distinct traits had the same methods,
one was implemented on results, and the other on both options and
results.
Furthermore, wrapping options does not align with our error model where
errors are wrapped around other errors; an error wrapping `None` should
just be a single error and should not be wrapped.
See: #149
# 1. Clarify trait usage in location test
[`8522f02`](8522f02518)
Both `WrapErr` and `ContextCompat` expose `anyhow` compatibility
methods.
- `ContextCompat` is completely feature gated behind the `anyhow` flag.
- `WrapErr`, on the other hand, feature-gates individual functions
behind the `anyhow` flag.
This has led to [confusion][confusion] in the past.
This change moves the `use eyre::WrapErr` statement from the top of the
module into each individual test, as [identically named
functions](https://github.com/eyre-rs/eyre/issues/149) (`wrap_err.*`)
are exposed both by `WrapErr` and `ContextCompat`.
With `use eyre::WrapErr` moved directly into the tests, it becomes clear
which trait-provided `fn` is being called.
[confusion]:
https://github.com/eyre-rs/eyre/pull/138#discussion_r1432909562
# 2. Remove `anyhow` feature flag from `OptionExt` location test
[`68744f1`](68744f19fb)
This bug was introduced (by me) in
34bd1d9893 (diff-1ff47dac6cf55e34ff587968c5b1f1ec6b6ae39d2668a66ecba3633163a21fc5R86)
- partly due to the confusion fixed with the above commit.
Fixes https://github.com/eyre-rs/eyre/issues/147
This change hides the `anyhow` compatibility layer behind an `"anyhow"`
feature flag.
In `eyre` v1.0.0 the feature is currently enabled by default.
Fixes#131
---------
Co-authored-by: Freja Roberts <ten3roberts@gmail.com>
