warning: variables can be used directly in the `format!` string
--> src/ser.rs:448:15
|
448 | match write!(adapter, "{}", value) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
448 - match write!(adapter, "{}", value) {
448 + match write!(adapter, "{value}") {
|
warning: variables can be used directly in the `format!` string
--> src/value/mod.rs:182:37
|
182 | Value::Bool(boolean) => write!(formatter, "Bool({})", boolean),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
182 - Value::Bool(boolean) => write!(formatter, "Bool({})", boolean),
182 + Value::Bool(boolean) => write!(formatter, "Bool({boolean})"),
|
warning: variables can be used directly in the `format!` string
--> src/value/mod.rs:184:38
|
184 | Value::String(string) => write!(formatter, "String({:?})", string),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
184 - Value::String(string) => write!(formatter, "String({:?})", string),
184 + Value::String(string) => write!(formatter, "String({string:?})"),
|
warning: variables can be used directly in the `format!` string
--> src/number.rs:365:9
|
365 | write!(formatter, "Number({})", self)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
365 - write!(formatter, "Number({})", self)
365 + write!(formatter, "Number({self})")
|
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:274:21
|
274 | pub fn entry<S>(&mut self, key: S) -> Entry
| ^^^^^^^^^ ----- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
274 | pub fn entry<S>(&mut self, key: S) -> Entry<'_>
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:303:17
|
303 | pub fn iter(&self) -> Iter {
| ^^^^^ ---- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
303 | pub fn iter(&self) -> Iter<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:311:21
|
311 | pub fn iter_mut(&mut self) -> IterMut {
| ^^^^^^^^^ ------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
311 | pub fn iter_mut(&mut self) -> IterMut<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:319:17
|
319 | pub fn keys(&self) -> Keys {
| ^^^^^ ---- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
319 | pub fn keys(&self) -> Keys<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:327:19
|
327 | pub fn values(&self) -> Values {
| ^^^^^ ------ the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
327 | pub fn values(&self) -> Values<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:335:23
|
335 | pub fn values_mut(&mut self) -> ValuesMut {
| ^^^^^^^^^ --------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
335 | pub fn values_mut(&mut self) -> ValuesMut<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/value/de.rs:1388:19
|
1388 | fn unexpected(&self) -> Unexpected {
| ^^^^^ ---------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
1388 | fn unexpected(&self) -> Unexpected<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/number.rs:798:30
|
798 | pub(crate) fn unexpected(&self) -> Unexpected {
| ^^^^^ ---------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
798 | pub(crate) fn unexpected(&self) -> Unexpected<'_> {
| ++++
warning: calling .bytes() is very inefficient when data is not in memory
--> src/read.rs:202:40
|
202 | iter: LineColIterator::new(reader.bytes()),
| ^^^^^^^^^^^^^^
|
= help: consider using `BufReader`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes
= note: `-W clippy::unbuffered-bytes` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unbuffered_bytes)]`
warning: the following explicit lifetimes could be elided: 'a
--> src/de.rs:2189:11
|
2189 | impl<'de, 'a, R> MapKey<'a, R>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
= note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]`
help: elide the lifetimes
|
2189 - impl<'de, 'a, R> MapKey<'a, R>
2189 + impl<'de, R> MapKey<'_, R>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/de.rs:2196:11
|
2196 | impl<'de, 'a, R> de::Deserializer<'de> for MapKey<'a, R>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
2196 - impl<'de, 'a, R> de::Deserializer<'de> for MapKey<'a, R>
2196 + impl<'de, R> de::Deserializer<'de> for MapKey<'_, R>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/error.rs:467:6
|
467 | impl<'a> Display for JsonUnexpected<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
467 - impl<'a> Display for JsonUnexpected<'a> {
467 + impl Display for JsonUnexpected<'_> {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/map.rs:601:6
|
601 | impl<'de> de::IntoDeserializer<'de, Error> for Map<String, Value> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
601 - impl<'de> de::IntoDeserializer<'de, Error> for Map<String, Value> {
601 + impl de::IntoDeserializer<'_, Error> for Map<String, Value> {
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:31:6
|
31 | impl<'a, W> Serializer<W, PrettyFormatter<'a>>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
31 - impl<'a, W> Serializer<W, PrettyFormatter<'a>>
31 + impl<W> Serializer<W, PrettyFormatter<'_>>
|
warning: the following explicit lifetimes could be elided: 'ser
--> src/ser.rs:420:14
|
420 | impl<'ser, W, F> Write for Adapter<'ser, W, F>
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
420 - impl<'ser, W, F> Write for Adapter<'ser, W, F>
420 + impl<W, F> Write for Adapter<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:480:6
|
480 | impl<'a, W, F> ser::SerializeSeq for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
480 - impl<'a, W, F> ser::SerializeSeq for Compound<'a, W, F>
480 + impl<W, F> ser::SerializeSeq for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:527:6
|
527 | impl<'a, W, F> ser::SerializeTuple for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
527 - impl<'a, W, F> ser::SerializeTuple for Compound<'a, W, F>
527 + impl<W, F> ser::SerializeTuple for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:549:6
|
549 | impl<'a, W, F> ser::SerializeTupleStruct for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
549 - impl<'a, W, F> ser::SerializeTupleStruct for Compound<'a, W, F>
549 + impl<W, F> ser::SerializeTupleStruct for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:571:6
|
571 | impl<'a, W, F> ser::SerializeTupleVariant for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
571 - impl<'a, W, F> ser::SerializeTupleVariant for Compound<'a, W, F>
571 + impl<W, F> ser::SerializeTupleVariant for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:609:6
|
609 | impl<'a, W, F> ser::SerializeMap for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
609 - impl<'a, W, F> ser::SerializeMap for Compound<'a, W, F>
609 + impl<W, F> ser::SerializeMap for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:681:6
|
681 | impl<'a, W, F> ser::SerializeStruct for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
681 - impl<'a, W, F> ser::SerializeStruct for Compound<'a, W, F>
681 + impl<W, F> ser::SerializeStruct for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:727:6
|
727 | impl<'a, W, F> ser::SerializeStructVariant for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
727 - impl<'a, W, F> ser::SerializeStructVariant for Compound<'a, W, F>
727 + impl<W, F> ser::SerializeStructVariant for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:793:6
|
793 | impl<'a, W, F> ser::Serializer for MapKeySerializer<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
793 - impl<'a, W, F> ser::Serializer for MapKeySerializer<'a, W, F>
793 + impl<W, F> ser::Serializer for MapKeySerializer<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:1979:6
|
1979 | impl<'a> Default for PrettyFormatter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
1979 - impl<'a> Default for PrettyFormatter<'a> {
1979 + impl Default for PrettyFormatter<'_> {
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:1985:6
|
1985 | impl<'a> Formatter for PrettyFormatter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
1985 - impl<'a> Formatter for PrettyFormatter<'a> {
1985 + impl Formatter for PrettyFormatter<'_> {
|
warning: the following explicit lifetimes could be elided: 'a, 'b
--> src/value/mod.rs:227:14
|
227 | impl<'a, 'b> io::Write for WriterFormatter<'a, 'b> {
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
227 - impl<'a, 'b> io::Write for WriterFormatter<'a, 'b> {
227 + impl io::Write for WriterFormatter<'_, '_> {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/value/de.rs:526:6
|
526 | impl<'de> IntoDeserializer<'de, Error> for Value {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
526 - impl<'de> IntoDeserializer<'de, Error> for Value {
526 + impl IntoDeserializer<'_, Error> for Value {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/value/de.rs:1343:6
|
1343 | impl<'de> Visitor<'de> for KeyClassifier {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
1343 - impl<'de> Visitor<'de> for KeyClassifier {
1343 + impl Visitor<'_> for KeyClassifier {
|
warning: the following explicit lifetimes could be elided: 'a
--> src/value/index.rs:146:6
|
146 | impl<'a> Display for Type<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
146 - impl<'a> Display for Type<'a> {
146 + impl Display for Type<'_> {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/number.rs:403:14
|
403 | impl<'de> Visitor<'de> for NumberVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
403 - impl<'de> Visitor<'de> for NumberVisitor {
403 + impl Visitor<'_> for NumberVisitor {
|
warning: the following explicit lifetimes could be elided: 'b, 'c
--> src/read.rs:132:6
|
132 | impl<'b, 'c, T> Deref for Reference<'b, 'c, T>
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
132 - impl<'b, 'c, T> Deref for Reference<'b, 'c, T>
132 + impl<T> Deref for Reference<'_, '_, T>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:541:6
|
541 | impl<'a> private::Sealed for SliceRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
541 - impl<'a> private::Sealed for SliceRead<'a> {}
541 + impl private::Sealed for SliceRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:679:6
|
679 | impl<'a> private::Sealed for StrRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
679 - impl<'a> private::Sealed for StrRead<'a> {}
679 + impl private::Sealed for StrRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:833:6
|
833 | impl<'a> Fused for SliceRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
833 - impl<'a> Fused for SliceRead<'a> {}
833 + impl Fused for SliceRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:834:6
|
834 | impl<'a> Fused for StrRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
834 - impl<'a> Fused for StrRead<'a> {}
834 + impl Fused for StrRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'de
--> tests/regression/issue845.rs:12:6
|
12 | impl<'de, T> serde:🇩🇪:Visitor<'de> for NumberVisitor<T>
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
= note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]`
help: elide the lifetimes
|
12 - impl<'de, T> serde:🇩🇪:Visitor<'de> for NumberVisitor<T>
12 + impl<T> serde:🇩🇪:Visitor<'_> for NumberVisitor<T>
|
The original read_user_from_stream function from PR 1237 is a bad
pattern because it results in silently dropping any data left in the
buffer on return. If we want to read anything else from the same
TcpStream after the JSON object, the buffer needs to go in the caller.
