A4-Tacks
258776b63a
Migrate expand_record_rest_pattern assist to use SyntaxEditor
...
Because `add_field` uses `ted`
2025-09-23 12:14:14 +08:00
Shoyu Vanilla (Flint)
c1499a2381
Merge pull request #20679 from A4-Tacks/no-comp-ty-in-nested-pat
...
Fix complete type in nested pattern
2025-09-22 15:37:39 +00:00
Shoyu Vanilla (Flint)
d6e14cc457
Merge pull request #20722 from A4-Tacks/pull-assign-up-inner-if
...
Fix apply in inner if for pull_assignment_up
2025-09-22 15:31:10 +00:00
Shoyu Vanilla (Flint)
b465ae054a
Merge pull request #20723 from A4-Tacks/fix-bind-unused-applicable-underscore
...
Fix applicable on underscore for bind_unused_param
2025-09-22 15:29:47 +00:00
Shoyu Vanilla (Flint)
3249fc76b2
Merge pull request #20725 from ChayimFriedman2/fix-missing-lifetime
...
fix: Fix lifetime elision handling for `Fn`-style trait bounds
2025-09-22 15:21:19 +00:00
Chayim Refael Friedman
7d9af9f6a5
Merge pull request #20717 from ShoyuVanilla/migrate-more
...
internal: Migrate more predicate things to next-solver
2025-09-22 14:55:32 +00:00
Shoyu Vanilla
0a5457a392
internal: Migrate more predicate things to next-solver
2025-09-22 23:44:50 +09:00
Chayim Refael Friedman
ad9422da1a
Fix lifetime elision handling for Fn-style trait bounds
...
Two fixes were needed:
1. Previously, we enabled elision for the generic args of `Fn` itself, instead of for generic args of paths within it.
2. In lowering in the new solver the `Output` parameter did not have elision set correctly, I don't know why. In the old lowering it was done correctly.
2025-09-22 16:53:20 +03:00
Chayim Refael Friedman
83981c14aa
Merge pull request #20724 from ChayimFriedman2/ns-cleanup3
...
minor: Another regression test for next solver fixed bug
2025-09-22 07:36:56 +00:00
Chayim Refael Friedman
d5f597e726
Another regression test for next solver fixed bug
2025-09-22 10:26:03 +03:00
A4-Tacks
fef1ab5d71
Fix applicable on underscore for bind_unused_param
...
Fixes:
- applicable on underscore prefix parameter
- using binding mode as an expression
Examples
---
```rust
fn foo($0_x: i32, y: i32) {}
```
**Before this PR**:
```rust
fn foo(_x: i32, y: i32) {
let _ = _x;
}
```
**After this PR**:
Assist not applicable
---
```rust
fn foo(ref $0y: i32) {}
```
**Before this PR**:
```rust
fn foo(ref y: i32) {
let _ = ref y;
}
```
**After this PR**:
```rust
fn foo(ref y: i32) {
let _ = y;
}
```
2025-09-22 15:13:13 +08:00
A4-Tacks
23535a6646
Fix apply in internal if for pull_assignment_up
...
Example
---
```rust
fn foo() {
let mut a = 1;
if true {
a = 2;
} else if true {
$0a = 3;
} else {
a = 4;
}
}
```
**Before this PR**:
```rust
fn foo() {
let mut a = 1;
if true {
a = 2;
} else a = if true {
3
} else {
4
};
}
```
**After this PR**:
```rust
fn foo() {
let mut a = 1;
a = if true {
2
} else if true {
3
} else {
4
};
}
```
2025-09-22 14:32:46 +08:00
Chayim Refael Friedman
f41f762a80
Merge pull request #20718 from ChayimFriedman2/inlay-max-len-docs
...
minor: Clarify `rust-analyzer.inlayHints.maxLength` is not a hard guarantee
2025-09-22 01:27:15 +00:00
Chayim Refael Friedman
129d9f7af6
Clarify rust-analyzer.inlayHints.maxLength is not a hard guarantee
2025-09-22 04:16:50 +03:00
Shoyu Vanilla (Flint)
e7d7cb415a
Merge pull request #20714 from A4-Tacks/rm-dbg-trailing-comma
...
Fix not applicable on trailing comma for remove_dbg
2025-09-21 06:48:17 +00:00
A4-Tacks
168ca55a99
Fix not applicable on trailing comma for remove_dbg
...
`remove_dbg` not applicable for whitespaces after trailing comma
Example
---
```rust
fn foo() {
dbg!(
bar(),
);
}
```
**Before this PR**:
Assist not applicable
**After this PR**:
```rust
fn foo() {
bar();
}
```
2025-09-21 11:05:10 +08:00
Shoyu Vanilla (Flint)
187917fa5d
Merge pull request #20706 from A4-Tacks/stdx-replace-inplace
...
Fix to implements in-place stdx::replace
2025-09-20 13:32:39 +00:00
A4-Tacks
29de96c4e0
Add some test for stdx::replace
2025-09-20 21:15:12 +08:00
Shoyu Vanilla (Flint)
a003d4d127
Merge pull request #20661 from A4-Tacks/suggest-if-body
...
Fix IfExpr branches suggests
2025-09-20 13:08:01 +00:00
A4-Tacks
48dc150f31
Fix to implements in-place stdx::replace
2025-09-20 20:58:44 +08:00
A4-Tacks
07f33e2b81
Fix IfExpr then branch suggest
...
- And add logic operation suggest
Example
---
In the old implementation, it always suggested conditions,
this is a lot of noise, e.g `contract_checks()~(use std::intrinsics::contract_checks) const fn() -> bool`
```rust
fn foo() {
if true {
c$0
}
}
```
2025-09-20 20:56:27 +08:00
Shoyu Vanilla (Flint)
3705f71df9
Merge pull request #20710 from A4-Tacks/unused-var-shorthand
...
Fix unused_variables fixes shorthand record field
2025-09-20 12:54:34 +00:00
Shoyu Vanilla (Flint)
6d5bfaee6a
Merge pull request #20709 from A4-Tacks/destruct-panic-on-not-add-deref-and-paren
...
Fix panic `!self.data().mutable` for destructure_struct_binding
2025-09-20 12:41:21 +00:00
Shoyu Vanilla (Flint)
da47c3da45
Merge pull request #20686 from A4-Tacks/gen-default-not-apply-selected
...
Fix selected applicable generate_default_from_enum_variant
2025-09-20 12:40:50 +00:00
David Barsky
a196eba3eb
Merge pull request #20689 from ShoyuVanilla/accurate-flycheck
...
fix: Make flycheck clearing dependency-aware
2025-09-20 12:33:39 +00:00
A4-Tacks
d6c66dff1d
Fix selected multi variants applicable generate_default_from_enum_variant
2025-09-20 20:29:02 +08:00
Shoyu Vanilla (Flint)
259a01d73d
Merge pull request #20688 from A4-Tacks/fix-applicable-after-l-curly-replace-is-method-with-if-let
...
Fix applicable after l_curly for replace_is_method_with_if_let_method
2025-09-20 12:06:18 +00:00
Shoyu Vanilla (Flint)
84bb4051bf
Merge pull request #20700 from A4-Tacks/extract-var-let-expr
...
Fix extract_variable on LetExpr
2025-09-20 11:59:20 +00:00
Shoyu Vanilla (Flint)
a943034d68
Merge pull request #20702 from A4-Tacks/else-not-before-else
...
Fix `else` completion before else keyword
2025-09-20 11:57:07 +00:00
Shoyu Vanilla (Flint)
81ea457fc5
Merge pull request #20708 from A4-Tacks/destruct-ref-mut-panics
...
Fix panics on `Foo{mut x}` for destructure_struct_binding
2025-09-20 11:54:47 +00:00
A4-Tacks
a41ca500b0
Fix unused_variables fixes shorthand record field
...
Example
---
```rust
struct S { field : u32 }
fn main() {
let s = S { field : 2 };
let S { $0field } = s
}
```
**Before this PR**:
```rust
struct S { field : u32 }
fn main() {
let s = S { field : 2 };
let S { _field } = s
}
```
**After this PR**:
```rust
struct S { field : u32 }
fn main() {
let s = S { field : 2 };
let S { field: _field } = s
}
```
2025-09-20 18:25:28 +08:00
A4-Tacks
f34e9ca8d3
Fix panic !self.data().mutable for destructure_struct_binding
...
When the reference type does not require adding a dereference or parentheses, it will panic
Example
---
```rust
struct Foo { bar: i32, baz: i32 }
fn main() {
let $0foo = &Foo { bar: 1, baz: 2 };
let _ = &foo.bar;
}
```
**Before this PR**:
Panic:
```
assertion failed: !self.data().mutable
```
**After this PR**:
```rust
struct Foo { bar: i32, baz: i32 }
fn main() {
let Foo { bar, baz } = &Foo { bar: 1, baz: 2 };
let _ = bar;
}
```
2025-09-20 17:52:01 +08:00
A4-Tacks
d4731ad9e2
Fix panics on Foo{mut x} for destructure_struct_binding
...
Example
---
```rust
struct Foo { x: () }
struct Bar { foo: Foo }
fn f(Bar { mut $0foo }: Bar) {}
```
**Before this PR**:
Panic `Option::unwrap`
**After this PR**:
```rust
struct Foo { x: () }
struct Bar { foo: Foo }
fn f(Bar { foo: Foo { mut x } }: Bar) {}
```
2025-09-20 16:14:51 +08:00
Laurențiu Nicola
0c62c01aae
Merge pull request #20707 from lnicola/bump-rustc
...
minor: Bump rustc crates once more
2025-09-20 06:50:11 +00:00
Laurențiu Nicola
4599670308
Bump rustc crates once more
2025-09-20 09:38:53 +03:00
Shoyu Vanilla
de3ad58b73
fix: Make flycheck clearing dependency-aware
2025-09-20 01:35:35 +09:00
Chayim Refael Friedman
b12a129347
Merge pull request #20701 from A4-Tacks/track-caller-assist-test
...
Add `#[track_caller]` for check_assist_by_label
2025-09-19 15:07:17 +00:00
Shoyu Vanilla (Flint)
2c6f0fc0df
Merge pull request #20697 from Oblarg/fix-negative-const-generic-literals
...
fix negative const generic integer literals
2025-09-19 14:13:54 +00:00
Oblarg
30031b84a8
address review feedback
2025-09-19 10:03:14 -04:00
Laurențiu Nicola
adf6c0d976
Merge pull request #20703 from ShoyuVanilla/remove-chalk-solve
...
minor: Get rid of unused deps `chalk-solve` and `chalk-recursive`
2025-09-19 13:47:35 +00:00
Shoyu Vanilla
3b4f5fbd73
minor: Get rid of unused deps chalk-solve and chalk-recursive
2025-09-19 22:35:46 +09:00
A4-Tacks
c976f9900d
Fix else completion before else keyword
...
Example
---
```rust
fn foo() {
let x = if true {
1
} el$0 else {
2
};
}
```
**Before this PR**:
```text
else~ k [LS]
else if~ k [LS]
```
**After this PR**:
```text
else if~ k [LS]
```
2025-09-19 19:59:47 +08:00
A4-Tacks
42bba767ef
Add #[track_caller] for check_assist_by_label
2025-09-19 13:39:45 +08:00
A4-Tacks
3610cb12f7
Fix extract_variable on LetExpr
...
Example
---
```rust
fn main() {
if $0let$0 Some(x) = Some(2+2) {}
}
```
**Before this PR**:
```rust
fn main() {
let $0var_name = let Some(x) = Some(2+2);
if var_name {}
}
```
**After this PR**:
```rust
fn main() {
let $0var_name = Some(2+2);
if let Some(x) = var_name {}
}
```
2025-09-19 13:35:34 +08:00
Laurențiu Nicola
50bb3c5d82
Merge pull request #20699 from lnicola/ena-fingerprint
...
minor: Set `WithCachedTypeInfo::stable_hash` when in-tree
2025-09-19 05:20:01 +00:00
Laurențiu Nicola
5a643b8158
Set WithCachedTypeInfo::stable_hash when in-tree
2025-09-19 08:08:23 +03:00
Oblarg
d0bdedde0e
fix negative const generic integer literals
2025-09-18 18:55:13 -04:00
Shoyu Vanilla (Flint)
958a8d06e3
Merge pull request #20695 from ShoyuVanilla/fix-another-in-tree
...
fix: Fix one more thing in `in-rust-tree`
2025-09-18 19:34:53 +00:00
Shoyu Vanilla
a04f5185b1
fix: Fix one more thing in in-rust-tree
2025-09-19 04:20:24 +09:00
Laurențiu Nicola
e6c3152214
Merge pull request #20694 from ShoyuVanilla/bump-rustc
...
minor: Yet another rustc crates bump
2025-09-18 18:38:03 +00:00
