itsscb/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-10-02 10:18:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
200,122 Commits 11 Branches 149 Tags
Commit Graph

200122 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Goulet
14ff4cc94a Format type_of 
(cherry picked from commit cca48285b87e44f34788773eef520f9e3f9b20c9)
 2022-10-06 10:07:34 -07:00
BlackHoleFox
3d501fb2be Revert "Use getentropy when possible on all Apple platforms" 
This reverts commit 3fc35b5b935e390c61ea2bbf744838b2632b2df1.

(cherry picked from commit a955ef2c8c95a289f0753e533b690c576b1806bf)
 2022-10-06 07:56:13 -07:00
Ding Xiang Fei
cbcd6a1249 fix doc and dedup diverge_cleanup 
(cherry picked from commit 565c35aa5c3c39626fcd332bafbd8936b70ed989)
 2022-10-05 16:51:42 -07:00
X
149b8ad25b use build-pass for the test 
(cherry picked from commit 5131e9db07fb6cd158cf5bf2aa9fefbad3af1d2b)
 2022-10-05 16:51:42 -07:00
X
3a6527483e apply suggestion 
Co-authored-by: SafariMonkey <charlton.rodda@gmail.com>
(cherry picked from commit fb52dc7c3b7cc5170d5096931827a0169fd65eb5)
 2022-10-05 16:51:42 -07:00
Ding Xiang Fei
82cca232cf fix unwind drop glue for if-then scopes 
(cherry picked from commit 4a2c1a12b662eb590dbe78f7f9d13c2f327d3bb6)
 2022-10-05 16:51:39 -07:00
Guillaume Gomez
1e14fffd9d Add GUI regression test for search results colors 
(cherry picked from commit a925e203d199daac8589efa2b5e9849474f1e3a1)
 2022-10-04 13:27:13 -07:00
Guillaume Gomez
69baa97520 Fix regression for results colors 
(cherry picked from commit ef410f1b01f1f3e54975b6142062c737875d6c22)
 2022-10-04 13:27:13 -07:00
Guillaume Gomez
218244646f Add GUI test for links colors 
(cherry picked from commit 5d449a017b1740939d56d42ab5025f9854b407b2)
 2022-10-04 13:26:58 -07:00
Guillaume Gomez
b5b2a93b47 Create new CSS variables for links color 
(cherry picked from commit 1c659977d6f2ff3b2d70cfb2607cd8725d9fbe03)
 2022-10-04 13:26:58 -07:00
Michael Goulet
df1e9317c1 Deny associated type bindings within associated type bindings 
(cherry picked from commit ca2e0bb51ad1a00190430134c67da5cda356745e)
 2022-10-04 12:57:03 -07:00
Frank Steffahn
658aa16696 Bless test output changes 
(cherry picked from commit 07767784ad667f4763e3ad6d7914849f3a43c65f)
 2022-10-04 12:52:29 -07:00
Frank Steffahn
50a843393b Fix a typo in error message 
(cherry picked from commit 696472a5867dafa35c5262da709677075fab9dc8)
 2022-10-04 12:52:29 -07:00
Oli Scherer
795a6da312 Fix wrongly refactored Lift impl 
(cherry picked from commit 3e6c9e5a194902ec6c8c26586fe6fa72dd624004)
 2022-10-04 12:52:19 -07:00
Ralf Jung
b11721537d fix ConstProp handling of written_only_inside_own_block_locals 
(cherry picked from commit 7373788c370a917c0472cbca30cfdf5d3c6ca086)
 2022-10-04 12:52:07 -07:00
lcnr
3ed6af5465 add test 
(cherry picked from commit 72a21027f5bee367bd9ccbeecc2528986f85d90b)
 2022-10-04 12:51:50 -07:00
lcnr
274d80213d improve infer var handling for implied bounds 
(cherry picked from commit 71f8fd5c5859fa09587486351f849277a910e4d9)
 2022-10-04 12:51:50 -07:00
Mark Rousskov
6504453ca2 Revert "fix #101691: copy stage0 binaries into stage0-sysroot" 
This reverts commit 32f8eb2fee4d6781a79052b560abd10e12ebb34f.

(cherry picked from commit f0c78ee3dc7c6b99a939e6afb7348ba8b543d7fd)
 2022-10-04 12:51:28 -07:00
Jack Huey
cf1c279224 Use Predicate ConstraintCategory when normalizing 
(cherry picked from commit e7ca6e1b47ce31ad544cd8f0eb7e5cd47b325e63)
 2022-10-04 12:51:09 -07:00
Jack Huey
923b120edc Add back in normalize call 
(cherry picked from commit 1eb71f08932f0935584432f47900c5b6ee6844ba)
 2022-10-04 12:51:09 -07:00
Jack Huey
8a8c370dbc Final bits 
(cherry picked from commit e09242d5b82953652b5a898257d7c8f249d34bea)
 2022-10-04 12:51:09 -07:00
Jack Huey
4854513ebd Add ExtraConstraintInfo 
(cherry picked from commit f1767dbb42374646fd5331d4946dc233e68d0ed5)
 2022-10-04 12:51:09 -07:00
Jack Huey
f174f66f7e Add AscribeUserTypeProvePredicate 
(cherry picked from commit 9929c0ac76bbbe2b3b8a0c28df91310067ae57fa)
 2022-10-04 12:51:09 -07:00
Jack Huey
8ecf3e7b78 Add outlives_constraint to BlameConstraint 
(cherry picked from commit ec17be2656fc69e212d9079f79322a68a3cfbc19)
 2022-10-04 12:51:09 -07:00
Jack Huey
e0bcd8ff35 Add to_constraint_category to ObligationCause and SubregionOrigin 
(cherry picked from commit 67653292beccfd3b88d13d9060d4e84c4a261f63)
 2022-10-04 12:51:09 -07:00
Jack Huey
d1cbeba32c Pass ConstraintCategory thorough a few more places 
(cherry picked from commit 6075877c897e1f6d2580ecd02a345b964b63d20d)
 2022-10-04 12:51:09 -07:00
Jack Huey
bafca234de Make QueryOutlivesConstraint contain a ConstraintCategory 
(cherry picked from commit a46376e247e947f6e7db5ac6da5da4d88249942a)
 2022-10-04 12:51:09 -07:00
Ding Xiang Fei
4e55812e3d add miri test via const fn 
(cherry picked from commit eb36f5ee5b71cbe3eb356f8e56e9c9a69b6d649d)
 2022-10-04 12:50:52 -07:00
Ding Xiang Fei
3f2c7e459e add mir-opt test 
(cherry picked from commit d510ba3bc3b6d41e36cb40b64af65637de39ff8b)
 2022-10-04 12:50:52 -07:00
Ding Xiang Fei
23e34ab49b avoid duplicating StorageLive in let-else 
(cherry picked from commit 48c1c1d19043120e9e89b3186d5d5286142f3066)
 2022-10-04 12:50:52 -07:00
bors
e5da98475e Auto merge of #102179 - pietroalbini:pa-beta-bump-stage0, r=Mark-Simulacrum 
[beta] Bump stage0

Last step of the release process.

r? `@Mark-Simulacrum`
 2022-09-24 17:19:46 +00:00
Pietro Albini
f9a5479de6
bump stage0 2022-09-23 11:42:13 +02:00
bors
2a65764f21 Auto merge of #102015 - rust-lang:pa-beta-next, r=pietroalbini 
[beta] Prepare beta 1.65.0

This PR prepares the beta branch for Rust 1.65.0.

r? `@ghost`
cc `@rust-lang/release`
 2022-09-19 20:08:44 +00:00
Mark Rousskov
ce70c6f3f3
Enable RUSTC_BOOTSTRAP for a few steps 2022-09-19 21:11:19 +02:00
Pietro Albini
b26e01b531
switch to the beta channel 2022-09-19 14:57:18 +02:00
Pietro Albini
4e76cbb524
replace stabilization placeholders 2022-09-19 14:54:16 +02:00
bors
48de123d7a Auto merge of #101857 - lcnr:make-dyn-again, r=jackh726 
change `FnMutDelegate` to trait objects

cc #100016 as mentioned in the last t-compiler meeting

r? `@jackh726`
 2022-09-17 13:37:48 +00:00
bors
672831a5c8 Auto merge of #101938 - Dylan-DPC:rollup-6vlohhs, r=Dylan-DPC 
Rollup of 6 pull requests

Successful merges:

 - #93628 (Stabilize `let else`)
 - #98441 (Implement simd_as for pointers)
 - #101790 (Do not suggest a placeholder to const and static without a type)
 - #101807 (Disallow defaults on type GATs)
 - #101915 (doc: fix redirected link in `/index.html`)
 - #101931 (doc: Fix a typo in `Rc::make_mut` docstring)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
 2022-09-17 10:56:42 +00:00
Dylan DPC
80cceb8f77
Rollup merge of #101931 - msakuta:master, r=thomcc 
doc: Fix a typo in `Rc::make_mut` docstring

A very minor typo fix.
 2022-09-17 15:31:09 +05:30
Dylan DPC
4515cb9621
Rollup merge of #101915 - notriddle:notriddle/redirect, r=GuillaumeGomez 
doc: fix redirected link in `/index.html`

Fallout from #101166
 2022-09-17 15:31:09 +05:30
Dylan DPC
7c55c992ab
Rollup merge of #101807 - jackh726:no-gat-defaults, r=lcnr 
Disallow defaults on type GATs

Fixes #99205
 2022-09-17 15:31:08 +05:30
Dylan DPC
4c64c14420
Rollup merge of #101790 - TaKO8Ki:do-not-suggest-placeholder-to-const-and-static-without-type, r=compiler-errors 
Do not suggest a placeholder to const and static without a type

Fixes #101755
 2022-09-17 15:31:08 +05:30
Dylan DPC
cbd561d41f
Rollup merge of #98441 - calebzulawski:simd_as, r=oli-obk 
Implement simd_as for pointers

Expands `simd_as` (and `simd_cast`) to handle pointer-to-pointer, pointer-to-integer, and integer-to-pointer conversions.

cc ``@programmerjake`` ``@thomcc``
 2022-09-17 15:31:07 +05:30
Dylan DPC
3ad81e0dd8
Rollup merge of #93628 - est31:stabilize_let_else, r=joshtriplett 
Stabilize `let else`

🎉  **Stabilizes the `let else` feature, added by [RFC 3137](https://github.com/rust-lang/rfcs/pull/3137).** 🎉

Reference PR: https://github.com/rust-lang/reference/pull/1156

closes #87335 (`let else` tracking issue)

FCP: https://github.com/rust-lang/rust/pull/93628#issuecomment-1029383585

----------

## Stabilization report

### Summary

The feature allows refutable patterns in `let` statements if the expression is
followed by a diverging `else`:

```Rust
fn get_count_item(s: &str) -> (u64, &str) {
    let mut it = s.split(' ');
    let (Some(count_str), Some(item)) = (it.next(), it.next()) else {
        panic!("Can't segment count item pair: '{s}'");
    };
    let Ok(count) = u64::from_str(count_str) else {
        panic!("Can't parse integer: '{count_str}'");
    };
    (count, item)
}
assert_eq!(get_count_item("3 chairs"), (3, "chairs"));
```

### Differences from the RFC / Desugaring

Outside of desugaring I'm not aware of any differences between the implementation and the RFC. The chosen desugaring has been changed from the RFC's [original](https://rust-lang.github.io/rfcs/3137-let-else.html#reference-level-explanations). You can read a detailed discussion of the implementation history of it in `@cormacrelf` 's [summary](https://github.com/rust-lang/rust/pull/93628#issuecomment-1041143670) in this thread, as well as the [followup](https://github.com/rust-lang/rust/pull/93628#issuecomment-1046598419). Since that followup, further changes have happened to the desugaring, in #98574, #99518, #99954. The later changes were mostly about the drop order: On match, temporaries drop in the same order as they would for a `let` declaration. On mismatch, temporaries drop before the `else` block.

### Test cases

In chronological order as they were merged.

Added by df9a2e0687895731e12f4a2651e8d70acd08872d (#87688):

* [`ui/pattern/usefulness/top-level-alternation.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/pattern/usefulness/top-level-alternation.rs) to ensure the unreachable pattern lint visits patterns inside `let else`.

Added by 5b95df4bdc330f34213812ad65cae86ced90d80c (#87688):

* [`ui/let-else/let-else-bool-binop-init.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-bool-binop-init.rs) to ensure that no lazy boolean expressions (using `&&` or `||`) are allowed in the expression, as the RFC mandates.
* [`ui/let-else/let-else-brace-before-else.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-brace-before-else.rs) to ensure that no `}` directly preceding the `else` is allowed in the expression, as the RFC mandates.
* [`ui/let-else/let-else-check.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-check.rs) to ensure that `#[allow(...)]` attributes added to the entire `let` statement apply for the `else` block.
* [`ui/let-else/let-else-irrefutable.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-irrefutable.rs) to ensure that the `irrefutable_let_patterns` lint fires.
* [`ui/let-else/let-else-missing-semicolon.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-missing-semicolon.rs) to ensure the presence of semicolons at the end of the `let` statement.
* [`ui/let-else/let-else-non-diverging.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-non-diverging.rs) to ensure the `else` block diverges.
* [`ui/let-else/let-else-run-pass.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-run-pass.rs) to ensure the feature works in some simple test case settings.
* [`ui/let-else/let-else-scope.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-scope.rs) to ensure the bindings created by the outer `let` expression are not available in the `else` block of it.

Added by bf7c32a4477a76bfd18fdcd8f45a939cbed82d34 (#89965):

* [`ui/let-else/issue-89960.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/issue-89960.rs) as a regression test for the ICE-on-error bug #89960 . Later in 102b9125e1cefbb8ed8408d2db3f9f7d5afddbf0 this got removed in favour of more comprehensive tests.

Added by 856541963ce95ef4f7d4a81784bb5002ccf63c93 (#89974):

* [`ui/let-else/let-else-if.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-if.rs) to test for the improved error message that points out that `let else if` is not possible.

Added by 9b45713b6c1775f0103a1ebee6ab7c6d9b781a21:

* [`ui/let-else/let-else-allow-unused.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-allow-unused.rs) as a regression test for #89807, to ensure that `#[allow(...)]` attributes added to the entire `let` statement apply for bindings created by the `let else` pattern.

Added by 61bcd8d3075471b3867428788c49f54fffe53f52 (#89841):

* [`ui/let-else/let-else-non-copy.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-non-copy.rs) to ensure that a copy is performed out of non-copy wrapper types. This mirrors `if let` behaviour. The test case bases on rustc internal changes originally meant for #89933 but then removed from the PR due to the error prior to the improvements of #89841.
* [`ui/let-else/let-else-source-expr-nomove-pass.rs `](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-source-expr-nomove-pass.rs) to ensure that while there is a move of the binding in the successful case, the `else` case can still access the non-matching value. This mirrors `if let` behaviour.

Added by 102b9125e1cefbb8ed8408d2db3f9f7d5afddbf0 (#89841):

* [`ui/let-else/let-else-ref-bindings.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-ref-bindings.rs) and [`ui/let-else/let-else-ref-bindings-pass.rs `](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-ref-bindings-pass.rs) to check `ref` and `ref mut` keywords in the pattern work correctly and error when needed.

Added by 2715c5f984fda7faa156d1c9cf91aa4934f0e00f (#89841):

* Match ergonomic tests adapted from the `rfc2005` test suite.

Added by fec8a507a27de1b08a0b95592dc8ec93bf0a321a (#89841):

* [`ui/let-else/let-else-deref-coercion-annotated.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-deref-coercion-annotated.rs) and [`ui/let-else/let-else-deref-coercion.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-deref-coercion.rs) to check deref coercions.

#### Added since this stabilization report was originally written (2022-02-09)

Added by 76ea56667703ac06689ff1d6fba5d170fa7392a7 (#94211):

* [`ui/let-else/let-else-destructuring.rs`](https://github.com/rust-lang/rust/blob/1.63.0/src/test/ui/let-else/let-else-destructuring.rs) to give a nice error message if an user tries to do an assignment with a (possibly refutable) pattern and an `else` block, like asked for in #93995.

Added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da (#94208):

* [`ui/let-else/let-else-allow-in-expr.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-allow-in-expr.rs) to test whether `#[allow(unused_variables)]` works in the expr, as well as its non presence, as well as putting it on the entire `let else` *affects* the expr, too. This was adding a missing test as pointed out by the stabilization report.
* Expansion of `ui/let-else/let-else-allow-unused.rs` and `ui/let-else/let-else-check.rs` to ensure that non-presence of `#[allow(unused)]` does issue the unused lint. This was adding a missing test case as pointed out by the stabilization report.

Added by 5bd71063b3810d977aa376d1e6dd7cec359330cc (#94208):

* [`ui/let-else/let-else-slicing-error.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-slicing-error.rs), a regression test for #92069, which got fixed without addition of a regression test. This resolves a missing test as pointed out by the stabilization report.

Added by 5374688e1d8cbcff7d1d14bb34e38fe6fe7c233e (#98574):

* [`src/test/ui/async-await/async-await-let-else.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/async-await/async-await-let-else.rs) to test the interaction of async/await with `let else`

Added by 6c529ded8674b89c46052da92399227c3b764c6a (#98574):

* [`src/test/ui/let-else/let-else-temporary-lifetime.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-temporary-lifetime.rs) as a (partial) regression test for #98672

Added by 9b566401068cb8450912f6ab48f3d0e60f5cb482 (#99518):

* [`src/test/ui/let-else/let-else-temp-borrowck.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-temporary-lifetime.rs) as a regression test for #93951
* Extension of `src/test/ui/let-else/let-else-temporary-lifetime.rs` to include a partial regression test for #98672 (especially regarding `else` drop order)

Added by baf9a7cb57120ec1411196214fd0d1c33fb18bf6 (#99518):

* Extension of `src/test/ui/let-else/let-else-temporary-lifetime.rs` to include a partial regression test for #93951, similar to `let-else-temp-borrowck.rs`

Added by 60be2de8b7b8a1c4eee7e065b8cef38ea629a6a3 (#99518):

* Extension of `src/test/ui/let-else/let-else-temporary-lifetime.rs` to include a program that can now be compiled thanks to borrow checker implications of #99518

Added by 47a7a91c969ed2edd12c674ca05c1baf867f6f6f (#100132):

* [`src/test/ui/let-else/issue-100103.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/issue-100103.rs), as a regression test for #100103, to ensure that there is no ICE when doing `Err(...)?` inside else blocks.

Added by e3c5bd617d040b5ee0bc79e6e7f01772adce791b (#100443):

* [`src/test/ui/let-else/let-else-then-diverge.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-then-diverge.rs), to verify that there is no unreachable code error with the current desugaring.

Added by 981852677c531d52f701b870bb27b45668a44d52 (#100443):

* [`src/test/ui/let-else/issue-94176.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/issue-94176.rs), to make sure that a correct span is emitted for a missing trailing expression error. Regression test for #94176.

Added by e182d12a8493b40a557394325a3a713b6528de60 (#100434):

* [src/test/ui/unpretty/pretty-let-else.rs](https://github.com/rust-lang/rust/blob/master/src/test/ui/unpretty/pretty-let-else.rs), as a regression test to ensure pretty printing works for `let else` (this bug surfaced in many different ways)

Added by e26285603ca8b83b9d06e56f74e10e3d410553ff (#99954):

* [`src/test/ui/let-else/let-else-temporary-lifetime.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-temporary-lifetime.rs) extended to contain & borrows as well, as this was identified as an earlier issue with the desugaring: https://github.com/rust-lang/rust/issues/98672#issuecomment-1200196921

Added by 2d8460ef43d902f34ba2133fe38f66ee8d2fdafc (#99291):

* [`src/test/ui/let-else/let-else-drop-order.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-drop-order.rs) a matrix based test for various drop order behaviour of `let else`. Especially, it verifies equality of `let` and `let else` drop orders, [resolving](https://github.com/rust-lang/rust/pull/93628#issuecomment-1238498468) a [stabilization blocker](https://github.com/rust-lang/rust/pull/93628#issuecomment-1055738523).

Added by 1b87ce0d4092045728c1c68282769d555706f273 (#101410):

* Edit to `src/test/ui/let-else/let-else-temporary-lifetime.rs` to add the `-Zvalidate-mir` flag, as a regression test for #99228

Added by af591ebe4d0cf2097a5fdc0bb710442d0f2e7876 (#101410):

* [`src/test/ui/let-else/issue-99975.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/issue-99975.rs) as a regression test for the ICE #99975.

Added by this PR:

* `ui/let-else/let-else.rs`, a simple run-pass check, similar to `ui/let-else/let-else-run-pass.rs`.

### Things not currently tested

* ~~The `#[allow(...)]` tests check whether allow works, but they don't check whether the non-presence of allow causes a lint to fire.~~ → *test added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da*
* ~~There is no `#[allow(...)]` test for the expression, as there are tests for the pattern and the else block.~~ → *test added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da*
* ~~`let-else-brace-before-else.rs` forbids the `let ... = {} else {}` pattern and there is a rustfix to obtain `let ... = ({}) else {}`. I'm not sure whether the `.fixed` files are checked by the tooling that they compile. But if there is no such check, it would be neat to make sure that `let ... = ({}) else {}` compiles.~~ → *test added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da*
* ~~#92069 got closed as fixed, but no regression test was added. Not sure it's worth to add one.~~ → *test added by 5bd71063b3810d977aa376d1e6dd7cec359330cc*
* ~~consistency between `let else` and `if let` regarding lifetimes and drop order: https://github.com/rust-lang/rust/pull/93628#issuecomment-1055738523~~ → *test added by 2d8460ef43d902f34ba2133fe38f66ee8d2fdafc*

Edit: they are all tested now.

### Possible future work / Refutable destructuring assignments

[RFC 2909](https://rust-lang.github.io/rfcs/2909-destructuring-assignment.html) specifies destructuring assignment, allowing statements like `FooBar { a, b, c } = foo();`.
As it was stabilized, destructuring assignment only allows *irrefutable* patterns, which before the advent of `let else` were the only patterns that `let` supported.
So the combination of `let else` and destructuring assignments gives reason to think about extensions of the destructuring assignments feature that allow refutable patterns, discussed in #93995.

A naive mapping of `let else` to destructuring assignments in the form of `Some(v) = foo() else { ... };` might not be the ideal way. `let else` needs a diverging `else` clause as it introduces new bindings, while assignments have a default behaviour to fall back to if the pattern does not match, in the form of not performing the assignment. Thus, there is no good case to require divergence, or even an `else` clause at all, beyond the need for having *some* introducer syntax so that it is clear to readers that the assignment is not a given (enums and structs look similar). There are better candidates for introducer syntax however than an empty `else {}` clause, like `maybe` which could be added as a keyword on an edition boundary:

```Rust
let mut v = 0;
maybe Some(v) = foo(&v);
maybe Some(v) = foo(&v) else { bar() };
```

Further design discussion is left to an RFC, or the linked issue.
 2022-09-17 15:31:06 +05:30
bors
b195f5349a Auto merge of #101784 - reitermarkus:const-memchr, r=thomcc 
Simplify `const` `memchr`.

Extracted from https://github.com/rust-lang/rust/pull/101607.

Removes the need for `const_eval_select`.
 2022-09-17 08:15:35 +00:00
bors
4a12d10bcc Auto merge of #101928 - notriddle:rollup-pexhhxe, r=notriddle 
Rollup of 8 pull requests

Successful merges:

 - #101340 (Adding Fuchsia zxdb debugging walkthrough to docs)
 - #101741 (Adding needs-unwind arg to applicable compiler ui tests)
 - #101782 (Update `symbol_mangling` diagnostics migration)
 - #101878 (More simple formatting)
 - #101898 (Remove some unused CSS rules)
 - #101911 (rustdoc: remove no-op CSS on `.source .content`)
 - #101914 (rustdoc-json-types: Document that ResolvedPath can also be a union)
 - #101921 (Pass --cfg=bootstrap for rustdoc for proc_macro crates)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
 2022-09-17 05:45:28 +00:00
msakuta
673c43b6e1 Fix a typo in docstring 2022-09-17 13:58:53 +09:00
Michael Howell
cafca7d219
Rollup merge of #101921 - est31:bootstrap_cfg_rustdoc, r=joshtriplett 
Pass --cfg=bootstrap for rustdoc for proc_macro crates

This PR does three things:

* First, it passes --cfg=bootstrap on stage 0 for rustdoc invocations on proc_macro crates. This mirrors what we do already for rustc invocations of those, and is needed because cargo doesn't respect RUSTFLAGS or RUSTDOCFLAGS when confronted with a proc macro.
* Second, it marks the bootstrap config variable as expected. This is needed both on later stages where it's not set, but also on stage 0, where it is set.
* Third, it adjusts the comment in the rustc wrapper to better reflect the reason why we set the bootstrap variable as
  expected: due to recent changes, setting it as expected
  is also required even if the cfg variable is passed: ebf4cc361e0d0f11a25b42372bd629953365d17e .
 2022-09-16 20:37:17 -07:00
Michael Howell
bba939ee94
Rollup merge of #101914 - aDotInTheVoid:rdj-path-union-docs, r=jsha 
rustdoc-json-types: Document that ResolvedPath can also be a union

r? rustdoc
 2022-09-16 20:37:17 -07:00
Michael Howell
b1178afcb4
Rollup merge of #101911 - notriddle:notriddle/source-content, r=GuillaumeGomez 
rustdoc: remove no-op CSS on `.source .content`

# `margin-left: 0`

This rule originated in 7669f04fb0ddc3d71a1fb44dc1c5c00a6564ae99, to override the default, massive left margin that content used to accommodate the sidebar:

7669f04fb0/src/librustdoc/html/static/main.css (L307-L309)

This massive left margin doesn't exist any more. It was replaced with a flexbox-based sidebar layout in 135281ed1525db15edd8ebd092aa10aa40df2386.

# `max-width: none`

This rule originated in 7669f04fb0ddc3d71a1fb44dc1c5c00a6564ae99, to override the default, limited line-width that makes sense for prose, but doesn't make sense for code (which typically uses hard-wrapped lines):

7669f04fb0/src/librustdoc/html/static/main.css (L153)

This line width limiter isn't applied to the `<div class="content">` node any more. It's been moved to a separate wrapper `<div>` that used to be called `main-inner` (in 135281ed1525db15edd8ebd092aa10aa40df2386) but is now called `width-limiter` (since d7528e2157762fadb9665518fd1e4dee6d6a2809).
 2022-09-16 20:37:17 -07:00