itsscb/sqlx
1
0
Fork 0
mirror of https://github.com/launchbadge/sqlx.git synced 2025-12-29 21:00:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: audit sqlx_postgres::types::bit_vec for casts involving sign loss

Browse Source
This commit is contained in:
Austin Bonander 2024-08-16 13:21:23 -07:00
parent af9cce726b
commit ea2926135f
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sqlx-postgres/src/types/bit_vec.rs
View File

@ -52,15 +52,10 @@ impl Decode<'_, Postgres> for BitVec {
let mut bytes = value.as_bytes()?;
let len = bytes.get_i32();
if len < 0 {
Err(io::Error::new(
io::ErrorKind::InvalidData,
"Negative VARBIT length.",
))?
}
let len = usize::try_from(len).map_err(|_| format!("invalid VARBIT len: {len}"))?;
// The smallest amount of data we can read is one byte
let bytes_len = (len as usize + 7) / 8;
let bytes_len = (len + 7) / 8;
if bytes.remaining() != bytes_len {
Err(io::Error::new(
@ -74,7 +69,7 @@ impl Decode<'_, Postgres> for BitVec {
// Chop off zeroes from the back. We get bits in bytes, so if
// our bitvec is not in full bytes, extra zeroes are added to
// the end.
while bitvec.len() > len as usize {
while bitvec.len() > len {
bitvec.pop();
}